tde-devels July 2011

devels@trinitydesktop.org

16 participants
28 discussions

--enable-closure
by Tiago Marques 30 Jul '11

30 Jul '11

Hi all, I was reading through the build documentation and found the --enable-closure option. Configure's description isn't exactly great, does anyone know what's the significance of this for packages that don't need it to build?(if that's a requirement for mentioned for some packages) Best regards, Tiago

1 0

Re: July Meeting
by Robert Xu 27 Jul '11

27 Jul '11

Was relatively short. BUG FIXING. Please note the mirror syncs every 6 hours. ================================ #trinity-desktop-meeting Meeting ================================ Meeting started by Xu_R at 23:01:17 UTC. The full logs are available at http://ftp.heanet.ie/pub/lincomlinux/MeetBot/trinity-desktop-meeting/2011/t… . Please note the mirror syncs every 6 hours. Meeting summary --------------- * Bug Fixing (Xu_R, 23:02:33) * AGREED: 3.5.13 is blocked on bug fixing. Majority of bugs on the tracker need to be fixed before release time (Xu_R, 23:03:50) * cmake Progress (Xu_R, 23:07:12) * is not a blocker for 3.5.13 anymore (Xu_R, 23:07:39) * tqtinterface, arts, kdelibs, and kdebase need to be built with cmake (Xu_R, 23:12:23) * the rest are optional, autotools still works for those (Xu_R, 23:12:57) * TQt4 Progress (Xu_R, 23:13:58) * ACTION: Refresh the Roadmap on the wiki (Xu_R, 23:23:09) * Last Items (Xu_R, 23:23:49) * After 3.5.13, a transition will be made to move to GIT (Xu_R, 23:32:46) * LINK: patchwork.trinitydesktop.org Patchwork (Xu_R, 23:33:06) * 3.5.13 will have Arch support (Xu_R, 23:33:16) * Nightly Builds for Ubuntu Natty are starting (Xu_R, 23:33:32) * Developer Portal Coming Soon (Xu_R, 23:35:56) Meeting ended at 23:38:29 UTC. Action Items ------------ * Refresh the Roadmap on the wiki Action Items, by person ----------------------- * **UNASSIGNED** * Refresh the Roadmap on the wiki People Present (lines said) --------------------------- * Xu_R (67) * kb9vqf (51) * MTurkey (10) * [lindaemon] (2) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- later, Robert Xu + rxu AT lincomlinux DOT org

2 1

Re: July Meeting
by Robert Xu 26 Jul '11

26 Jul '11

Just a wake-up call that there is a meeting approx. 20 minutes from the time of this email (1900 EDT 26/7/11). -- later, Robert Xu + rxu AT lincomlinux DOT org

1 0

[PATCH] kopete_plugin_nowlistening_plain.diff
by Slávek Banko 26 Jul '11

26 Jul '11

Hi. I have tiny patch, that fix problem with html special chars (especially &) in messages from nowlistening plugin in kopete. Kopete::Message::RichText expects already escaped chars, but messages from nowlistening is plain text. With Kopete::Message::PlainText is message valid. Slavek

1 0

[PATCH] kopete_jabber_pongserver.diff
by Slávek Banko 26 Jul '11

26 Jul '11

Hi. I have small patch, that add xep-0199 respond to kopete. See https://bugs.kde.org/show_bug.cgi?id=198789 Tested on KDE 3.5.10 and Trinity 3.5.12. Thanks Slávek --

1 0

[PATCH master 1/1] bnc584223.diff
by Patches＠Lincom 26 Jul '11

26 Jul '11

Hi! This is rxu_patch(a)lincomlinux.org. I'm writing this email to send a new patch to the list. The Reply-To for this email address is: robxu9 <AT> gmail <DOT> com. Mailing lists may change this depending on configured settings. The preferred method is to reply to the list. Thanks! Patches At Lincom. Patch is included below: Fixes bnc#584223, which is a security issue noted on CVE-2010-0436. It is referenced here: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-0436 --- kdebase-3.5.10/kdm/backend/ctrl.c.sav 2010-03-23 13:22:28.000000000 +0100 +++ kdebase-3.5.10/kdm/backend/ctrl.c 2010-03-23 14:21:48.619350322 +0100 @@ -78,7 +78,25 @@ nukeSock( struct cmdsock *cs ) } +#ifdef HONORS_SOCKET_PERMS static CtrlRec ctrl = { 0, 0, -1, 0, 0, { -1, 0, 0 } }; +#else +static CtrlRec ctrl = { 0, 0, 0, -1, 0, 0, { -1, 0, 0 } }; + +static int mkTempDir( char *dir ) +{ + int i, l = strlen( dir ) - 6; + + for (i = 0; i < 100; i++) { + randomStr( dir + l ); + if (!mkdir( dir, 0700 )) + return True; + if (errno != EEXIST) + break; + } + return False; +} +#endif void openCtrl( struct display *d ) @@ -140,22 +158,50 @@ openCtrl( struct display *d ) if (strlen( cr->path ) >= sizeof(sa.sun_path)) LogError( "path %\"s too long; no control sockets will be available\n", cr->path ); - else if (mkdir( sockdir, 0755 ) && errno != EEXIST) +#ifdef HONORS_SOCKET_PERMS + else if (mkdir( sockdir, 0700 ) && errno != EEXIST) LogError( "mkdir %\"s failed; no control sockets will be available\n", sockdir ); + else if (unlink( cr->path ) && errno != ENOENT) + LogError( "unlink %\"s failed: %m; control socket will not be available\n", + cr->path ); else { - if (!d) - chown( sockdir, -1, fifoGroup ); +#else + else if (unlink( sockdir ) && errno != ENOENT) + LogError( "unlink %\"s failed: %m; control socket will not be available\n", + sockdir ); + else if (!strApp( &cr->realdir, sockdir, "-XXXXXX", (char *)0)) + ; + else if (!mkTempDir( cr->realdir )) { + LogError( "mkdir %\"s failed: %m; control socket will not be available\n", + cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; + } else if (symlink( cr->realdir, sockdir )) { + LogError( "symlink %\"s => %\"s failed: %m; control socket will not be available\n", + sockdir, cr->realdir ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; + } else { + chown( sockdir, 0, d ? 0 : fifoGroup ); chmod( sockdir, 0750 ); +#endif if ((cr->fd = socket( PF_UNIX, SOCK_STREAM, 0 )) < 0) LogError( "Cannot create control socket\n" ); else { - unlink( cr->path ); sa.sun_family = AF_UNIX; strcpy( sa.sun_path, cr->path ); if (!bind( cr->fd, (struct sockaddr *)&sa, sizeof(sa) )) { if (!listen( cr->fd, 5 )) { +#ifdef HONORS_SOCKET_PERMS + chmod( cr->path, 0660 ); + if (!d) + chown( cr->path, -1, fifoGroup ); + chmod( sockdir, 0755 ); +#else chmod( cr->path, 0666 ); +#endif RegisterCloseOnFork( cr->fd ); RegisterInput( cr->fd ); free( sockdir ); @@ -170,6 +216,14 @@ openCtrl( struct display *d ) close( cr->fd ); cr->fd = -1; } +#ifdef HONORS_SOCKET_PERMS + rmdir( sockdir ); +#else + unlink( sockdir ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; +#endif } free( cr->path ); cr->path = 0; @@ -190,7 +244,14 @@ closeCtrl( struct display *d ) cr->fd = -1; unlink( cr->path ); *strrchr( cr->path, '/' ) = 0; +#ifdef HONORS_SOCKET_PERMS rmdir( cr->path ); +#else + unlink( cr->path ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; +#endif free( cr->path ); cr->path = 0; while (cr->css) { @@ -218,12 +279,12 @@ chownCtrl( CtrlRec *cr, int uid ) { if (cr->fpath) chown( cr->fpath, uid, -1 ); - if (cr->path) { - char *ptr = strrchr( cr->path, '/' ); - *ptr = 0; + if (cr->path) +#ifdef HONORS_SOCKET_PERMS chown( cr->path, uid, -1 ); - *ptr = '/'; - } +#else + chown( cr->realdir, uid, -1 ); +#endif } void --- kdebase-3.5.10/kdm/backend/dm.h.sav 2010-03-23 13:22:28.401354858 +0100 +++ kdebase-3.5.10/kdm/backend/dm.h 2010-03-23 13:28:24.843351116 +0100 @@ -218,6 +218,9 @@ typedef struct { struct cmdsock *css; /* open connections */ char *path; /* filename of the socket */ +#ifndef HONORS_SOCKET_PERMS + char *realdir; /* real dirname of the socket */ +#endif int fd; /* fd of the socket */ int gid; /* owner group of the socket */ --- kdebase-3.5.10/config.h.in.sav 2008-08-20 18:00:23.000000000 +0200 +++ kdebase-3.5.10/config.h.in 2010-03-23 13:36:38.913475918 +0100 @@ -739,6 +739,9 @@ /* Defined if your system has XRandR support */ #undef XRANDR_SUPPORT +/* Define to 1 if OS honors permission bits on socket inodes */ +#undef HONORS_SOCKET_PERMS + /* * jpeg.h needs HAVE_BOOLEAN, when the system uses boolean in system * headers and I'm too lazy to write a configure test as long as only --- kdebase-3.5.10/configure.in.in.sav 2006-07-22 10:15:55.000000000 +0200 +++ kdebase-3.5.10/configure.in.in 2010-03-23 13:51:24.504477535 +0100 @@ -274,3 +274,31 @@ AC_SUBST(LIBART_RPATH) AC_ARG_WITH([composite], AC_HELP_STRING([--without-composite], [Disable Xcomposite support (default: check)]) ) +AC_TRY_RUN([ +#include <sys/socket.h> +#include <sys/un.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <string.h> +#include <unistd.h> +#include <errno.h> +int main() +{ + int fd, fd2; + struct sockaddr_un sa; + + if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) + return 2; + sa.sun_family = AF_UNIX; + strcpy(sa.sun_path, "testsock"); + unlink(sa.sun_path); + if (bind(fd, (struct sockaddr *)&sa, sizeof(sa))) + return 2; + chmod(sa.sun_path, 0); + setuid(getuid() + 1000); + if ((fd2 = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) + return 2; + connect(fd2, (struct sockaddr *)&sa, sizeof(sa)); + return errno != EACCES; +} +], AC_DEFINE_UNQUOTED(HONORS_SOCKET_PERMS, 1, [Define to 1 if OS honors permission bits on socket inodes]))

2 2

July Meeting
by Robert Xu 26 Jul '11

26 Jul '11

Meeting Tuesday 26 July 2011 - 1400 EDT or 1900 EDT? I don't have preference right now, but I'd like to know people's thoughts. -- later, Robert Xu + rxu AT lincomlinux DOT org

2 4

Tiny patch for kdelibs
by Marko Käning 24 Jul '11

24 Jul '11

Hi devs, I realized that kdelibs version 3.5.12 still has a bug which hit me very recently with 3.5.10 on Mac OS X Lion. The linker was obviously less forgiving concerning undeclared external functions caused due to missing header files, like stdio.h. Please check out http://trac.macports.org/ticket/30314 and see the patch at http://trac.macports.org/browser/trunk/dports/kde/kdelibs3/files/patch-stdi… which made building possible on Lion. Since it's of general platform-independent interest I thought I better post this here as well. Greets, Marko

2 1

Trinity on OSX via MacPorts
by Marko Käning 23 Jul '11

23 Jul '11

Hi devs, yesterday I had a very pleasant chat via IRC with kb9vqf on #trinity-desktop concerning the topic of bringing trinity to Mac OS X. Since the ports qt3 and qt3-mac as well as all the KDE3 stuff aren't really maintained anymore on MacPorts it would be very interesting to try and port trinity for the Mac more natively. I'll try to set build your latest version of qt3 (3.3.8d?) from your git repo. (From the current qt3 port sources at MacPorts I see that already tons of patches are incorporated…) Once that is figured out I would try to move forward with kdelibs, kdepimlibs, kderuntime and probably others. My final objective is to bring trinity on MacPorts to a stage that KMyMoney 1.0.5 can be build, since KMyMoney4 on KDE4 on MacOSX still shows loads of quircks and is noticeably slower as well. But I guess this might be a long way, since all the X11 stuff and god knows what else needs to be working nicely with trinity. For that I guess I should at first know which dependencies I need to fulfill to successfully build qt3 for a start. Hints and help welcome. :-) I am surprised and happy about the fact that KDE3 isn't dead. I know that KDE4 has many interesting and modern features and technologies, but it's unfortunately still not as stable as the mature 3.5.*. I guess it tries to much to become more like MacOSX… I always liked KDE3 on my Linuxes during the past years, so it's great to know that there is a community which is still trying to keep this nice project going. Greets, Marko

2 1

[PATCH] media-teardown_crypto.diff
by Patches＠Lincom 22 Jul '11

22 Jul '11

NOTE: This is a resubmitted patch. Hi! This is rxu_patch(a)lincomlinux.org. I'm writing this email to send a new patch to the list. The Reply-To for this email address is: robxu9 <AT> gmail <DOT> com. Mailing lists may change this depending on configured settings. The preferred method is to reply to the list. Thanks! Patches At Lincom. Patch is included below: --- Index: kioslave/media/mediamanager/halbackend.cpp =================================================================== --- kioslave/media/mediamanager/halbackend.cpp.orig 2011-05-31 13:41:55.000000000 +0200 +++ kioslave/media/mediamanager/halbackend.cpp 2011-05-31 13:42:48.317334543 +0200 @@ -1379,4 +1379,54 @@ QString HALBackend::unmount(const QStrin return QString(); } +bool HALBackend::teardown(const QString &_udi) +{ + const char* dm_udi = _udi.latin1(); + const QString blockudi = libhal_device_get_property_QString(m_halContext, dm_udi, "volume.crypto_luks.clear.backing_volume"); + if (!blockudi.isEmpty()) { + const char* udi = blockudi.latin1(); + DBusMessage *dmesg, *reply; + DBusError error; + const char *options[2]; + + kdDebug() << "tearDown " << udi << "..." << endl; + + dbus_error_init(&error); + DBusConnection *dbus_connection = dbus_bus_get(DBUS_BUS_SYSTEM, &error); + if (dbus_error_is_set(&error)) + { + dbus_error_free(&error); + return false; + } + + if (!(dmesg = dbus_message_new_method_call ("org.freedesktop.Hal", udi, + "org.freedesktop.Hal.Device.Volume.Crypto", + "Teardown"))) { + kdDebug() << "teardown failed for " << udi << ": could not create dbus message\n"; + return false; + } + + dbus_error_init (&error); + if (!(reply = dbus_connection_send_with_reply_and_block (dbus_connection, dmesg, -1, &error))) + { + QString qerror; + + kdDebug() << "teardown failed for " << udi << ": " << error.name << " " << error.message << endl; + qerror = QString("teardown failed for %1 because: %2").arg(udi).arg(error.name); + dbus_message_unref (dmesg); + dbus_error_free (&error); + return false; + } + + kdDebug() << "teardown queued for " << udi << endl; + + dbus_message_unref (dmesg); + dbus_message_unref (reply); + return true; + } + + return false; +} + + #include "halbackend.moc" Index: kioslave/media/mediamanager/halbackend.h =================================================================== --- kioslave/media/mediamanager/halbackend.h.orig 2011-05-31 13:39:05.000000000 +0200 +++ kioslave/media/mediamanager/halbackend.h 2011-05-31 13:42:48.317334543 +0200 @@ -85,6 +85,7 @@ public: QString mount(const QString &id); QString mount(const Medium *medium); QString unmount(const QString &id); + bool teardown(const QString &_udi); static bool isHotplug( const QString & id ); Index: kioslave/media/mediamanager/mediamanager.cpp =================================================================== --- kioslave/media/mediamanager/mediamanager.cpp.orig 2011-05-31 13:39:05.000000000 +0200 +++ kioslave/media/mediamanager/mediamanager.cpp 2011-05-31 13:43:07.916484054 +0200 @@ -232,6 +232,17 @@ QString MediaManager::unmount(const QStr #endif } +bool MediaManager::teardown(const QString &name) +{ +#ifdef COMPILE_HALBACKEND + if (!m_halbackend) + return false; + return m_halbackend->teardown(name); +#else + return false; +#endif +} + QString MediaManager::nameForLabel(const QString &label) { const QPtrList<Medium> media = m_mediaList.list(); Index: kioslave/media/mediamanager/mediamanager.h =================================================================== --- kioslave/media/mediamanager/mediamanager.h.orig 2011-05-31 13:39:05.000000000 +0200 +++ kioslave/media/mediamanager/mediamanager.h 2011-05-31 13:42:48.318334448 +0200 @@ -47,6 +47,7 @@ k_dcop: QString mount(const QString &uid); QString unmount(const QString &uid); + bool teardown(const QString &uid); QString nameForLabel(const QString &label); ASYNC setUserLabel(const QString &name, const QString &label); Index: kioslave/media/mounthelper/kio_media_mounthelper.h =================================================================== --- kioslave/media/mounthelper/kio_media_mounthelper.h.orig 2007-01-15 12:31:31.000000000 +0100 +++ kioslave/media/mounthelper/kio_media_mounthelper.h 2011-05-31 13:42:48.318334448 +0200 @@ -40,6 +40,8 @@ private: QString m_errorStr; QString m_device; bool m_isCdrom; + bool isCryptMedia(QString); + bool teardown(QString); private slots: void ejectFinished(KProcess* proc); Index: kioslave/media/mounthelper/kio_media_mounthelper.cpp =================================================================== --- kioslave/media/mounthelper/kio_media_mounthelper.cpp.orig 2007-05-14 09:55:40.000000000 +0200 +++ kioslave/media/mounthelper/kio_media_mounthelper.cpp 2011-05-31 13:42:48.319334353 +0200 @@ -27,6 +27,7 @@ #include <dcopclient.h> #include <dcopref.h> #include <qtimer.h> +#include <qregexp.h> #include <stdlib.h> #include <kdebug.h> #include <kglobal.h> @@ -117,14 +118,17 @@ MountHelper::MountHelper() : KApplicatio DCOPRef mediamanager("kded", "mediamanager"); DCOPReply reply = mediamanager.call( "unmount", medium.id()); if (reply.isValid()) - reply.get(m_errorStr); - if (m_errorStr.isNull()) - invokeEject(device, true); - else - error(); + reply.get(m_errorStr); + if (m_errorStr.isNull()) { + if (!teardown(medium.id())) + invokeEject(device, true); + } else + error(); m_device = device; - } else - invokeEject(device, true); + } else { + if (!teardown(medium.id())) + invokeEject(device, true); + } } else { @@ -139,6 +143,19 @@ MountHelper::MountHelper() : KApplicatio } } +bool MountHelper::teardown(QString id) +{ + DCOPRef mediamanager("kded", "mediamanager"); + DCOPReply reply = mediamanager.call( "teardown", id); + if (reply.isValid()) { + bool rep; + reply.get(rep); + kdDebug() << "reply from teardown: " << rep << endl; + return rep; + } + return false; +} + void MountHelper::invokeEject(const QString &device, bool quiet) { KProcess *proc = new KProcess(this);

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

tde-devels July 2011