tde-devels

devels@trinitydesktop.org

3 participants
3808 discussions

tdepim - gcc47 - need help with "which redeclared 'it' is right 'it'?"
by David C. Rankin 19 Apr '12

19 Apr '12

Calvin, Slavek, Liddell, I'm trying to fix tdepim to build with gcc47, but I don't understand how to make sure I'm fixing the right 'it' iterator. Specifically, the multiple declaration issue is: /build/src/tdepim/kmail/kmsystemtray.cpp: In member function 'void KMSystemTray::updateNewMessages()': /build/src/tdepim/kmail/kmsystemtray.cpp:485:48: error: redeclaration of 'TQMap<TQGuardedPtr<KMFolder>, int>::Iterator it' /build/src/tdepim/kmail/kmsystemtray.cpp:475:55: error: 'TQMap<TQGuardedPtr<KMFolder>, bool>::Iterator it' previously declared here The code beginning at line 473 is: void KMSystemTray::updateNewMessages() { for ( TQMap<TQGuardedPtr<KMFolder>, bool>::Iterator it = mPendingUpdates.begin(); it != mPendingUpdates.end(); ++it) { KMFolder *fldr = it.key(); if ( !fldr ) // deleted folder continue; /** The number of unread messages in that folder */ int unread = fldr->countUnread(); TQMap<TQGuardedPtr<KMFolder>, int>::Iterator it = mFoldersWithUnread.find(fldr); bool unmapped = (it == mFoldersWithUnread.end()); /** If the folder is not mapped yet, increment count by numUnread in folder */ if(unmapped) mCount += unread; /* Otherwise, get the difference between the numUnread in the folder and * our last known version, and adjust mCount with that difference */ else { int diff = unread - it.data(); mCount += diff; } Looking through the comments and context, there seems to be two 'it' iterators involved: TQMap<.., bool>::...it TQMap<.., int>::...it with the 'bool' declaration being the loop index and the 'int' being used to determine if the folder with unread messages is unmapped. The 'bool' dec seems to be the one used to access the class data (i.e. it.key(), it.data()) If I'm reading that correctly, then we can correct the 'int' iterator by renaming it something like 'unread_it' TQMap<TQGuardedPtr<KMFolder>, int>::Iterator unread_it = mFoldersWithUnread.find(fldr); bool unmapped = (unread_it == mFoldersWithUnread.end()); What say the experts. Is my reading of which 'it' can be renamed correct? -- David C. Rankin, J.D.,P.E.

3 9

TDE spring fundraiser status
by Timothy Pearson 19 Apr '12

19 Apr '12

I am cross-posting this as I know some of you are not signed up for the trinity-announce mailing list: http://trinity-announce.pearsoncomputing.net/?0::21 Tim

2 1

Calvin: Thanks!
by Darrell Anderson 19 Apr '12

19 Apr '12

I have so much enjoyed being able to disable the cycling feature with the task bar and pager applet (bug reports 251 and 908). Both patches have reduced my irritability/anxiety levels. :) 'Tis the little things that often affect us most. :) Darrell

2 2

k3b -bug ('K3bAudioEditorWidget::Range* r' previously declared here)
by David C. Rankin 18 Apr '12

18 Apr '12

Darrell, all I'm making an attempt at fixing k3b for gcc47. If anyone else has already done this please stop me. It is part of bug 958. -- David C. Rankin, J.D.,P.E.

4 12

Tim: Collation of TSAK/TDM related issues
by Darrell Anderson 18 Apr '12

18 Apr '12

Collation of TSAK/TDM related issues (there are overlaps in descriptions but that does not mean the same exact problem): Bug reports involved: 928, kdm starts too early 925, [kdesktop] SAK driven secure dialog is not available for use 906, SAK realization is mostly buggy for KDM 898, tsak process taking 90-100% of CPU 894, TDM: Log file is never purged 884, tdmctl: Cannot connect socket '/var/run/xdmctl/dmctl-:0/socket' 667, kdm spawns kwin as root, keeps running after login 625, KDM is hard-coded to use /tmp rather than $TMP or $TMPDIR ================================================== Direct TSAK issues: * TSAK demands 90-100% CPU. * High CPU consumption on wait SAK. * TSAK/TDM performs no housekeeping to remove pipe/socket files: 1) During a reboot/halt (when TDM terminates) 2) X server restart (which TDM allows) 3) When a user disables TSAK in KControl (tdmrc:UseSAK=false) * Restarting X server or TSAK ignores the tdmrc:UseSAK=false, using the existing pipe/socket files instead and keeps running even when explicitly disabled in tdmrc. * When building tdebase without TSAK support (-DBUILD_TSAK=OFF), and tdmrc:UseSAK=false, TDM starts with the dialog to press Ctrl-Alt-Del. That should not happen. * Disabling TSAK in tdmrc (UseSAK=false) does not work. * Exit from wait dialog by Ctrl+Alt+Del does not work. * Some people cannot obtain access to the TDM login dialog when pressing Ctrl-Alt-Del. * TSAK ownership of /tmp/tdesocket-global is assigned to the system's primary login account. Ownership of that directory is determined by the account UID listed in the tdmrc MinShowUID key and then that account number is grabbed from /etc/passwd. * xsession message of "[kdesktop] SAK driven secure dialog is not available for use (retcode %d)" appears although TDM is not running when using startx. ================================================== Related to TDM and TSAK: * When starting X from startx (TDM is not running) the message "tdmctl: Cannot connect socket '/var/run/xdmctl/dmctl-:0/socket'" appears. There should be no tdmctl/TSAK related messages when using startx. * Both calls to tdmctl in tdmtsak use the format "tdmctl list" yet there is no "list" option in tdmctl --help. What is the "list" parameter supposed to do? * TDM creates nominal profile directories in /tmp. All such directories use a numeric name string. TDM runs as non-user, but should not be creating any profile directories. Not needed and the profile directories are never purged. Never happened in KDE3. ================================================== TDM specific: * TDM starts too early * TDM log files never purged. * TDM spawns twin as root, keeps running after login I hope this helps. :) Darrell

2 2

knemo - patch to change default backend from 'Nettools' to 'Sys'
by David C. Rankin 18 Apr '12

18 Apr '12

All, I'm trying to patch knemo to initialize with the Sys backend (as default) for the package. You have the option to set Nettools or Sys (kernel) providing network information to the monitor. Sys is much more efficient than Nettools, but only works for kernels >= 2.6 (which is everybody now). I wouldn't care or go to the effort is the Nettools backend still worked, but as of the Linux 3.0/3.1 kernels, (as well as later 2.6.X kernels) Nettools doesn't seem to work forcing the user to find and set the obscure setting to Sys before the module will work at all. I propose we make 'Sys' the default backend in TDE. Hunting and picking through the code, I have found where the default values are set for the backend as well as the colors for the plotter graph. There were a couple of structs and constructors involved depending on how knemo was launched. I have created a patch that does both (1) set the default backend to sys and (2) change the graph colors a bit so it is readable regardless of whether there is a dark/light background shown. Here is the patch, look it over, engage in discourse and if the yays are greater than the nays --> push it :) (works with gcc47 too :) -- David C. Rankin, J.D.,P.E.

3 7

tdegraphics/ksnapshot - not brining window to front before screenshot (gcc47 ??)
by David C. Rankin 18 Apr '12

18 Apr '12

All, I don't know if this is a focus problem, or a problem with ksnapshot itself. But with ksnapshot configured to capture 'window under cursor' with no delay, if the window is not the top window, ksnapshot will capture any overlying window within the geometry of the window you are trying to capture. I've opened a normal bug for it: http://bugs.pearsoncomputing.net/show_bug.cgi?id=966 I don't know if this is gcc47, a bug in the desktop when focus set to 'follow mouse' or what. I have never seen this behavior before. Here are a couple of screenshots: http://www.3111skyline.com/dl/dt/trinity/ss/ksnapshot-win-under-cursor-bug.… http://www.3111skyline.com/dl/dt/trinity/ss/ksnapshot-win-under-cursor-bug2… Also, if you notice, the right side of the window is not captured correctly either. (possible libpng15 issue??) Thoughts? tdegraphics build is: cmake ${srcdir}/${pkgname#*-} \ -DCMAKE_CXX_FLAGS="-fpermissive" \ -DCMAKE_VERBOSE_MAKEFILE=ON \ -DCMAKE_INSTALL_PREFIX=${TDEDIR} \ -DWITH_T1LIB=ON \ -DWITH_LIBPAPER=ON \ -DWITH_TIFF=ON \ -DWITH_OPENEXR=ON \ -DWITH_PDF=ON \ -DBUILD_ALL=ON (no patches) Thoughts? -- David C. Rankin, J.D.,P.E.

2 5

konsole "Prompt Tip" incorrect (with patch - review and push)
by David C. Rankin 18 Apr '12

18 Apr '12

Darrell, Here is a simple one for you. The 'tips' in konsole tips to set the prompt incorrectly uses a 'close' instead of 'open' bracket following the 'e' and incorrectly uses a ';' and omits the 'm' to terminate resetting the prompt background and bold state. The tips contain 3 similar references in the form: export PS1=$PS1"\[\e]0;\H:\w\a\]" This is wrong. It should be: export PS1=$PS1"\[\e[0m\H:\w\a\]" Note the second bracket is backwards... should be PS1=$PS1"\[\e[ ^ Further, to properly reset the background and bold state of the prompt (and to terminate non-printing characters) so that BASH can properly calculate prompt length and spacing, you must use '\[\e0m' not \[\e]0; (note the semicolon) The semicolon is used to separate the foreground/background colors not terminate the reset... You can see the differences when you look at the bad/good prompts stacked above/below each other: export PS1=$PS1"\[\e]0;\H:\w\a\]" export PS1=$PS1"\[\e[0m\H:\w\a\]" I've included a patch that fixes the existing 3 prompt tips and I have included 2 additional prompt tips as well. Review, signoff and push. If you don't want the additional 2 tips, just trim them from the patch. (I always like additional tips :) (no I won't explain how I found this :) -- David C. Rankin, J.D.,P.E.

3 5

New tqca package added to the source tree
by Darrell Anderson 18 Apr '12

18 Apr '12

I added tqca to the source tree. This module is from the original qca-1.0 sources with the TQt layer added. Adding the sources resolves bug report 817. Building the package is much the same as with the original qca-1.0 package. The core of the configuration: export PREFIX=/usr export LIBDIR=/usr/lib${LIBDIRSUFFIX} CFLAGS=$CPUOPT \ CXXFLAGS=$CPUOPT \ ./configure \ --prefix=${PREFIX} \ --qtdir=$QTDIR make $NUMJOBS VERBOSE=1 || exit 1 make install INSTALL_ROOT=$PKG || exit 1 /usr/doc files: COPYING INSTALL README TODO I install TQt3 to /opt/trinity. I install both tqca and tqca-tls to /usr rather than /opt/trinity, but I don't think the installation location is critical. I am building the package just before building tqca-tls. I have no clue how to test the package after installation. Then again, I have no idea how to test tqca-tls either. The tqca package requires about 5 seconds to build. Thus, troubleshooting should be a snap. For once. :) Darrell

1 0

Bug tracker queries
by Darrell Anderson 18 Apr '12

18 Apr '12

For those interested, I have created a series of bug tracker searches. Tim, Calvin, if possible, incorporating these queries as links in the page header would save many people time. Each search should be self-explanatory. :) ======================================= Build issue bugs: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Patches available bugs: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?que… ======================================= Usability bugs: Blocker: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Critical: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Major: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Normal: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Minor: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Trivial: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… ======================================= Enhancement and Wish List requests: http://bugs.pearsoncomputing.net/bugzilla/bugzilla/bugzilla/buglist.cgi?bug… Have fun. :) Darrell

3 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

tde-devels