tde-devels

devels@trinitydesktop.org

9 participants
3819 discussions

amarok's covermanager fix
by Ilya Chernykh 10 Aug '11

10 Aug '11

I have just received this patch that fixes amarok's covermanager: https://build.opensuse.org/package/view_file?file=bug-606951_covermanager-f… Bugzilla entry: https://bugzilla.novell.com/show_bug.cgi?id=606951

1 0

Re: [trinity-users] Trinity for Mandriva 2010.2
by Timothy Pearson 05 Aug '11

05 Aug '11

> The RPM builds for Mandriva are now largely complete and i've been using them on my own computers for about 2 weeks now without noticing any major issues. The packages are available from: > > http://www.autotrain.org/mdv-kde/mdv2010.2.html > > Tim W > This is excellent news! Would you like the packages added to the official Trinity mirror system? I am also forwarding this to the trinity-devel list so that our other developers who are working on RPM-based distributions are aware of your progress. Thanks! Tim

1 0

Re: [trinity-users] Trinity for Mandriva 2010.2
by Timothy Pearson 05 Aug '11

05 Aug '11

> The RPM builds for Mandriva are now largely complete and i've been using > them on my own computers for about 2 weeks now without noticing any major > issues. The packages are available from: > > http://www.autotrain.org/mdv-kde/mdv2010.2.html > > Tim W > This is excellent news! Would you like the packages added to the official Trinity mirror system? I am also forwarding this to the trinity-devel list so that our other developers who are working on RPM-based distributions are aware of your progress. Thanks! Tim

1 0

--enable-closure
by Tiago Marques 29 Jul '11

29 Jul '11

Hi all, I was reading through the build documentation and found the --enable-closure option. Configure's description isn't exactly great, does anyone know what's the significance of this for packages that don't need it to build?(if that's a requirement for mentioned for some packages) Best regards, Tiago

1 0

Re: July Meeting
by Robert Xu 27 Jul '11

27 Jul '11

Was relatively short. BUG FIXING. Please note the mirror syncs every 6 hours. ================================ #trinity-desktop-meeting Meeting ================================ Meeting started by Xu_R at 23:01:17 UTC. The full logs are available at http://ftp.heanet.ie/pub/lincomlinux/MeetBot/trinity-desktop-meeting/2011/t… . Please note the mirror syncs every 6 hours. Meeting summary --------------- * Bug Fixing (Xu_R, 23:02:33) * AGREED: 3.5.13 is blocked on bug fixing. Majority of bugs on the tracker need to be fixed before release time (Xu_R, 23:03:50) * cmake Progress (Xu_R, 23:07:12) * is not a blocker for 3.5.13 anymore (Xu_R, 23:07:39) * tqtinterface, arts, kdelibs, and kdebase need to be built with cmake (Xu_R, 23:12:23) * the rest are optional, autotools still works for those (Xu_R, 23:12:57) * TQt4 Progress (Xu_R, 23:13:58) * ACTION: Refresh the Roadmap on the wiki (Xu_R, 23:23:09) * Last Items (Xu_R, 23:23:49) * After 3.5.13, a transition will be made to move to GIT (Xu_R, 23:32:46) * LINK: patchwork.trinitydesktop.org Patchwork (Xu_R, 23:33:06) * 3.5.13 will have Arch support (Xu_R, 23:33:16) * Nightly Builds for Ubuntu Natty are starting (Xu_R, 23:33:32) * Developer Portal Coming Soon (Xu_R, 23:35:56) Meeting ended at 23:38:29 UTC. Action Items ------------ * Refresh the Roadmap on the wiki Action Items, by person ----------------------- * **UNASSIGNED** * Refresh the Roadmap on the wiki People Present (lines said) --------------------------- * Xu_R (67) * kb9vqf (51) * MTurkey (10) * [lindaemon] (2) Generated by `MeetBot`_ 0.1.4 .. _`MeetBot`: http://wiki.debian.org/MeetBot -- later, Robert Xu + rxu AT lincomlinux DOT org

2 1

Re: July Meeting
by Robert Xu 26 Jul '11

26 Jul '11

Just a wake-up call that there is a meeting approx. 20 minutes from the time of this email (1900 EDT 26/7/11). -- later, Robert Xu + rxu AT lincomlinux DOT org

1 0

[PATCH] kopete_plugin_nowlistening_plain.diff
by Slávek Banko 26 Jul '11

26 Jul '11

Hi. I have tiny patch, that fix problem with html special chars (especially &) in messages from nowlistening plugin in kopete. Kopete::Message::RichText expects already escaped chars, but messages from nowlistening is plain text. With Kopete::Message::PlainText is message valid. Slavek

1 0

[PATCH] kopete_jabber_pongserver.diff
by Slávek Banko 26 Jul '11

26 Jul '11

Hi. I have small patch, that add xep-0199 respond to kopete. See https://bugs.kde.org/show_bug.cgi?id=198789 Tested on KDE 3.5.10 and Trinity 3.5.12. Thanks Slávek --

1 0

[PATCH master 1/1] bnc584223.diff
by Patches＠Lincom 26 Jul '11

26 Jul '11

Hi! This is rxu_patch(a)lincomlinux.org. I'm writing this email to send a new patch to the list. The Reply-To for this email address is: robxu9 <AT> gmail <DOT> com. Mailing lists may change this depending on configured settings. The preferred method is to reply to the list. Thanks! Patches At Lincom. Patch is included below: Fixes bnc#584223, which is a security issue noted on CVE-2010-0436. It is referenced here: http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-0436 --- kdebase-3.5.10/kdm/backend/ctrl.c.sav 2010-03-23 13:22:28.000000000 +0100 +++ kdebase-3.5.10/kdm/backend/ctrl.c 2010-03-23 14:21:48.619350322 +0100 @@ -78,7 +78,25 @@ nukeSock( struct cmdsock *cs ) } +#ifdef HONORS_SOCKET_PERMS static CtrlRec ctrl = { 0, 0, -1, 0, 0, { -1, 0, 0 } }; +#else +static CtrlRec ctrl = { 0, 0, 0, -1, 0, 0, { -1, 0, 0 } }; + +static int mkTempDir( char *dir ) +{ + int i, l = strlen( dir ) - 6; + + for (i = 0; i < 100; i++) { + randomStr( dir + l ); + if (!mkdir( dir, 0700 )) + return True; + if (errno != EEXIST) + break; + } + return False; +} +#endif void openCtrl( struct display *d ) @@ -140,22 +158,50 @@ openCtrl( struct display *d ) if (strlen( cr->path ) >= sizeof(sa.sun_path)) LogError( "path %\"s too long; no control sockets will be available\n", cr->path ); - else if (mkdir( sockdir, 0755 ) && errno != EEXIST) +#ifdef HONORS_SOCKET_PERMS + else if (mkdir( sockdir, 0700 ) && errno != EEXIST) LogError( "mkdir %\"s failed; no control sockets will be available\n", sockdir ); + else if (unlink( cr->path ) && errno != ENOENT) + LogError( "unlink %\"s failed: %m; control socket will not be available\n", + cr->path ); else { - if (!d) - chown( sockdir, -1, fifoGroup ); +#else + else if (unlink( sockdir ) && errno != ENOENT) + LogError( "unlink %\"s failed: %m; control socket will not be available\n", + sockdir ); + else if (!strApp( &cr->realdir, sockdir, "-XXXXXX", (char *)0)) + ; + else if (!mkTempDir( cr->realdir )) { + LogError( "mkdir %\"s failed: %m; control socket will not be available\n", + cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; + } else if (symlink( cr->realdir, sockdir )) { + LogError( "symlink %\"s => %\"s failed: %m; control socket will not be available\n", + sockdir, cr->realdir ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; + } else { + chown( sockdir, 0, d ? 0 : fifoGroup ); chmod( sockdir, 0750 ); +#endif if ((cr->fd = socket( PF_UNIX, SOCK_STREAM, 0 )) < 0) LogError( "Cannot create control socket\n" ); else { - unlink( cr->path ); sa.sun_family = AF_UNIX; strcpy( sa.sun_path, cr->path ); if (!bind( cr->fd, (struct sockaddr *)&sa, sizeof(sa) )) { if (!listen( cr->fd, 5 )) { +#ifdef HONORS_SOCKET_PERMS + chmod( cr->path, 0660 ); + if (!d) + chown( cr->path, -1, fifoGroup ); + chmod( sockdir, 0755 ); +#else chmod( cr->path, 0666 ); +#endif RegisterCloseOnFork( cr->fd ); RegisterInput( cr->fd ); free( sockdir ); @@ -170,6 +216,14 @@ openCtrl( struct display *d ) close( cr->fd ); cr->fd = -1; } +#ifdef HONORS_SOCKET_PERMS + rmdir( sockdir ); +#else + unlink( sockdir ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; +#endif } free( cr->path ); cr->path = 0; @@ -190,7 +244,14 @@ closeCtrl( struct display *d ) cr->fd = -1; unlink( cr->path ); *strrchr( cr->path, '/' ) = 0; +#ifdef HONORS_SOCKET_PERMS rmdir( cr->path ); +#else + unlink( cr->path ); + rmdir( cr->realdir ); + free( cr->realdir ); + cr->realdir = 0; +#endif free( cr->path ); cr->path = 0; while (cr->css) { @@ -218,12 +279,12 @@ chownCtrl( CtrlRec *cr, int uid ) { if (cr->fpath) chown( cr->fpath, uid, -1 ); - if (cr->path) { - char *ptr = strrchr( cr->path, '/' ); - *ptr = 0; + if (cr->path) +#ifdef HONORS_SOCKET_PERMS chown( cr->path, uid, -1 ); - *ptr = '/'; - } +#else + chown( cr->realdir, uid, -1 ); +#endif } void --- kdebase-3.5.10/kdm/backend/dm.h.sav 2010-03-23 13:22:28.401354858 +0100 +++ kdebase-3.5.10/kdm/backend/dm.h 2010-03-23 13:28:24.843351116 +0100 @@ -218,6 +218,9 @@ typedef struct { struct cmdsock *css; /* open connections */ char *path; /* filename of the socket */ +#ifndef HONORS_SOCKET_PERMS + char *realdir; /* real dirname of the socket */ +#endif int fd; /* fd of the socket */ int gid; /* owner group of the socket */ --- kdebase-3.5.10/config.h.in.sav 2008-08-20 18:00:23.000000000 +0200 +++ kdebase-3.5.10/config.h.in 2010-03-23 13:36:38.913475918 +0100 @@ -739,6 +739,9 @@ /* Defined if your system has XRandR support */ #undef XRANDR_SUPPORT +/* Define to 1 if OS honors permission bits on socket inodes */ +#undef HONORS_SOCKET_PERMS + /* * jpeg.h needs HAVE_BOOLEAN, when the system uses boolean in system * headers and I'm too lazy to write a configure test as long as only --- kdebase-3.5.10/configure.in.in.sav 2006-07-22 10:15:55.000000000 +0200 +++ kdebase-3.5.10/configure.in.in 2010-03-23 13:51:24.504477535 +0100 @@ -274,3 +274,31 @@ AC_SUBST(LIBART_RPATH) AC_ARG_WITH([composite], AC_HELP_STRING([--without-composite], [Disable Xcomposite support (default: check)]) ) +AC_TRY_RUN([ +#include <sys/socket.h> +#include <sys/un.h> +#include <sys/stat.h> +#include <sys/types.h> +#include <string.h> +#include <unistd.h> +#include <errno.h> +int main() +{ + int fd, fd2; + struct sockaddr_un sa; + + if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) + return 2; + sa.sun_family = AF_UNIX; + strcpy(sa.sun_path, "testsock"); + unlink(sa.sun_path); + if (bind(fd, (struct sockaddr *)&sa, sizeof(sa))) + return 2; + chmod(sa.sun_path, 0); + setuid(getuid() + 1000); + if ((fd2 = socket(PF_UNIX, SOCK_STREAM, 0)) < 0) + return 2; + connect(fd2, (struct sockaddr *)&sa, sizeof(sa)); + return errno != EACCES; +} +], AC_DEFINE_UNQUOTED(HONORS_SOCKET_PERMS, 1, [Define to 1 if OS honors permission bits on socket inodes]))

2 2

July Meeting
by Robert Xu 25 Jul '11

25 Jul '11

Meeting Tuesday 26 July 2011 - 1400 EDT or 1900 EDT? I don't have preference right now, but I'd like to know people's thoughts. -- later, Robert Xu + rxu AT lincomlinux DOT org

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

tde-devels