On Tue, Mar 15, 2011 at 4:34 PM, Darrell Anderson humanreadable@yahoo.com wrote:
I don't read c++ very well. Seems to me that if $KDEHOME is not explicitly defined then Trinity defaults to $HOME/.kde3. Yet the comments in kstandardirs.h declare $HOME/.kde as the default.
============================================= kdelibs/kdecore/kstandardirs.cpp: ============================================= if (!localKdeDir.isEmpty()) { if (localKdeDir[localKdeDir.length()-1] != QChar('/')) localKdeDir += QChar('/'); } else { localKdeDir = TQDir::homeDirPath() + "/.kde3/"; } =============================================
============================================= kdelibs/kdecore/kstandardirs.h: ============================================= * @li KDEHOME: The directory where changes are saved to. This directory is * used to search for resources first. If KDEHOME is not * specified it defaults to "$HOME/.kde" =============================================
Should the comment be updated or the code in kstandardirs.cpp?
With all the branding issues that have arised, is $HOME/.kde3 a good choice? Or should the default be changed to $HOME/.trinity?
Trinity is supposed to be compatible with KDE4. In KDE4 the default for $KDEHOME is $HOME/.kde. Seems then that if $KDEHOME is explicitly declared in a KDE4 environment that Trinity will trash a user's KDE4 settings. Seems the best way to avoid any mess is to use a default $KDEHOME setting like $HOME/.trinity or $HOME/.kde3. I prefer the former as that avoids potential conflicts with older KDE3 systems too.
I think this issue needs attention.
Darrell
It doesn't really matter what $KDEHOME is, as long as TDE and KDE4 use a different one to avoid interfering with each other. The only reason to be specific is to stay organized and tell the difference between the two. I'm for $HOME/.trinity for consistency with the name Trinity.