On Friday 22 of August 2014 02:21:37 Timothy Pearson wrote:
Overall good work! The main thing I want to see at this point is autodetection of BSD so that we don't have to manually apply the first patch for all the others to work.
All, not to take anything away from the good work done by Francois (thanks!!), but I would like to propose we merge all the changes required for building on BSD to the origin/master branch *after* the release of v14.0.0 or at least after a separate branch for v14.0.0 has been created. The reason for this proposal is to avoid to potentially introduce new bugs so close to the finalization of v14.0.0 (don't forget that we are in a soft-freeze state). Opinions are welcomed of course.
Cheers Michele
Given how trivial the patches are I'd say merge anyway; there's nothing more complex than an ifdef added to the actual code and the build system is tested every time the binaries are rebuilt on the nightly builds PPA.
Tim
I hope this weekend I can find time to explore these patches from François. We can decide after that more eye inspect, revise and confirm these patches.
What do you think?