29 Oct
2012
29 Oct
'12
5:13 p.m.
here are kdegraphics comments.
Great!
Suggested changes:
adds support for t1lb -a library -> adds support for t1lb, a library
loose -> lose
this library is used only for set default parametrs -> this library sets default
parameters
planed -> planned
but it wasn't implemented or was rejected -> but hasn't yet been ported
A quick history of cmake in Trinity:
The cmake ports are an ongoing process. There are additional packages where the cmake port
was started but have not matured to a point of usability. All packages contains some
rudiments of porting to cmake, but this is a long term process. One of our R14 goals is to
complete the ports for some more packages. Note too that with each port the build process
must be tested on different distros, toggling the options to test the results, etc. That
is one reason we don't delete the automake files because they serve as a long-term
reference for the cmake ports.
Although the existing cmake ports are in good shape, not every single build option was
ported. Mostly this is a result that the people porting the builds did not have access to
those options. Thus we notice an occasional missing build option. Browse the bug tracker
to notice where we have tagged some of those absences (for example, amarok). Thus in the
example of the comment for kviewshell(plugins/djvu), a reasonable plan is to investigate
the original automake build options. If the option was supported in automake but was not
ported to cmake, then a bug report would be appropriate. If the option never was supported
in automake, perhaps a bug report might still be in order to provide that support. :)
Side comments: even if you are using 3.5.13.1, notice that in the R14 development branch
that there has been significant package and app renaming. Thus kdegraphics is now
tdegraphics. Therefore some comments might seem appropriate in 3.5.13.1 but will not apply
in R14. Hence the continuing review of these changes. Eventually I'll push them to
GIT. Slavek will decide whether to backport the changes to 3.5.13.1 but often with these
types of changes he has to cherry pick, which is more work than just backporting the whole
patch. :)
Darrell