On Thursday 16 February 2012 20:27:19 Serghei Amelian wrote:
I think the patch is a mess, because qtcreator made automatically some cleanup in source file. Howewer, upower code is embraced between "#ifdef WITH_UPOWER" directives.
Also I wonder whether the patch affects all KDE places where one can shutdown the computer or only the shutdown dialog. I.e. whether it would work for hibernating from a menu such as kickoff.
Right now is implemented only on ksmserver. Calvin propose to make a dcop interface to it, and in this case will be accesibile everywhere.
Currently kickoff detects well if kpowersave is running. I thought you patched kpowersave to work through upower instead of hal. Would not it be a better solution?
Previously it used its own daemon, then it was ported to hal, why not to port it to upower? Hybernate/suspend dialog circumventing kpowersave is not good I think.