Dne út 28. května 2013 Serghei Amelian napsal(a):
On Tuesday 28 May 2013 18:02:21 Slávek Banko wrote:
Dne pá 3. května 2013 Serghei Amelian napsal(a):
I was going to commit the patch into git, but comment:
// FIXME (Serghei): i'm not sure about role of "relay"
seems to be very important. I looked into the ambient code.
relayEnabled is switched by decodeContent, hence, depending on the
"DECODE" in the URL. I see a potential problem remove handling
'relay' from
parseReadLine, while in other code is apparently somehow used.
Therefore I believe that the patch needs further research and
testing. For this reason, now I do not expect inclusion into
3.5.13.2.
Any comments or objections?
Slavek
I agree that this patch needs more investigations, for this reason I
wrote the FIXME comment. However, without it the kio_imap4 is
completely unusable on 64 bit systems (it enter to endless loop). So
far I did not noticed any problem related to "relay".
I use kmail with IMAP4 on 64bit system for a long time and I did not
notice endless loops before using your patch, even then.
Several problems was fixed by François in earlier patches:
+ 786fea2 Fix another endless loop in imapparser (Bug 1235)
+ 590161f Fix more SEGV in imapparser (Bug 1235)
+ 9b43d6e Fix segfault in IMAP folder parsing
+ b0c92b3 Fix long response time on large IMAP folders (Bug 1009)
+ aa2af25 Fix IMAP hang on auth failure (Bug 1007)
Slavek