20 Nov
2011
20 Nov
'11
4:52 a.m.
I believe the bug is here. There is a length limit
that troubles
konqueror: if a line contains more than 301 bytes, the file is wrongly
identified.
kdelibs/kio/kio/kmimemagic.cpp:2O10:
/* Now, look whether the file consists of lines of
* "reasonable" length. */
for (i = 0; i < nbytes;) {
cp = (unsigned char *) memchr(buf, '\n', nbytes - i);
if (cp == NULL) {
/* Don't fail if we hit the end of buffer. */
if (i + TEXT_MAXLINELEN >= nbytes)
break;
else
return 0;
}
if (cp - buf > TEXT_MAXLINELEN)
return 0;
i += (cp - buf + 1);
buf = cp + 1;
}
An here is THE BUG:
kdelibs/kio/kio/kmimemagic.cpp:1992:
#define TEXT_MAXLINELEN 300
Now, what's the solution? Is it good to define a maximum length?
Which one?
--
Laurent Dard