On Sun February 3 2019 03:55:00 Slávek Banko wrote:
Hello to all programmers,
please give your attention and share your opinion to the proposed patch for TQt3. For a detailed description of the problem, see the pull-request:
https://mirror.git.trinitydesktop.org/gitea/TDE/tqt3/pulls/6
Hi Slavek,
Sorry I don't have time to fully understand this code. All the levels of nested classes and shallow copying made my head spin but I don't see any obvious problems there. So just a couple of quick thoughts:
(1) I see a mutex and a lot of code that is not - at least to me - obviously thread safe.
(2) Having the cstring in the TQStringData but the assignments to ctring in the TQString methods seems awkward but may be the best solution available.
--Mike