-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On Thursday 06 of November 2014 00:37:19 Slávek Banko wrote:
On Monday 06 of October 2014 06:10:18 Timothy Pearson wrote:
Slavek, all,
When building TDE on Debian Jessie I have run into several instances where tdebase FTBFS due to the recent changes in CMake policy CMP0046. Setting the OLD behavior repairs the problem.
Are there any drawbacks to setting CMP0046 OLD globally? If not can
one
of the CMake gurus here please push a proper patch to the cmake module ASAP?
Thanks!
Tim
I watched the all builds if it will occur yet another case CMP0046. I noticed only one - in Konversation. The patch is a single line. Push or wait?
index 5e48cd1..49c5ef1 100644 --- a/konversation/src/linkaddressbook/CMakeLists.txt +++ b/konversation/src/linkaddressbook/CMakeLists.txt @@ -33,6 +33,6 @@ tde_add_library( linkaddressbookui STATIC_PIC AUTOMOC addressbook.cpp nicklisttooltip.cpp nicksonlinetooltip.cpp kimiface.skel addresseeitem.cpp
- DEPENDENCIES konversationconfig
- DEPENDENCIES konversationconfig-static
)
I almost forgot. The patch above solves CMP0046. However, with Konversation occurs even CMP0037. Specifically, due to the localization sr@Latn. This name is used as the name of the target. But, contains invalid characters.
The fix for CMP0037 will not be easy, because the localization files / folders are processed automatically by macro in common cmake module. Therefore, I propose to wait with fix CPM0037 until R14.0.0 will be out of the doors.
What is your opinion?
Yes, please wait on the CPM0037 fix. Push the CMP0046 fix now.
Thanks!
Tim