31 Dec
2014
31 Dec
'14
2:59 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 12/31/2014 06:51 AM, Timothy Pearson wrote:
All,
This is a follow-up on point #5 from my post earlier this month entitled "TDE GIT
thaw, build farm status, and
future direction".
Hi Tim, code reformatting is definitely something we have to do. I meant to come back with
some style ideas/rules last
week but other things got into the way. Can you give me a few more days (say until Monday)
to come back with my thought?
In the mean time, I think it would be useful if you share a small piece of code showing
the code formatting that you
are thinking about.
Since the code reformatting is a "one time op", we should make sure we are all
happy with the code style we choose.
Obviously this will require some compromise from each of us, since every one has its own
preferences about style.
Cheers
Michele
Codebase formatting. While this is not a major
problem for the users I have been tripped up more than once by
the fact that some portions of the codebase (twin among others) use a vastly different
style of indentation and
bracing, one that is (IMHO) extremely hard to read and/or modify. This in turn has
therefore contributed to many
"fix up prior commit" commits and/or outright regressions in GIT. I greatly
prefer Stroustrup style formatting
with hard tab indentation (no space or combined space/tab indents) and indented
public/protected/private blocks.
This style is highly legible, emphasizes the control flow, and produces a minimal number
of non-whitespace
difference lines when an if/else block is modified. All of the new code (thousands and
thousands of lines of
it) that I have contributed to TDE have been in this style. I have been toying with
reformatting the entire TDE
codebase in one large commit; if there are no objections I think this step could greatly
improve both our
development speed and the overall quality of the codebase; comments and discussion are
welcome.
I would like to start converting over the codebase ASAP. I have an automated tool that
will do this, but would
like some feedback on the style to convert into as reformatting like this is a one-time
operation that will not be
repeated for the life of the TDE project.
As mentioned above I strongly prefer a modified Stroustrup style formatting. Is this
acceptable to the other
developers, and if not, what would you rather use and why?
Thanks!
Tim
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJUo2aoAAoJECp1t8qK3tXPNwMP/2tN4U3mdU2iF7QHNGZs+49T
CTU/Tjy+zGMtNwrqXARn6ihp0BRgPSb1vLqPX6u0sXIveJy+YOJMMJ6+n0G5cO5A
ytXsFWf/plBRGWPllYA3dnpPvgjuoimmxY3nVBqzUAknrVuZZwDDFujdj7Kmz4rt
xn53rFuRgZM4aDnSHVnvVv/yRBzYgMwoTVaRNmpHPosgKnEvWfco5PTQMluPTgoY
RyuZJeJZM2KFUxm8QFkTjhgi00hUcbpSnZMWZeRDkydpsX1UsmccYvViqMi6fJvS
+cMAVw7VWODy8Bj8pLId3/cNFYqfpMIYwDunh0IN3et5Y60vlR+vpPwX2eIrros7
0LY6vFGo1GD7ibBjCJjqRhicOi0SAiZ3mk1ohpElmGiwlzRsNVwVMPN0nvObPWnx
9QUsNOgkuURZVxvK6nPcElTzZQDRPueIqJG6af/0BYVBGzTEH9ZfXtB7E7iuy45R
K1A13EATGK45ngmFU44668FaqKMlfqLiT5OvlAkdV13AlEE4ZDyU+NsRI5VQIcKg
uClPQKKQz2M8ValCu7iIv0Am+ijjXnykuVWwDdleO+7GuEkWmI90m3JIfBUruFuV
eBI0qLdSZo4Augys31L5Le2Iaytxtf/CZLR64GiO8Ss/KHIWI4mm+IRjApP/I1TB
Z5INJBkhskR8LvZf7X8t
=UT/A
-----END PGP SIGNATURE-----