13 Feb
2012
13 Feb
'12
6:52 p.m.
On Monday 13 February 2012 23:25:13 Timothy Pearson wrote:
This is completely useless and broken patch because all the same functionality already
existed in KDE3 (i.e. the shadows).
And the newly introduced shadows have less functionality than those existed originally
(i.e. they are not displayed when moving a window).
I suspect this patch was introduced before the final KDE 3.5.10 was released, when KDE
still had no shadow function in kwin.
The second
commit I pointed out was 9cc1e2c1: I think others already
commented
in my blog comments why this one is rather bad from a users point of view
(introducing new config options without removing the obsoleted ones). But
well
the main issue from my point of view is that it modified an enum in a
public
header by not appending to the end, but in the middle. I think you can
imagine
what happens to 3rd party offerings compiled against the previous version.
We are not too concerned about ABI compatibility here, but since the
requested change is so trivial I suppose I can push it through.