22 Aug
2014
22 Aug
'14
12:21 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224
Given how trivial the patches are I'd say merge anyway; there's nothing
more complex than an ifdef added to the actual code and the build system
is tested every time the binaries are rebuilt on the nightly builds PPA.
Tim
Overall good
work! The main thing I want to see at this point is
autodetection of BSD so that we don't have to manually apply the first
patch for all the others to work.
All,
not to take anything away from the good work done by Francois (thanks!!),
but I would like to propose we merge all the changes required for building
on BSD to the origin/master branch *after* the release of v14.0.0 or at
least after a separate branch for v14.0.0 has been created. The reason for
this proposal is to avoid to potentially introduce new bugs so close to
the finalization of v14.0.0 (don't forget that we are in a soft-freeze
state).
Opinions are welcomed of course.
Cheers
Michele -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iFYEARELAAYFAlP2jREACgkQLaxZSoRZrGESngDfXM94fGdMfbYbQbr4yNmUEmpJ
TDHTJJRZi0yRhwDfRb96aICesdzm56874YrSHemp4jbg7wpSPnOk6Q==
=cWNE
-----END PGP SIGNATURE-----