13 Apr
2012
13 Apr
'12
9 p.m.
On 04/13/2012 03:49 PM, Darrell Anderson wrote:
This one of those "anal" C++ patches, right?
That is, the patch will not cause problems with gcc < 4.7?
I will test here with gcc 4.4.4. My challenge is I don't have a clue how to test
rosegarden for usability possible breakage.
Darrell
100% anal C++ issues. If you look, the largest part is just changing
'i'->'j' or
adding the class reference (eg: 'GenericChord::') in front of the various
members so gcc47 will quit complaining. With the pickiness of gcc47, it makes
you wonder "how the hell did this stuff even run before?" I guess it always
knew
which 'i' it was supposed to use, but now gcc makes you tell it explicitly.
Absolutely 'zarro' substantive change to the code. Where loops used to run:
for(this::i=x;i<something;i++) {
for(i=y;i<something_else;i++) {
stuff
}
}
The patched loops run like:
for(this::i=x;i<something;i++) {
for(j=y;j<something_else;j++) {
stuff
}
}
The other changes were just to #include <unistd.h> where needed... Should be
good to push.
--
David C. Rankin, J.D.,P.E.