1 Jun
2020
1 Jun
'20
5:15 p.m.
On Sunday 31 of May 2020 10:54:21 Slávek Banko wrote:
On Saturday 30 of May 2020 20:34:07 deloptes wrote:
Emanoil,
Please, did you test PR for Amarok?
Is the problem solved - is it possible to merge?
Cheers
--
Slávek
Slávek Banko wrote:
Oh - for magnatunebrowser there was no direct include for
amarokconfig.h, but it was indirectly using playlist.h - that's why I
overlooked it during my review. Thank you for finding and solving!
Since I already had a branch ready for the first part, I added your
second part and pushed it. At the same time I added Signed-off-by for
you too. You can verify it in TDE/amarok#17 - see:
https://mirror.git.trinitydesktop.org/gitea/TDE/amarok/pulls/17
Cheers DEPENDENCIES
amarokcore-static
Thank you Slavek!
It was close enough to fix it - perhaps magnatunebrowser is build
first. Should I create a PR?
$ git diff
diff --git a/amarok/src/magnatunebrowser/CMakeLists.txt
b/amarok/src/magnatunebrowser/CMakeLists.txt
index 6ed7fe3..9345696 100644
--- a/amarok/src/magnatunebrowser/CMakeLists.txt
+++ b/amarok/src/magnatunebrowser/CMakeLists.txt
@@ -33,4 +33,5 @@ tde_add_library( magnatunebrowser STATIC_PIC AUTOMOC
magnatunelistview.cpp magnatuneredownloaddialog.cpp
magnatuneredownloadhandler.cpp magnatunedownloadinfo.cpp
magnatunealbumdownloader.cpp magnatuneredownloaddialogbase.ui
+ DEPENDENCIES amarokcore-static
)