On Monday 12 of August 2013 00:57:23 Timothy Pearson wrote:
On Sunday 11 of August 2013 23:11:40 François Andriot wrote:
Le 11/08/2013 21:11, Slávek Banko a écrit :
Hello,
A few days ago I sent a proposal to add a HAL backend for power management. Meanwhile, I fixed call Suspend and added support for governor (not tested).
I also noticed that setting the brightness and governor is in
condition
WITH_UPOWER, although in fact uses Trinity DBus daemon => has nothing
to
do with upower. I added to the option WITH_TDEHWLIB_DAEMONS and fixed incorrect WITH_UPOWER conditions.
Please test it. At the same time I'm waiting for your opinions - incorporate it or not?
Thanks Slavek
Hello, this patch is good news :-) I suggest that HAL support is disabled by default (OFF) instead of WITH_ALL_OPTIONS.
Appart from that, I have troubles building tdelibs R14 on CentOS 5, because UDEV is too old (095). I've also noticed that I can NOT build tdelibs without tdehwlib at all (no configuration option) ... That means, in the current state, CentOS 5 will be limited to TDE 3.5.13-SRU branch...
Francois
The advantage of this patch is that it does not add any specific dependence due to HAL. Only adds a few dbus calls. So there is no problem when it is hal enabled, but not installed.
Problems with the old version of udev can be solved?
Slavek
I am in agreement that the HAL support should default to OFF. DBUS calls are slow enough as it is; we don't need calls to extraneous services slowing things down even more. :-)
Tim
Yes, I understand. However, as can be seen in the code, this dbus call will not add absolutely no overhead if present upower, respectively tdehwlib daemon. Dbus calls to hal are just as fall-back.
Slavek --