On Tuesday 14 of May 2013 22:24:03 François Andriot wrote:
Le 14/05/2013 20:40, Slávek Banko a écrit :
On Tuesday 14 of May 2013 19:36:43 François Andriot wrote:
Hello Slavek, are you ready now to release the final tarballs for 3.5.13.2 ? The 4 bugs you listed are now fixed. The "less important" issues you mentioned are only build issue, so they won't change the tarballs anyway, only the debian/ubuntu specific stuff ... I'm using 3.5.13.2 now and I can't see any bug that was annoying me in 3.5.13.1 ... Francois
I'm trying to process your patches from bug 1499. If you want these patches defer to R14, I will not delay release 3.5.13.2 due to these patches.
Hello, my first intention for the Mandriva patches was to eventually push them all to R14, not 3.5.13.2. That was because I had thought about new features, which IMO better suit a new major TDE version rather than an SRU release. Also, new features need some discussions and testing before going upstream. But, there were also patches that provide bugfixes. These ones can apply to an SRU release.
I'm currently using 3.5.13.2 + all these patches, and I have no problem (no crash, no obvious regression). But some of them need more polishing and more testing.
The patches that I'd prefer NOT see in 3.5.13.2, are:
(1233) tdebase 3.5.13.2 : fix "safely remove device" command (pardus) I have no idea if this patch is good or not. I have no problem with or without it.
(1238) tdebase 3.5.13.2 : add option to choose WM Setting may not be at the best place in kcontrol. Not enough tested. Maybe too Mandriva specific (are .desktop files correct for other distros ?). BUT the idea of this patch is interesting, I think it would be the first step to integrate KWIN4 into TDE's installation.
(1247) tdebase 3.5.13.2 : add theme selector in kcontrol / kdm Not enough tested. Not even sure JDM themes are really applied (I've only validated that kdmrc file is correctly updated).
(1250) tdebase 3.5.13.2 : add scheduled slide show support Does not work currently. Not very useful anyway.
(1251) tdebase 3.5.13.2 : add UTF8 support in KDM password dialog box (pardus) I do not know the original problem (password typing issue ?) Maybe it was already solved in another way (e.g in QT3 or kdelibs ?) I think the login feature is too sensitive, we should avoid any regression risk !
Summary for other patches:
- HAL-related stuff works correctly, and are limited to SRU => won't
pollute R14.
- Kpowersave related stuff work without updating kpowersave. Strangely,
some inactive code is already present in TDE's kpowersave, but the tdebase counterpart was missing (attachement 1241). => can be pushed in SRU
- XDG directories stuff: are used to enhance the Kickoff menu. Could be
associated to bug #1291. This could also lead to konqueror/dolphin enhancements.
- vibrate dialog / crossfading background: I will add kcontrol options
to enable/disable these effects (to avoid unhappy end-users). So the 2 patches will be slightly updated, but you can still try them now, to confirm the feature works or not.
I incorporate patches that seemed to be very useful for 3.5.13.x series. Patches that made major changes or require more extensive testing I leave for R14. It's so satisfactory?
In any case, I'll test your patch from the bug report 1506. In addition, I'll commit patch proposed in the mail http://trinity-devel.pearsoncomputing.net/?0::11061
I'm still not really satisfied with this patch. I consider it as a temporary workaround for SRU until a better solution is found in R14.
- The displayconfig should check for gamma support at startup, then
gray out gamma options in GUI if they are not usable, then avoid showing a warning popup everytime we save settings. 2) In the 3.5.13.2 source code we can see that using the "xrandr" command in tdelibs is a temporary solution (there is an hardcoded #define then #ifdef ... ) so the xrandr related part will not bother me eternally.
I am ready to push patch. Meanwhile I wait to see if anyone else had enough time for the proposed solution...
For your patch 1252: update default favs from the bug report 1291, I would first like to discuss here.
About the default favs for Kickoff, I think we should first define a distribution independant set of packages, that would be used as the default Trinity installation for everyone. Then we can choose the Kickoff favs among these programs. BTW there is a possible issue with defining non-TDE programs in favs, like firefox: the "firefox.desktop" file name may differ between distributions. So we should avoid using any non-TDE programs in favs.
I agree that by default favorites should refer only to programs from Trinity. However, prior to the modifications I'd prefer discussion with users. So far (for 3.5.13.2) I would suggest to keep the file unchanged.
At present, there I solve merge two patches to kdebase => due kdesktop_lock. I hope I test it and possibly commit soon. Besides, do I have to update Debian / Ubuntu metapackages.
Slavek
OK, so I should take no more than few days to finish 3.5.13.2 .
I'd really like to get it out soon.
Francois
Patches that I considered were associated with kdesktoplockcontrol, so currently not significant.
Currently I am working on updating metapackages for 3.5.13.x branch. If in the meantime will be no complications, we can then tag 3.5.13.2 version in GIT, build final packages and proceed to the release.
Slavek --