13 Feb
2012
13 Feb
'12
4:59 p.m.
On Monday 13 February 2012 14:51:40 Aaron J. Seigo wrote:
a) TDE has taken code many of us worked on for years
and is taking it in the
direction TDE sees fit. Not normally a problem, but in this case TDE often does
a less than spectacular job of it. Diminishing someone else's work and doing
the long-term users of it a disservice is not great, is it? Yeah, it annoys me
when people use my software, which they still refer to as "kicker", with
someone else's changes to it which actually make it less stable rather than
more, something I worked years on to achieve
Are you sure?
This is http://websvn.kde.org/?view=revision&revision=406411 your commit after which
the buttons on the taskbar in KDE 3.4 ceased to be visually pushed, when using the Classic
mode.
The key line in file kicker/taskbar/taskcontainer.cpp before:
Code: Select all
style().drawPrimitive(QStyle::PE_HeaderSection, p, QRect(0, 0, width(), height()),
colors, sunken ? QStyle::Style_Down : QStyle::Style_Raised);
after:
Code: Select all
style().drawPrimitive(QStyle::PE_HeaderSection, p, QRect(0, 0, width(), height()),
colors)
After reverting this change and restoring the removed parameter to the function the
taskbar works well again.
I also have KDE2's installed on my system and I find it both more stable and visually
appealing than that of KDE3.
For instance one of the changes in KDE3 was using table caption widgets for the taskbar
instead of the provided
with Qt special widgets for the taskbar. The KDE3's kicker is more simply looking, has
no visual zooming when hovering
over quick launch items, and the buttons (including K-button) do not respect the Qt style.
It also has a serious bug with
K-menu positioning with some icon and Qt themes.
Is that all improvement over KDE2? As I know you did not work on the KDE2's kicker.