On 05/04/2012 04:00 PM, David C. Rankin wrote:
On 05/04/2012 02:41 PM, /dev/ammo42 wrote:
(iCCP_data)ICCColorProfile.data() is better replaced by static_cast<iCCP_data>(ICCColorProfile.data()) . This also applies to the digikam patch.
OK,
How about this one:
the i686 build does not like the second patch...
libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I../../kipi-plugins/common/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h -I/opt/trinity/include/tde -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=i686 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT rawdecodingiface.lo -MD -MP -MF .deps/rawdecodingiface.Tpo -c rawdecodingiface.cpp -fPIC -DPIC -o .libs/rawdecodingiface.o rawdecodingiface.cpp: In member function 'bool KIPIRawConverterPlugin::RawDecodingIface::loadedFromDcraw(const TQString&, TQString&, KIPIRawConverterPlugin::SaveSettingsWidget::OutputFormat, const TQByteArray&, int, int)': rawdecodingiface.cpp:309:75: error: invalid static_cast from type 'char*' to type 'KIPIRawConverterPlugin::iCCP_data {aka unsigned char*}' rawdecodingiface.cpp:320:25: warning: deprecated conversion from string constant to 'png_charp {aka char*}' [-Wwrite-strings]
?? Did I not get your suggestion right??