On 02/26/2014 11:38 AM, Slávek Banko wrote:
As I noted in the bug report: This is not a problem. Presence code for ConsoleKit has no effect unless ConsoleKit present on system. With the ConsoleKit communicates via D-Bus. If ConsoleKit not present, not with whom to communicate => code has no effect == same as it was not used.
The freedesktop.org documents say you MUST REMOVE ALL REFERENCES TO CONSOLEKIT in order for systemd logind session tracking to work properly. I see your point, that if it has no effect --> it has no effect. My concern is that leaving "#define WITH_CONSOLE_KIT" hardcoded may be biting us.
How hard is it to do a:
#ifdef HAVE_CONSOLE_KIT #define WITH_CONSOLE_KIT #endif
I also need a
#ifdef HAVE_SYSTEMD #define WITH_SYSTEMD #endif
Will including the check in ConfigureChecks.cmake accomplish this?
if( BUILD_TDM ) pkg_search_module( SYSTEMD systemd ) if( NOT SYSTEMD_FOUND ) message( STATUS "***** systemd NOT found on your system *****" ) else( ) message( STATUS "***** systemd FOUND on your system *****" ) set ( HAVE_SYSTEMD 1) endif( ) endif( )
Will this work? Will HAVE_SYSTEMD be seen in dm.h (or any other header) so it can be used as a preprocessor check?