8 Jan
2014
8 Jan
'14
1:01 a.m.
On Tuesday 07 of January 2014 05:03:18 Darrell Anderson wrote:
Great, thank you, good job. However, I have prepared two adjustments - first
large, second small.
1) Names of java classes are derived from the domain name. I watched that
tde.org domain is owned by The Duke Endowment. Although it seems that this
domain is not used, I think it would be appropriate instead of org.tde.* use
our domain - org.trinitydesktop.* What is your opinion?
I modified the patch to this effect.
2) In the patch was typo - slash before 'org' was sometimes doubled.
Fixed.
An updated patch is available in my 'rsync' resource tde-patches-verify.
I tried to build and was successful.
Slavek
--
Wow, many times
I thought that it might be proper to rename some
parts in
tdebindings - such as in java org.kde. => org.trinitydesktop. Glad
to
hear that you decided to do it! We can find another way to pass
the
patch, to I could see patch before will be pushed to git?
Here is the patch (not archived or compressed):
http://humanreadable.nfshost.com/misc/tdebindings-kde-tde-
rename.diff
The patch is about 38 MB.
Feel free to improve any way you want.
Please test. Push to git when you are content.
Darrell