Re: Re: Re: Re: git modules and cmake/admin submodules

Michele Calgaro via trinity-devel wrote:

ok, in that case you probably need to make changes to the cmake files in kplayer, not to the common module. So those chagnes would go in the same PR as kplayer. Not sure I had misunderstood your original statement "I made changes to cmake" :-) Cheers Michele

Hi Michele, I changed the CMakeLists.txt to include FindLibDvd. I was thinking that FindLibDvd can be added somehow to kplayers cmake modules.