Recently I reported that tdegraphics failed to build against TQt3 but built without error against Qt3.
I patched tdegraphics and now can build tdegraphics against both.
Although the patch works I'm uncomfortable pushing to GIT without peer review. I would appreciate somebody else reviewing and committing the patch.
Here is the patch:
======================================================= diff -urN tdesdk/cervisia/qttableview.cpp tdesdk.new/cervisia/qttableview.cpp --- tdesdk/cervisia/qttableview.cpp 2011-12-25 01:15:21.000000000 -0600 +++ tdesdk.new/cervisia/qttableview.cpp 2012-02-20 22:27:57.000000000 -0600 @@ -1073,7 +1073,7 @@ coveringCornerSquare = enable; if ( !cornerSquare && enable ) { cornerSquare = new TQCornerSquare( this ); - Q_CHECK_PTR( cornerSquare ); + TQ_CHECK_PTR( cornerSquare ); cornerSquare->setGeometry( maxViewX() + frameWidth() + 1, maxViewY() + frameWidth() + 1, VSBEXT, @@ -1448,7 +1448,7 @@ sb->setCursor( arrowCursor ); #endif sb->resize( sb->sizeHint() ); // height is irrelevant - Q_CHECK_PTR(sb); + TQ_CHECK_PTR(sb); sb->setTracking( FALSE ); sb->setFocusPolicy( TQ_NoFocus ); connect( sb, TQT_SIGNAL(valueChanged(int)), @@ -1480,7 +1480,7 @@ #endif sb->resize( sb->sizeHint() ); // width is irrelevant sb->setFocusPolicy( TQ_NoFocus ); - Q_CHECK_PTR(sb); + TQ_CHECK_PTR(sb); sb->setTracking( FALSE ); connect( sb, TQT_SIGNAL(valueChanged(int)), TQT_SLOT(horSbValue(int))); =======================================================
Thanks.
Darrell
As any person will discern by reading, I failed to proof read my post. The patch is for tdesdk.
The patch does not resolve the previous tdesdk cmake problem I reported when building against TQt3.
Darrell
Recently I reported that tdegraphics failed to build against TQt3 but built without error against Qt3.
I patched tdegraphics and now can build tdegraphics against both.
Although the patch works I'm uncomfortable pushing to GIT without peer review. I would appreciate somebody else reviewing and committing the patch.
Here is the patch:
======================================================= diff -urN tdesdk/cervisia/qttableview.cpp tdesdk.new/cervisia/qttableview.cpp --- tdesdk/cervisia/qttableview.cpp 2011-12-25 01:15:21.000000000 -0600 +++ tdesdk.new/cervisia/qttableview.cpp 2012-02-20 22:27:57.000000000 -0600 @@ -1073,7 +1073,7 @@ coveringCornerSquare = enable; if ( !cornerSquare && enable ) { cornerSquare = new TQCornerSquare( this );
- Q_CHECK_PTR( cornerSquare );
- TQ_CHECK_PTR( cornerSquare ); cornerSquare->setGeometry( maxViewX() + frameWidth() + 1, maxViewY() + frameWidth() + 1, VSBEXT,
@@ -1448,7 +1448,7 @@ sb->setCursor( arrowCursor ); #endif sb->resize( sb->sizeHint() ); // height is irrelevant
- Q_CHECK_PTR(sb);
- TQ_CHECK_PTR(sb); sb->setTracking( FALSE ); sb->setFocusPolicy( TQ_NoFocus ); connect( sb, TQT_SIGNAL(valueChanged(int)),
@@ -1480,7 +1480,7 @@ #endif sb->resize( sb->sizeHint() ); // width is irrelevant sb->setFocusPolicy( TQ_NoFocus );
- Q_CHECK_PTR(sb);
- TQ_CHECK_PTR(sb); sb->setTracking( FALSE ); connect( sb, TQT_SIGNAL(valueChanged(int)), TQT_SLOT(horSbValue(int)));
=======================================================
Thanks.
Darrell
Hi Darrell,
I am still trying to rebuild TDE myself, fixing build failures as I go. :-)
In this case, this was fixed yesterday in GIT hash 19c822c4, so I can state that your proposed fix was correct.
Tim
I am still trying to rebuild TDE myself, fixing build failures as I go. :-)
In this case, this was fixed yesterday in GIT hash 19c822c4, so I can state that your proposed fix was correct.
Thanks! :)
That leaves the following recent failures:
tdesdk kuiviewer fails against TQt3 but builds okay against Qt3 tdeadmin (fails against TQt3 but builds okay against Qt3; knetworkconfdlg.h:142: error: 'TQListViewItem' has not been declared) tdebindings (fails with TQt3 and Qt3 but I see some patches in the commits)
Darrell