Would somebody please confirm that the icons used in k9copy are unreadable?
You do not have to have k9copy installed. Use your local GIT sources and try to view the icons:
applications/k9copy/tree/src/icons
I am unable to view the icons.
In the installed version of k9copy, the icons in the Settings menu are blank, which is how I discovered the problem.
I can view all of the icons from the original 1.2.4 sources.
I think somehow the images in the GIT tree have become corrupted. Comparing file sizes between the two source sets shows the files are not the same size.
Fixing the problem is as easy as copying the images from the original sources. I have tested by rebuilding k9copy with the original image files and the Settings images were fine.
I just want confirmation before pushing anything to GIT.
Thanks!
Darrell
On 8 Jun 2012, Darrell Anderson verbalised:
Would somebody please confirm that the icons used in k9copy are unreadable?
Yes, they are unreadable.
I think somehow the images in the GIT tree have become corrupted. Comparing file sizes between the two source sets shows the files are not the same size.
They're one byte longer than in upstream k9copy. I haven't investigated but I bet this is a mistaken LF -> CR/LF conversion somewhere down the line (maybe as simple as ASCII-mode FTP, if anyone uses *that* anymore).
I just want confirmation before pushing anything to GIT.
Confirmed.
They're one byte longer than in upstream k9copy. I haven't investigated but I bet this is a mistaken LF -> CR/LF conversion somewhere down the line (maybe as simple as ASCII-mode FTP, if anyone uses *that* anymore).
I recall after comparing two sets of files I noticed a one byte difference, but did not compare all of them. Your explanation makes sense. :-)
I just want confirmation before pushing anything to GIT.
Confirmed.
Thanks much. I'll push the changes to GIT.
Darrell
On 06/08/2012 03:16 PM, Nix wrote:
On 8 Jun 2012, Darrell Anderson verbalised:
Would somebody please confirm that the icons used in k9copy are unreadable?
Yes, they are unreadable.
I think somehow the images in the GIT tree have become corrupted. Comparing file sizes between the two source sets shows the files are not the same size.
They're one byte longer than in upstream k9copy. I haven't investigated but I bet this is a mistaken LF -> CR/LF conversion somewhere down the line (maybe as simple as ASCII-mode FTP, if anyone uses *that* anymore).
I just want confirmation before pushing anything to GIT.
Confirmed.
Double confirmed -- the k9copy icons are FUBAR. Just drop the set from upstream in.
-
Darrell Anderson -
David C. Rankin -
Nix