What is the status of the patch in bug report 902?
I tried the patch with the latest GIT and gcc 4.7. The build still fails with the same error:
collect2: error: ld returned 1 exit status /usr/lib/gcc/i486-slackware-linux/4.7.0/../../../../i486-slackware-linux/bin/ld: CMakeFiles/ksnapshot.dir/windowgrabber.cpp.o: undefined reference to symbol 'XShapeQueryExtension'
Darrell
What is the status of the patch in bug report 902?
I tried the patch with the latest GIT and gcc 4.7. The build still fails with the same error:
collect2: error: ld returned 1 exit status /usr/lib/gcc/i486-slackware-linux/4.7.0/../../../../i486-slackware-linux/bin/ld: CMakeFiles/ksnapshot.dir/windowgrabber.cpp.o: undefined reference to symbol 'XShapeQueryExtension'
The patch looks like this:
================================================= --- tdegraphics/ksnapshot/CMakeLists.txt +++ tdegraphics/ksnapshot/CMakeLists.txt 2012-03-09 09:18:44.692136349 -0600 @@ -36,10 +36,20 @@
##### ksnapshot (executable) ####################
+## test for and explicitly include libXext +if( WITH_XEXT ) + pkg_search_module( XEXT xext ) + if( NOT XEXT_FOUND ) + tde_message_fatal( "You requested Xext support, but is was not found on +your system (or devel package is not installed" ) + endif( ) + check_include_file( "X11/extensions/shape.h" HAVE_X11_EXTENSIONS_SHAPE_H ) +endif( ) + tde_add_executable( ksnapshot AUTOMOC SOURCES ksnapshotiface.skel main.cpp ksnapshot.cpp regiongrabber.cpp windowgrabber.cpp ksnapshotwidget.ui - LINK tdeprint-shared + LINK tdeprint-shared ${XEXT_LIBRARIES} DESTINATION ${BIN_INSTALL_DIR} ) =================================================
The internal cmake variable XEXT_LIBRARIES is not being generated. How do we make that happen?
Darrell
What is the status of the patch in bug report 902?
I tried the patch with the latest GIT and gcc 4.7. The build still fails with the same error:
collect2: error: ld returned 1 exit status
/usr/lib/gcc/i486-slackware-linux/4.7.0/../../../../i486-slackware-linux/bin/ld:
CMakeFiles/ksnapshot.dir/windowgrabber.cpp.o: undefined reference to symbol 'XShapeQueryExtension'
The patch looks like this:
================================================= --- tdegraphics/ksnapshot/CMakeLists.txt +++ tdegraphics/ksnapshot/CMakeLists.txt 2012-03-09 09:18:44.692136349 -0600 @@ -36,10 +36,20 @@
##### ksnapshot (executable) ####################
+## test for and explicitly include libXext +if( WITH_XEXT )
- pkg_search_module( XEXT xext )
- if( NOT XEXT_FOUND )
- tde_message_fatal( "You requested Xext
support, but is was not found on +your system (or devel package is not installed" )
- endif( )
- check_include_file( "X11/extensions/shape.h"
HAVE_X11_EXTENSIONS_SHAPE_H ) +endif( )
tde_add_executable( ksnapshot AUTOMOC SOURCES ksnapshotiface.skel main.cpp ksnapshot.cpp regiongrabber.cpp windowgrabber.cpp ksnapshotwidget.ui
- LINK tdeprint-shared
- LINK tdeprint-shared ${XEXT_LIBRARIES} DESTINATION ${BIN_INSTALL_DIR}
)
The internal cmake variable XEXT_LIBRARIES is not being generated. How do we make that happen?
David, I posted an updated patch to bug report 902. I built tdegraphics without incident.
Please test! :-)
Darrell
On 04/27/2012 04:53 PM, Darrell Anderson wrote:
What is the status of the patch in bug report 902?
I tried the patch with the latest GIT and gcc 4.7. The build still fails with the same error:
collect2: error: ld returned 1 exit status /usr/lib/gcc/i486-slackware-linux/4.7.0/../../../../i486-slackware-linux/bin/ld: CMakeFiles/ksnapshot.dir/windowgrabber.cpp.o: undefined reference to symbol 'XShapeQueryExtension'
The patch looks like this:
================================================= --- tdegraphics/ksnapshot/CMakeLists.txt +++ tdegraphics/ksnapshot/CMakeLists.txt 2012-03-09 09:18:44.692136349 -0600 @@ -36,10 +36,20 @@
##### ksnapshot (executable) ####################
+## test for and explicitly include libXext +if( WITH_XEXT )
- pkg_search_module( XEXT xext )
- if( NOT XEXT_FOUND )
- tde_message_fatal( "You requested Xext support, but is was not found on
+your system (or devel package is not installed" )
- endif( )
- check_include_file( "X11/extensions/shape.h" HAVE_X11_EXTENSIONS_SHAPE_H )
+endif( )
tde_add_executable( ksnapshot AUTOMOC SOURCES ksnapshotiface.skel main.cpp ksnapshot.cpp regiongrabber.cpp windowgrabber.cpp ksnapshotwidget.ui
- LINK tdeprint-shared
- LINK tdeprint-shared ${XEXT_LIBRARIES} DESTINATION ${BIN_INSTALL_DIR}
)
The internal cmake variable XEXT_LIBRARIES is not being generated. How do we make that happen?
Darrell
Sorry Darrell, was out tonight.
I have used:
# fix libXext inclusion in linker string (gcc >=4.6.2) msg "fixing libXext inclusion in linker string (gcc >=4.6.2)" sed -i "/LINK/s|$| Xext|" tdegraphics/ksnapshot/CMakeLists.txt
I don't know why I thought that had already been pushed...
I have used:
# fix libXext inclusion in linker string (gcc >=4.6.2) msg "fixing libXext inclusion in linker string (gcc=4.6.2)" sed -i "/LINK/s|$| Xext|" tdegraphics/ksnapshot/CMakeLists.txt
I don't know why I thought that had already been pushed...
I uploaded a slightly modified patch to GIT. Check your email for the bug report status. Unless you find a build problem we can close the bug report. No sed strings required. :-)
Darrell
On 04/28/2012 12:46 AM, Darrell Anderson wrote:
I uploaded a slightly modified patch to GIT. Check your email for the bug report status. Unless you find a build problem we can close the bug report. No sed strings required. :-)
Darrell
Thanks, I have got to redo the filter on the trinity bug emails. The go on a different server from the list and end up getting burried. I'll go give the patch a test and report back.
-
Darrell Anderson -
David C. Rankin