8 Aug
2012
8 Aug
'12
10:15 p.m.
Is anybody able to build tdebase without HAL (WITH_HAL=OFF)?
Darrell
5:16 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Le 11/08/2012 19:05, Darrell Anderson a écrit :
In file: tdm/backend/CMakeLists.txt
Look at section "include_directories" (line 14)
(notice the self-explanatory comment just above ...)
Inside this section, add another line just after ${DBUS_TQT_INCLUDE_DIRS}
${DBUS_INCLUDE_DIRS}
And try again ...
Francois
Is anybody
able to build tdebase without HAL (WITH_HAL=OFF)?
Anybody?
I'm dead in the water unless I can build without HAL. (Bug report 1132.)
Thanks.
Darrell
12 Aug
12 Aug
3:35 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Is anybody able to build tdebase without HAL
(WITH_HAL=OFF)?
In file: tdm/backend/CMakeLists.txt
Look at section "include_directories" (line 14)
(notice the self-explanatory comment just above ...)
Inside this section, add another line just after
${DBUS_TQT_INCLUDE_DIRS}
${DBUS_INCLUDE_DIRS}
And try again ...
Turns out this failure is more fundamental. After comparing builds with WITH_HAL=ON and
WITH_HAL=OFF, I noticed the latter build never looked for dbus-tqt and always failed.
I found success with the following temporary patch:
=================================================
diff -urN tdebase/ConfigureChecks.cmake tdebase.new/ConfigureChecks.cmake
--- tdebase/ConfigureChecks.cmake 2012-06-10 11:52:38.000000000 -0500
+++ tdebase.new/ConfigureChecks.cmake 2012-08-11 21:59:00.000000000 -0500
@@ -268,7 +268,7 @@
tde_message_fatal( "dbus-tqt-1 is required, but was not found on your
system" )
endif( )
endif( )
- if( WITH_HAL )
+# if( WITH_HAL )
# check for dbus-tqt
# dbus-tqt need Qt flags
pkg_check_modules( DBUS_TQT REQUIRED dbus-tqt )
@@ -284,6 +284,6 @@
if( NOT HAVE_DBUS_QT3_07 )
tde_message_fatal( "dbus-tqt is required, but was not found on your
system" )
endif( )
- endif( )
+# endif( )
endif( )
=================================================
I considered changing if( WITH_HAL ) to if( WITH_HAL OR WITH_TDEHWLIB ), but I don't
know whether WITH_TDEHWLIB is dependent upon dbus-tqt. I don't know whether dbus-tqt
is required for all builds.
I really don't know what is the best all-around long-term solution for all distros.
Darrell
Anybody?
I'm dead in the water unless I can build without HAL.
(Bug report 1132.)
3:58 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
On 08/11/2012 10:35 PM, Darrell Anderson wrote:
I really don't know what is the best all-around
long-term solution for all distros.
Darrell
C'mon, sure you do :) It is a tight, well optimized update to the TDE
codebase that provides all current HAL functionality with improved hardware
detection and handling that works on all distros and releases -- without needing
HAL. Problem solved!
Doing the 3.5.13 exercise had been a good exercise that has exposed some
needed updates to my build process. I've still got a bit to do, but I anticipate
by the end of next week to be able to jump back into R14. I sill need to finish
the k9copy patch for ffmpeg as well. So much to do, so little time...
--
David C. Rankin, J.D.,P.E.
8:39 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
On 08/11/2012 10:35 PM, Darrell Anderson wrote:
While it's not nearly as good as what you describe above, this is exactly
what TDE now has in reaction to the HAL problem. Try compiling tdebase
with the -DWITH_TDEHWLIB option and the -DWITH_HAL option both enabled and
see if that fixes the build problem. If so, then CMake needs to be
updated to handle this in a sane manner instead of having to enable two
contradictory options to successfully build without HAL support. ;-)
Tim
I really don't know what is the best
all-around long-term solution for
all distros.
Darrell
C'mon, sure you do :) It is a tight, well optimized update to the TDE
codebase that provides all current HAL functionality with improved
hardware
detection and handling that works on all distros and releases -- without
needing
HAL. Problem solved!
6:50 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
While it's not nearly as good as what you describe
above,
this is exactly what TDE now has in reaction to the HAL problem. Try
compiling tdebase with the -DWITH_TDEHWLIB option and the -DWITH_HAL option
both enabled and see if that fixes the build problem. If so, then CMake
needs to be updated to handle this in a sane manner instead of having to
enable two contradictory options to successfully build without HAL
support. ;-)
Building with -DWITH_TDEHWLIB and -DWITH_HAL won't resolve the build failures. The
tdebase top level ConfigureChecks.cmake file is hard-coded only to test for HAL. That is
why I mentioned I considered changing the cmake test from if( WITH_HAL ) to if( WITH_HAL
OR WITH_TDEHWLIB ).
I don't know whether the new TDEHWLIB scheme is dependent upon dbus-tqt. If yes then
the change in the cmake test would be valid. If the new TDEHWLIB scheme is not dependent
upon dbus-tqt, then deleting the if( WITH_HAL ) test as I did in my temporary patch would
seem a reasonable solution.
I don't know how all the parts connect, which is why I wrote I don't know the
correct long-term solution for all distros.
Darrell
10:05 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
While it's
not nearly as good as what you describe above,
this is exactly what TDE now has in reaction to the HAL problem. Try
compiling tdebase with the -DWITH_TDEHWLIB option and the -DWITH_HAL
option
both enabled and see if that fixes the build problem. If so, then CMake
needs to be updated to handle this in a sane manner instead of having to
enable two contradictory options to successfully build without HAL
support. ;-)
Building with -DWITH_TDEHWLIB and -DWITH_HAL won't resolve the build
failures. The tdebase top level ConfigureChecks.cmake file is hard-coded
only to test for HAL. That is why I mentioned I considered changing the
cmake test from if( WITH_HAL ) to if( WITH_HAL OR WITH_TDEHWLIB ).
I don't know whether the new TDEHWLIB scheme is dependent upon dbus-tqt.
10:41 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
While TDEHWLIB itself (i.e. the library code in
tdelibs) is
not, other previously HAL-dependent features in tdebase are still
dependent on dbus-tqt. Therefore, tdebase is dependent on dbus-tqt
even if the TDEHWLIB is in use.
Seems then that my temporary patch is best? Just delete the if( WITH_HAL ) test and build
with dbus-tqt support regardless of how WITH_HAL or WITH_TDEHWLIB are set?
Darrell
13 Aug
13 Aug
12:05 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
While TDEHWLIB
itself (i.e. the library code in tdelibs) is
not, other previously HAL-dependent features in tdebase are still
dependent on dbus-tqt. Therefore, tdebase is dependent on dbus-tqt
even if the TDEHWLIB is in use.
Seems then that my temporary patch is best? Just delete the if( WITH_HAL )
test and build with dbus-tqt support regardless of how WITH_HAL or
WITH_TDEHWLIB are set?
Darrell
3:02 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Seems then
that my temporary patch is best? Just delete
the if( WITH_HAL ) test and build with
dbus-tqt support regardless of how
WITH_HAL or WITH_TDEHWLIB are set?
I would check to see if either WITH_HAL or WITH_TDEHWLIB are
set before requiring dbus-tqt; if neither are set then tdebase does not
depend on it.
5:23 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Seems then that my temporary patch is best? Just
delete
the if( WITH_HAL ) test and build with dbus-tqt support regardless of
how
WITH_HAL or WITH_TDEHWLIB are set?
I would check to see if either WITH_HAL or WITH_TDEHWLIB are
set before requiring dbus-tqt; if neither are set then tdebase does not
depend on it.
6:40 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Seems then
that my temporary patch is best? Just delete
the if( WITH_HAL ) test and build with
dbus-tqt support regardless of
how
WITH_HAL or WITH_TDEHWLIB are set?
I would check to see if either WITH_HAL or WITH_TDEHWLIB are
set before requiring dbus-tqt; if neither are set then tdebase does not
depend on it. 
1:43 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
On Aug 13, 2012 2:40 AM, "Timothy Pearson" <kb9vqf(a)pearsoncomputing.net wrote:
trinity-devel-unsubscribe(a)lists.pearsoncomputing.net
We should assume all users have dbus just like dcop
>>> > Seems then that my temporary patch is best? Just delete
>>> the if( WITH_HAL ) test and build with dbus-tqt support regardless of
>>> how
>>> WITH_HAL or WITH_TDEHWLIB are set?
>> >>> I would
check to see if either WITH_HAL or WITH_TDEHWLIB are
>>> set before requiring dbus-tqt; if neither are set then tdebase does
not
>>> depend on it.
> >> I ran a tdebase build with
WITH_HAL=NO, WITH_TDEHWLIB=NO and no related
>> patching. The build fails with the same error about not finding
>> dbus/dbus.h. The failure occurs when building tdm backend, in
>> consolekit.c.
> Sounds like the code in consolekit.c is
not properly guarded with
#ifdefs,
which would be
set when dbus-tqt is found.
Tim
Is there any good reason that dbus might not be available on a target
distribution/system? If not, I would say to just make dbus a tdebase
dependency and remove the if statements from around the dbus checks. If
there is a good reason for dbus to be missing, then we will need to add
another flag to build without dbus support and also add the requisite
#ifdefs to the tdm consolekit code.
Thoughts?
Tim
---------------------------------------------------------------------
To unsubscribe, e-mail: For additional commands, e-mail:
trinity-devel-help(a)lists.pearsoncomputing.net
Read list messages on the web archive:
http://trinity-devel.pearsoncomputing.net/
Please remember not to top-post:
http://trinity.pearsoncomputing.net/mailing_lists/#top-posting
5:28 p.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Sounds like
the code in consolekit.c is not properly guarded with #ifdefs,
which would be set when dbus-tqt is found.
Is there any good reason that dbus might not be available on
a target distribution/system? If not, I would say to just make
dbus a tdebase dependency and remove the if statements from around the dbus
checks. If there is a good reason for dbus to be missing, then we will
need to add another flag to build without dbus support and also add the
requisite #ifdefs to the tdm consolekit code.
Thoughts?
14 Aug
14 Aug
4:32 a.m.
New subject: [trinity-devel] tdebase: WITH_HAL=OFF
Sounds like the code in consolekit.c is not properly
guarded with
#ifdefs,
which would be set when dbus-tqt is found.
Is there any good reason that dbus might not be available on
a target distribution/system? If not, I would say to just make
dbus a tdebase dependency and remove the if statements from around the
dbus
checks. If there is a good reason for dbus to be missing, then we will
need to add another flag to build without dbus support and also add the
requisite #ifdefs to the tdm consolekit code.
Thoughts?
4280
days inactive
4286
days old
15 comments
5 participants
participants (5)
-
Calvin Morrison -
Darrell Anderson -
David C. Rankin -
Francois Andriot -
Timothy Pearson