On 03/10/2012 04:16 PM, Darrell Anderson wrote:

...

Things are getting worse instead of better :) The build now craters at tdelibs. This is with a brand new git pull and a fresh build environment. The error looks like our friend tqt_cast is not behaving:

[ 3%] Building CXX object tdefx/CMakeFiles/tdefx-shared.dir/kdrawutil.cpp.o [ 4%] Building CXX object tdefx/CMakeFiles/tdefx-shared.dir/kstyle.cpp.o /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual void KStyle::polish(TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:266:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:266:45: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:266:47: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual void KStyle::unPolish(TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:287:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:287:45: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:287:47: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual bool KStyle::eventFilter(TQObject*, TQEvent*)': /build/src/tdelibs/tdefx/kstyle.cpp:1905:17: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:1905:36: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:1905:37: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:1912:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:1912:48: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:1912:49: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'void {anonymous}::TransparencyHandler::blendToPixmap(const TQColorGroup&, const TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:2295:6: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2295:29: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2295:30: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:2296:48: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2296:71: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2296:72: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'void {anonymous}::TransparencyHandler::XRenderBlendToPixmap(const TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:2317:6: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2317:29: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2317:30: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:2319:7: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2319:30: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2319:31: error: expected primary-expression before '>' token make[2]: *** [tdefx/CMakeFiles/tdefx-shared.dir/kstyle.cpp.o] Error 1 make[1]: *** [tdefx/CMakeFiles/tdefx-shared.dir/all] Error 2 make: *** [all] Error 2

When I look at my tdelibs/tdefx/kstyle.cpp sources I see tqqt_cast and not what you see (tqt_cast).

I don't think your tdelibs is updated correctly. :)

Darrell

No, we're seeing the same thing:

16:30 nirvana:~/tde/tde/main> grep qt_cast tdelibs/tdefx/kstyle.cpp if ( TQFrame *frame = ::tqqt_cast< TQFrame* >( widget ) ) { if ( TQFrame *frame = ::tqqt_cast< TQFrame* >( widget ) ) { && (frame = ::tqqt_cast<TQFrame*>(object)) ) TQToolBar *toolbar = ::tqqt_cast< TQToolBar *>( frame ); if (::tqqt_cast<TQPopupMenu*>(p)) kstyle->renderMenuBlendPixmap( blendPix, cg, ::tqqt_cast<TQPopupMenu*>(p) ); if (::tqqt_cast<TQPopupMenu*>(p)) ::tqqt_cast<TQPopupMenu*>(p) );

This is what I SHOULD have -- right?

On 03/10/2012 04:38 PM, David C. Rankin wrote:

On 03/10/2012 04:32 PM, David C. Rankin wrote:

...

No, we're seeing the same thing:

16:30 nirvana:~/tde/tde/main> grep qt_cast tdelibs/tdefx/kstyle.cpp if ( TQFrame *frame = ::tqqt_cast< TQFrame* >( widget ) ) { if ( TQFrame *frame = ::tqqt_cast< TQFrame* >( widget ) ) { && (frame = ::tqqt_cast<TQFrame*>(object)) ) TQToolBar *toolbar = ::tqqt_cast< TQToolBar *>( frame ); if (::tqqt_cast<TQPopupMenu*>(p)) kstyle->renderMenuBlendPixmap( blendPix, cg, ::tqqt_cast<TQPopupMenu*>(p) ); if (::tqqt_cast<TQPopupMenu*>(p)) ::tqqt_cast<TQPopupMenu*>(p) );

This is what I SHOULD have -- right?

Hold on -- I just kicked off another build after manually cleaning the chroot. I think since I didn't increment the pkgversion variables, that it might have pulled in an old file.

NO, something is broken. I just started from scratch again and:

[ 4%] Building CXX object tdefx/CMakeFiles/tdefx-shared.dir/kstyle.cpp.o /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual void KStyle::polish(TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:266:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:266:45: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:266:47: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual void KStyle::unPolish(TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:287:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:287:45: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:287:47: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'virtual bool KStyle::eventFilter(TQObject*, TQEvent*)': /build/src/tdelibs/tdefx/kstyle.cpp:1905:17: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:1905:36: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:1905:37: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:1912:25: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:1912:48: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:1912:49: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'void {anonymous}::TransparencyHandler::blendToPixmap(const TQColorGroup&, const TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:2295:6: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2295:29: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2295:30: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:2296:48: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2296:71: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2296:72: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp: In member function 'void {anonymous}::TransparencyHandler::XRenderBlendToPixmap(const TQWidget*)': /build/src/tdelibs/tdefx/kstyle.cpp:2317:6: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2317:29: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2317:30: error: expected primary-expression before '>' token /build/src/tdelibs/tdefx/kstyle.cpp:2319:7: error: '::tqt_cast' has not been declared /build/src/tdelibs/tdefx/kstyle.cpp:2319:30: error: expected primary-expression before '*' token /build/src/tdelibs/tdefx/kstyle.cpp:2319:31: error: expected primary-expression before '>' token make[2]: *** [tdefx/CMakeFiles/tdefx-shared.dir/kstyle.cpp.o] Error 1 make[1]: *** [tdefx/CMakeFiles/tdefx-shared.dir/all] Error 2 make: *** [all] Error 2

On 03/10/2012 06:01 PM, David C. Rankin wrote:

Looking at the tqtinterface code for qt_cast, I see:

17:59 nirvana:~/tde/tde/main> grep -r qt_cast dependencies/tqtinterface/ dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast tqt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast qt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqt_cast qt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast qobject_cast dependencies/tqtinterface/qtinterface/convert_qt_tqt2:find ./ -type f -iname "*.c*" -exec sed -i 's/::qt_cast/tqqt_cast/g' {} ;

Where is qt_cast defined??

I see where tqqt_cast is defined as tqt_cast and I see where tqt_cast is defined as qt_cast, but where is qt_cast ever defined?

18:11 nirvana:~/tde/tde/main> grep -E -r "^#define.*qt_cast" dependencies/tqt3 18:12 nirvana:~/tde/tde/main> grep -E -r "^#define.*qt_cast" dependencies/tqtinterface dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast tqt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast qt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqt_cast qt_cast dependencies/tqtinterface/qtinterface/tqt.h.cmake:#define tqqt_cast qobject_cast

The only place I find it is in:

dcop/dcopidlng/kalyptus: virtual void* qt_cast( const char* );

Also, isn't the convert_qt_tqt2 supposed to remove the '::' stuff?? From the errors, it doesn't look like that is working either:

/build/src/tdelibs/tdefx/kstyle.cpp:266:25: error: '::tqt_cast' has not been declared

I guess that is technically tqt_cast, but should the :: be there?

I'm pretty much lost on this one. kdelibs built fine yesterday morning, and now I can't explain the tqt_cast issue. Need some guidance from the experts...

On 03/10/2012 06:27 PM, Darrell Anderson wrote:

...

I'm pretty much lost on this one. kdelibs built fine yesterday morning, and now I can't explain the tqt_cast issue. Need some guidance from the experts...

Did you rebuild tqtinterface?

Darrell

Yes - everything (blank computer forward...)

On 03/10/2012 07:29 PM, Darrell Anderson wrote:

...

...

...

I'm pretty much lost on this one.

kdelibs built fine

...

...

yesterday morning, and now I can't explain the tqt_cast issue. Need some

guidance

...

...

from the experts...

Did you rebuild tqtinterface?

Darrell

Yes - everything (blank computer forward...)

I'm in the middle of some other things at the moment. Later I'll try updating my local repository to the very latest and rebuild another set of packages. In the mean time you could reset your local repository to GIT hash 74c0ee1ffed5d3dc9afe5f21fd62cb351253ffe9, which is where I am at.

cd to the top level of your repository then

git reset --hard 74c0ee1ffed5d3dc9afe5f21fd62cb351253ffe9

That will put us both at the same point in GIT. At least then we will be comparing apples to apples. :) We know I am not seeing the errors you report so if you still see the same error then we look at your setup rather than sources.

Could be that Tim is still applying patches and tweaks today that I have not downloaded since I resynced late last night. If the error disappears then we have a clue. :)

Be sure to rebuild TQt3 and the lot. At least you only have to build to tdebase, which won't take that long. Start the build process, then go kiss the dog and kick the kids.

Darrell

Done -- I'll report back. Thanks Darrell.

I know Tim is still applying patches because the qt_cast function in tdelibs/dcop/dcopidlng/kalyptus just changed to tqt_cast, but no help, tdelibs still crashes at the same place.

Umm... what do I do after the:

git reset --hard 74c0ee1ffed5d3dc9afe5f21fd62cb351253ffe9

to get the code so I can make a fresh set of tarballs? Do I need a git pull or git clean and submodule init?

19:38 nirvana:~/tde/tde> git reset --hard 74c0ee1ffed5d3dc9afe5f21fd62cb351253ffe9 HEAD is now at 74c0ee1 Reset submodule main/tdebase to latest HEAD 19:38 nirvana:~/tde/tde> git pull Updating 74c0ee1..0aefeb2 Fast-forward main/dependencies/python-tqt | 2 +- main/dependencies/qt3 | 2 +- main/dependencies/tqt3 | 2 +- main/tdebase | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

This doesn't looked like it actually changed any code???

...

19:38 nirvana:~/tde/tde> git reset --hard

74c0ee1ffed5d3dc9afe5f21fd62cb351253ffe9

...

HEAD is now at 74c0ee1 Reset submodule main/tdebase to

latest HEAD

...

19:38 nirvana:~/tde/tde> git pull Updating 74c0ee1..0aefeb2 Fast-forward main/dependencies/python-tqt | 2 +- main/dependencies/qt3 | 2 +- main/dependencies/tqt3 | 2 +- main/tdebase | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)

This doesn't looked like it actually changed any

code???

If I understand correctly, the output means that after resetting you now are two commits behind in TQt3. So possibly Tim is indeed still tweaking and I have not downloaded those changes.

But that also means that at the version you now have you should rebuild TQt3, tqtinterface again before building tdelibs.

If you want to see what changed since the version I have from last night and which you now have, resync your repository to the latest version.head. Then cd to the noted directories. Perform 'git log -p' and you will see the actual patching that occurred since I synced last night. If the patches in TQt3 contain changes to the "tqqt_cast" naming then we both know what happended. :)

Darrell