2011/3/8 David C. Rankin drankinatty@suddenlinkmail.com:

...

Tim, Robert, Serghei, Ilya, all:

Here are patches for kdelibs, kdebase, kdegraphics and kdepim that fix the kmenu applications entries that were ending up under "More Programs" submenus because they didn't have a home. The files affected are:

kdelibs:

kdelibs/kded/applications.menu

kdebase:

kdebase/konsole/konsolesu.desktop  kdebase/konqueror/konquerorsu.desktop  kdebase/kcontrol/kfontinst/viewpart/kfontview.desktop

kdepim /home/david/tblds/trinity-kdepim/korn/KOrn.desktop

kdegraphics /home/david/tblds/trinity-kdegraphics/src/kdegraphics/kruler

Screenshots of the System and Internet kmenu entries are here:

http://www.3111skyline.com/dl/dt/trinity/ss/trinity-kmenu-SystemSU.jpg

http://www.3111skyline.com/dl/dt/trinity/ss/trinity-kmenu-InternetEmail.jpg

A new custom 'Category' of 'X-KDE-System-su' was created in applications.menu to accommodate the SuperUser submenu.

Go ahead an apply the patches to a work copy and see what you think. It all works as it is supposed to. The xfw, xfi, etc.. apps still need to be moved out of 'Utilities' to a submenu. I'm thinking Utilities/X-Utilities unless somebody has a better idea.

Getting rid of the "More Applications" submenus really makes Trinity start to look like a (getting)-finished product.

Ilya, look over what I did and make sure it is all OK. I did it using http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html as a reference, so it should be close. The only thing there wasn't a clear reference for was adding the:

<Directory>kde-system-su.directory</Directory>

entries in applications.menu. Looking at all the other entries, that looks like what was needed. Let me know. Thanks.

Enjoy :)

Great! :) I give +1 for approval. The "Email" category might be up for debate, however. I'm not sure about XDG for that.

+1 for commit as well. Serghei, do you want to take care of it? No time right now and I don't want it to get forgotten.

However, in the future, we may not be able to keep using X-KDE-*, because that will start conflicting with KDE4. On Fedora, they've moved everything to X-KDE3-*; a future point may be X-Trinity? idk. (added to checklist though)

sed can take care of that easily enough in the future ;-) find ./ -type f -iname "*.desktop" -exec sed -i 's/X-KDE-/X-Trinity-/g' {} \

Tim

On Tue, Mar 8, 2011 at 23:00, David C. Rankin drankinatty@suddenlinkmail.com wrote:

On 03/08/2011 09:50 PM, Timothy Pearson wrote:

...

+1 for commit as well.  Serghei, do you want to take care of it?  No time right now and I don't want it to get forgotten.

...

...

However, in the future, we may not be able to keep using X-KDE-*, because that will start conflicting with KDE4. On Fedora, they've moved everything to X-KDE3-*; a future point may be X-Trinity? idk. (added to checklist though)

sed can take care of that easily enough in the future ;-) find ./ -type f -iname "*.desktop" -exec sed -i 's/X-KDE-/X-Trinity-/g' {} \

Do we want X-Trinity or X-TDE ? Your call :)

Discuss in meeting? Everyone's a bit busy :P

On 03/08/2011 09:39 PM, Robert Xu wrote:

Great! :) I give +1 for approval. The "Email" category might be up for debate, however. I'm not sure about XDG for that.

However, in the future, we may not be able to keep using X-KDE-*, because that will start conflicting with KDE4. On Fedora, they've moved everything to X-KDE3-*; a future point may be X-Trinity? idk. (added to checklist though)

Yeh, I'm not sure about the KDE4 conflict, I was just sticking to what was documented in the spec:

http://standards.freedesktop.org/menu-spec/menu-spec-1.0.html

<quote> Extensions to the desktop entry format

<snip> Categories not in this document must be prefixed by the string "X-" indicating that they are extensions. Categories are case-sensitive. </quote>

Since the specification is applicable to all desktops (gnome and the rest), I know the 'X-' part is correct. I see your point with the 'KDE' part. From the reading, there is no reason we can do something like 'X-TDE' and be OK. We should just do that from now on. When we tweak the menus again to fix the xfi, xfw apps, we'll change the KDE to TDE and be done with it :)