Hi serghei, Hi all,
This is my second day of learning about cmake. You may find these changes more to your acceptable than my first attempt. :-)
See mods-kdebase.tar.bz2
Castro.
On Tuesday 29 March 2011 12:55:11 Castro wrote:
Hi serghei, Hi all,
This is my second day of learning about cmake. You may find these changes more to your acceptable than my first attempt. :-)
See mods-kdebase.tar.bz2
Castro.
Don't mix CMakeLists.txt with ConfigureChecks.cmake. The kompmgr problem is not so simple to solve, I need to think how to handle it.
Serghei Amelian wrote:
Don't mix CMakeLists.txt with ConfigureChecks.cmake. The kompmgr problem is not so simple to solve, I need to think how to handle it.
I didn't, I started with a clean svn download and have only edited the CmakLists.txt files.
/kdebase/kwin/CmakLists.txt and /kdebase/kwin/kompmgr/CmakLists.txt
Castro.
Hi serghei,
Two files submited for your approvel. :-)
They are commented so that you can see how I came to that conclusion. CMakeLists.txt: kwin.tar.bz2 CMakeLists.txt: kompmgr.tar.bz2
Castro.
On Wednesday 30 March 2011 12:18:58 Castro wrote:
Hi serghei,
Two files submited for your approvel. :-)
They are commented so that you can see how I came to that conclusion. CMakeLists.txt: kwin.tar.bz2 CMakeLists.txt: kompmgr.tar.bz2
Castro.
Fixed in revision 1226469, but not exactly how you expected :)
Serghei Amelian wrote:
On Wednesday 30 March 2011 12:18:58 Castro wrote:
Hi serghei,
Two files submited for your approvel. :-)
They are commented so that you can see how I came to that conclusion. CMakeLists.txt: kwin.tar.bz2 CMakeLists.txt: kompmgr.tar.bz2
Castro.
Fixed in revision 1226469, but not exactly how you expected :)
Thanks Serghei, I will set it going now and read your code to learn a bit more. :-)
Castro.
Serghei Amelian wrote:
Fixed in revision 1226469, but not exactly how you expected :)
It worked like a charm. :-)
I must have a look at tde_conditional_add_subdirectory macro and find out what it is doing. But not now, the pubs are open and I fancy a few pints of scrumpy cider. :-D
Thanks again Serghei, if ever you come to Birmingham UK let me know so I can buy you some. :-D
Castro.
On Wednesday 30 March 2011 15:13:52 Castro wrote:
Serghei Amelian wrote:
Fixed in revision 1226469, but not exactly how you expected :)
It worked like a charm. :-)
I must have a look at tde_conditional_add_subdirectory macro and find out what it is doing.
tde_conditional_add_subdirectory( <condition_variable> <directory> )
If "condition_variable" is true, the "directory" is added to targets.
In our case, kompmgr is built only if WITH_XCOMPOSITE is ON.
But not now, the pubs are open and I fancy a few pints of scrumpy cider. :-D
Thanks again Serghei, if ever you come to Birmingham UK let me know so I can buy you some. :-D
haha, sure :)
On Wednesday 30 March 2011 07:16:32 am Serghei Amelian wrote:
On Wednesday 30 March 2011 12:18:58 Castro wrote:
Hi serghei,
Two files submited for your approvel. :-)
They are commented so that you can see how I came to that conclusion. CMakeLists.txt: kwin.tar.bz2 CMakeLists.txt: kompmgr.tar.bz2
Castro.
Fixed in revision 1226469, but not exactly how you expected :)
Great! Thank you much
Now I can have a clean build