I spent much of the day updating various text strings of branding issues, such as KDE -> TDE, K Desktop -> Trinity Desktop. These strings included What's This, Quick Help, KMessageBox, printf, i18n strings, etc. There was no easy search-and-replace method because many strings had to be read in context before deciding to change anything. Grunt work --- but I think most of this is now behind us.
I still have the lsm files to update.
Please let me know after rebuilding with the latest GIT sources when you notice remnant strings needing attention and let me know whether I got cross-eyed and changed something I should not have.
Darrell
I spent much of the day updating various text strings of branding issues, such as KDE -> TDE, K Desktop -> Trinity Desktop. These strings included What's This, Quick Help, KMessageBox, printf, i18n strings, etc. There was no easy search-and-replace method because many strings had to be read in context before deciding to change anything. Grunt work --- but I think most of this is now behind us.
I still have the lsm files to update.
Please let me know after rebuilding with the latest GIT sources when you notice remnant strings needing attention and let me know whether I got cross-eyed and changed something I should not have.
Darrell
Looks like you severely broke tdebase: http://git.trinitydesktop.org/cgit/tdebase/commit/kcontrol/style/kcmstyle.cp...
Tim
Looks like you severely broke tdebase: http://git.trinitydesktop.org/cgit/tdebase/commit/kcontrol/style/kcmstyle.cp...
Oof! That one looks like a pure "fat fingers" result.
I'll fix.
Darrell
Looks like you severely broke tdebase: http://git.trinitydesktop.org/cgit/tdebase/commit/kcontrol/style/kcmstyle.cp...
Oof! That one looks like a pure "fat fingers" result.
I'll fix.
Darrell
Just pushed in hash b8ecc62 :-)
Tim
Looks like you severely broke tdebase: http://git.trinitydesktop.org/cgit/tdebase/commit/kcontrol/style/kcmstyle.cp...
Oof! That one looks like a pure "fat fingers" result.
I'll fix.
Darrell
Just pushed in hash b8ecc62 :-)
Tim
If you don't mind, can you go through the other patches and make sure that nothing similar happened? If something like this happened in a text string instead of a program variable/define, the compiler won't catch it and we'd end up shipping a regression.
Thanks!
Tim
If you don't mind, can you go through the other patches and make sure that nothing similar happened? If something like this happened in a text string instead of a program variable/define, the compiler won't catch it and we'd end up shipping a regression.
I'm going to run a full build session this evening too.
Darrell
If you don't mind, can you go through the other patches and make sure that nothing similar happened? If something like this happened in a text string instead of a program variable/define, the compiler won't catch it and we'd end up shipping a regression.
Found one build error in the major packages (amarok): fixed in GIT hash 6bc5350c. Everything else built without error.
Darrell
Oof! That one looks like a pure "fat fingers" result.
I'll fix.
Darrell
Just pushed in hash b8ecc62 :-)
Hey, I just grabbed the patch. I notice the following:
TDE_EXPORT should be KDE_EXPORT
exportTDEColors should be exportKDEColors
config.setGroup("TDE") should be config.setGroup("KDE")
config.hasGroup("TDE") should be config.hasGroup("KDE")
I'll correct when I finish uploading all of the lsm updates.
Darrell
Oof! That one looks like a pure "fat fingers" result.
I'll fix.
Darrell
Just pushed in hash b8ecc62 :-)
Hey, I just grabbed the patch. I notice the following:
TDE_EXPORT should be KDE_EXPORT
exportTDEColors should be exportKDEColors
config.setGroup("TDE") should be config.setGroup("KDE")
config.hasGroup("TDE") should be config.hasGroup("KDE")
I'll correct when I finish uploading all of the lsm updates.
Darrell
OK, let me know when it's fixed.
Thanks!
Tim
-
Darrell Anderson -
Timothy Pearson