Anybody? Is this one of those cases where I can just try declaring 'App' somewhere? If so, where?

I'll guess that you performed a sed replacement of tqApp to App. When you replace "tq" for 3.5.13 then replace "tq" with "q." For example tqApp -> qApp.

Darrell

On 08/10/2012 06:14 AM, Slávek Banko wrote:

I think the problem is not tqApp × qApp. First, tqApp is also in many other places. Second, in tqtinterface v3.5.13-sru is in tqt.h tqApp defined as qApp.

Do you have really tqtinterface version v3.5.13-sru?

Slavek

Yes... tqApp is correct, that code hasn't changed in more than a year. It is the same in 3.5.13-sru and TDE. I do have 3.5.13-sru tqtinterface:

09:25 archangel:/dat_f/tde/tde/main/dependencies/tqtinterface> git branch -l master * v3.5.13-sru

What causes me to think it is a problem in kdevdesigner/designer is that the rest of 3.5.13-sru has built without issue:

tde-abakus-3.5.13_sru-1-x86_64.pkg.tar.xz tde-amarok-3.5.13_sru-1-x86_64.pkg.tar.xz tde-arts-3.5.13_sru-1-x86_64.pkg.tar.xz tde-avahi-tqt-3.5.13_sru-1-x86_64.pkg.tar.xz tde-basket-1.0.3-1-x86_64.pkg.tar.xz tde-dbus-1-tqt-3.5.13_sru-1-x86_64.pkg.tar.xz tde-dbus-tqt-3.5.13_sru-1-x86_64.pkg.tar.xz tde-digikam-3.5.13_sru-1-x86_64.pkg.tar.xz tde-dolphin-3.5.13_sru-1-x86_64.pkg.tar.xz tde-filelight-3.5.13_sru-1-x86_64.pkg.tar.xz tde-gtk-qt-engine-3.5.13_sru-1-x86_64.pkg.tar.xz tde-gwenview-3.5.13_sru-1-x86_64.pkg.tar.xz tde-k3b-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kaffeine-3.5.13_sru-1-x86_64.pkg.tar.xz tde-katapult-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kbarcode-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kbookreader-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kdiff3-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kdirstat-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kdmtheme-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kgtk-qt3-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kima-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kio-locate-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kipi-plugins-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kmplayer-3.5.13_sru-1-x86_64.pkg.tar.xz tde-knemo-3.5.13_sru-1-x86_64.pkg.tar.xz tde-knetload-3.5.13_sru-1-x86_64.pkg.tar.xz tde-knetstats-3.5.13_sru-1-x86_64.pkg.tar.xz tde-knutclient-3.5.13_sru-1-x86_64.pkg.tar.xz tde-koffice-3.5.13_sru-1-x86_64.pkg.tar.xz tde-konversation-3.5.13_sru-1-x86_64.pkg.tar.xz tde-kpowersave-3.5.13_sru-1-x86_64.pkg.tar.xz tde-krename-3.5.13_sru-1-x86_64.pkg.tar.xz tde-krusader-3.5.13_sru-1-x86_64.pkg.tar.xz tde-ksplash-engine-moodin-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libart-lgpl-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libcaldav-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libcarddav-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libkdcraw-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libkexiv2-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libkipi-3.5.13_sru-1-x86_64.pkg.tar.xz tde-libksquirrel-3.5.13_sru-1-x86_64.pkg.tar.xz tde-qca-tls-3.5.13_sru-1-x86_64.pkg.tar.xz tde-qt3-3.8.8.d_git-1-x86_64.pkg.tar.xz tde-rosegarden-3.5.13_sru-1-x86_64.pkg.tar.xz tde-sip-3.5.13_sru-1-x86_64.pkg.tar.xz tde-sip4-tqt-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tde-style-qtcurve-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeaccessibility-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeaddons-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeadmin-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeartwork-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdebase-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeedu-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdegames-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdegraphics-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdelibs-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdemultimedia-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdenetwork-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdepim-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdetoys-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tdeutils-3.5.13_sru-1-x86_64.pkg.tar.xz tde-tqtinterface-3.5.13_sru-1-x86_64.pkg.tar.xz tde-twin-style-crystal-3.5.13_sru-1-x86_64.pkg.tar.xz tde-wlassistant-3.5.13_sru-1-x86_64.pkg.tar.xz

If there was a problem with my tqtinterface, I would have expected to see it pop up in a lot more places. The only includes in listeditor.ui.h are:

#include <tqheader.h> #include <tqapplication.h>

Will that pull in the tqApp->qApp definition?

On 08/10/2012 09:34 AM, David C. Rankin wrote:

On 08/10/2012 09:30 AM, David C. Rankin wrote:

...

If there was a problem with my tqtinterface, I would have expected to see it pop up in a lot more places. The only includes in listeditor.ui.h are:

#include <tqheader.h> #include <tqapplication.h>

Will that pull in the tqApp->qApp definition?

I find the definition in /usr/include/tqt/tqt.h:

tqt.h:#define tqApp qApp

Is there any reason you can think of that tdevelop/kdevdesigner/designer would miss pulling it in? CMakeLists.txt?

Something is really strange here! I included tqt.h directly in the listeditor.ui.h file and it still complains about no App:

10:03 archangel:/dat_e/ch35/david/build> head -n20 src/build/kdevdesigner/designer/listeditor.ui.h /**************************************************************************** ** ui.h extension file, included from the uic-generated form implementation. ** ** If you wish to add, delete or rename slots use Qt Designer which will ** update this file, preserving your code. Create an init() slot in place of ** a constructor, and a destroy() slot in place of a destructor. *****************************************************************************/

#include <tqheader.h> #include <tqapplication.h> #include <tqt.h> ^^^^^^^^^^^^^^^^

Same error. I also notice tqt.h is included directly in the compile command as well:

[ 89%] Building CXX object kdevdesigner/designer/CMakeFiles/libkdevdesignerpart-module.dir/listeditor.cpp.o cd /build/src/build/kdevdesigner/designer && /usr/bin/c++ -Dlibkdevdesignerpart_module_EXPORTS -DHAVE_CONFIG_H -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -DDESIGNER -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -Wno-deprecated -include tqt.h -fPIC -I/build/src/build/kdevdesigner/designer -I/build/src/tdevelop/kdevdesigner/designer -I/build/src/tdevelop/kdevdesigner/shared -I/build/src/tdevelop/lib/interfaces/external -I/opt/trinity/include -I/opt/qt3/include -I/usr/include/tqt -include tqt.h -UQT_NO_ASCII_CAST -o CMakeFiles/libkdevdesignerpart-module.dir/listeditor.cpp.o -c /build/src/build/kdevdesigner/designer/listeditor.cpp In file included from /build/src/build/kdevdesigner/designer/listeditor.cpp:22:0: /build/src/build/kdevdesigner/designer/listeditor.ui.h: In member function 'virtual void ListEditor::addItem()': /build/src/build/kdevdesigner/designer/listeditor.ui.h:34:5: error: 'App' was not declared in this scope make[2]: *** [kdevdesigner/designer/CMakeFiles/libkdevdesignerpart-module.dir/listeditor.cpp.o] Error 1 make[2]: Leaving directory `/build/src/build' make[1]: *** [kdevdesigner/designer/CMakeFiles/libkdevdesignerpart-module.dir/all] Error 2 make[1]: Leaving directory `/build/src/build' make: *** [all] Error 2

With '#define tqApp qApp' in tqt.h, why the heck is this failing when it gets to:

void ListEditor::addItem() { QListViewItem *i = new QListViewItem( listview, listview->lastItem() ); i->setRenameEnabled( 0, TRUE ); App->processEvents(); ^^^ i->startRename( 0 ); }

SMACK!!! (where the hell is the 'q' or 'tq' in front of 'App'?)

SOMEBODY DROPPED A 'q' OR 'tq' in the CMake files. It is 'tqApp->processEvents();' in the GIT tree, but 'App->processEvents();' when it gets to the CMake build/ directory...... Who is the guilty dog...

On 08/10/2012 11:01 AM, David C. Rankin wrote:

void ListEditor::addItem() { TQListViewItem *i = new TQListViewItem( listview, listview->lastItem() ); i->setRenameEnabled( 0, TRUE ); App->processEvents(); i->startRename( 0 ); }

What needs to be fixed to prevent this from happening? I've looked at the CMakeLists.txt files and ConfigureChecks.cmake I can't find it being done there, so what is doing it?

Any thoughts? I would like to change [FOUND] to [SOLVED] :)

Le 11/08/2012 03:47, David C. Rankin a écrit :

On 08/10/2012 11:01 AM, David C. Rankin wrote:

...

void ListEditor::addItem() { TQListViewItem *i = new TQListViewItem( listview, listview->lastItem() ); i->setRenameEnabled( 0, TRUE ); App->processEvents(); i->startRename( 0 ); }

What needs to be fixed to prevent this from happening? I've looked at the CMakeLists.txt files and ConfigureChecks.cmake I can't find it being done there, so what is doing it?

Any thoughts? I would like to change [FOUND] to [SOLVED] :)

Hello, using tqtinterface 3.5.13 (not SRU), it works for me if I rename "tqApp" with "qApp" in "listeditor.ui.h". But if I leave "tqApp", it is modified to "App" and causes FTBFS, as you describe.

I think the culprit is uic-tqt, which calls the tqt-replace script, which contains lots of sed commands. See line 14 of the script.

Try and see yourself: sed 's/([ \t])tq([^:(_)\t ])/\1\2/g' listeditor.ui.h

Francois

On 08/11/2012 02:14 PM, David C. Rankin wrote:

On 08/11/2012 02:45 AM, Francois Andriot wrote:

...

Hello, using tqtinterface 3.5.13 (not SRU), it works for me if I rename "tqApp" with "qApp" in "listeditor.ui.h". But if I leave "tqApp", it is modified to "App" and causes FTBFS, as you describe.

I think the culprit is uic-tqt, which calls the tqt-replace script, which contains lots of sed commands. See line 14 of the script.

Try and see yourself: sed 's/([ \t])tq([^:(_)\t ])/\1\2/g' listeditor.ui.h

Francois

Tim, Francios,

Thank you for pointing me in the right direction. I know very little about all the sed magic going on behind the scenes. I couldn't even find the call. But I found the solution!

tqt-replace in 3.5.13-sru is MISSING THE LINE:

• sed -i 's/tqApp/qApp/g' "$1" sed -i 's/([ \t])tq([^:(_)\t ])/\1\2/g' "$1"

  It is present in R14, but is NOT in 3.5.13-sru. Please signoff and push Slavek :)

patch attached

On 08/11/2012 08:42 PM, Slávek Banko wrote:

Incidentally, note that so far has been tqtinterface v3.5.13-sru completely unchanged from the original v3.5.13. Although I have a few patches ready. But I gave careful, to I no broke possibility to build the original v3.5.13 code with the updated tqtinterface.

Slavek

Slow and careful is the only way :) You have done a good job!