Tim,
I see some preparatory patches for moving to libmagic for mime detection. Will these patches cause breakage until completed? If yes, please post something to the list when the conversion is complete or ready for testing.
Darrell
Le 01/10/2014 21:22, Darrell a écrit :
Tim,
I see some preparatory patches for moving to libmagic for mime detection. Will these patches cause breakage until completed? If yes, please post something to the list when the conversion is complete or ready for testing.
Darrell
It's probably broken already. FTBFS in current tdebase:
[ 44%] Building CXX object konqueror/iconview/CMakeFiles/konq_iconview-module.dir/konq_iconview.cc.o cd "/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build/konqueror/iconview" && /usr/local/bin/c++ -DHAVE_CONFIG_H -D_LARGEFILE64_SOURCE -Dkonq_iconview_module_EXPORTS -O2 -g -m64 -fmessage-length=0 -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -I/usr/include/tqt3 -I/usr/include/tqt -DQT_NO_ASCII_CAST -DQT_CLEAN_NAMESPACE -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -DQT_THREAD_SUPPORT -D_REENTRANT -include tqt.h -DNDEBUG -fPIC -I"/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build/konqueror/iconview" -I"/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build" -I"/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/libkonq" -I/opt/trinity/include/tde -I/usr/include/tqt3 -I/usr/include/tqt -o CMakeFiles/konq_iconview-module.dir/konq_iconview.cc.o -c "/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc" /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc: In member function 'virtual void KonqKfmIconView::slotNewItems(const KFileItemList&)': /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc:1011:24: error: 'class KFileItem' has no member named 'mimetypeFast' if ( fileItem->mimetypeFast().startsWith("media/") && fileItem->mimetypeFast().contains("_mounted") && m_pProps->isShowingFreeSpaceOverlays() ) { ^ /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc:1011:73: error: 'class KFileItem' has no member named 'mimetypeFast' if ( fileItem->mimetypeFast().startsWith("media/") && fileItem->mimetypeFast().contains("_mounted") && m_pProps->isShowingFreeSpaceOverlays() ) { ^ /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc: In member function 'virtual void KonqKfmIconView::slotRefreshItems(const KFileItemList&)': /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc:1210:26: error: 'class KFileItem' has no member named 'mimetypeFast' if ( (*rit)->mimetypeFast().startsWith("media/") && m_pProps->isShowingFreeSpaceOverlays() ) { ^ /dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/konqueror/iconview/konq_iconview.cc:1211:29: error: 'class KFileItem' has no member named 'mimetypeFast' if ((*rit)->mimetypeFast().contains("_mounted")) { ^ make[3]: *** [konqueror/iconview/CMakeFiles/konq_iconview-module.dir/konq_iconview.cc.o] Error 1 make[3]: Leaving directory `/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build' make[2]: *** [konqueror/iconview/CMakeFiles/konq_iconview-module.dir/all] Error 2 make[2]: Leaving directory `/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build' make[1]: *** [all] Error 2 make[1]: Leaving directory `/dev/shm/BUILD.oss131.x86_64/trinity-tdebase-14.0.0~pre1300+13e88631/build'
Le 01/10/2014 22:53, Darrell a écrit :
On Wed October 1 2014 2:56:14 pm François Andriot wrote:
It's probably broken already. FTBFS in current tdebase:
There you go. :) I'll find other things to do for a few days.
Darrell
Hello, New FTBFS in tdelibs today:
656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp: In member function 'bool KMimeMagic::mergeConfig(const TQString&)': [ 656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp:254:32: error: 'magic_version' was not declared in this scope [ 656s] make[2]: *** [tdeio/tdeio/CMakeFiles/tdeiocore-static.dir/kmimemagic.cpp.o] Error 1
It looks like many distributions ship with a libmagic that do NOT have the "magic_version()" function...
François
New FTBFS in tdelibs today:
656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp: In member function 'bool KMimeMagic::mergeConfig(const TQString&)': [ 656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp:254:32: error: 'magic_version' was not declared in this scope [ 656s] make[2]: *** [tdeio/tdeio/CMakeFiles/tdeiocore-static.dir/kmimemagic.cpp.o] Error 1
I think the problem is tdelibs/tdeio/tdeio/kmimemagic.cpp:33: #include <magic.h>
I just noticed in LMDE that magic.h is installed from the development package (libmagic-dev) and not part of the user package (libmagic1).
Darrell
On 10/08/2014 04:57 AM, François Andriot wrote:
Le 01/10/2014 22:53, Darrell a écrit :
On Wed October 1 2014 2:56:14 pm François Andriot wrote:
It's probably broken already. FTBFS in current tdebase:
There you go. :) I'll find other things to do for a few days.
Darrell
Hello, New FTBFS in tdelibs today:
656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp: In member function 'bool KMimeMagic::mergeConfig(const TQString&)': [ 656s] /home/abuild/rpmbuild/BUILD/trinity-tdelibs-14.0.0/tdeio/tdeio/kmimemagic.cpp:254:32: error: 'magic_version' was not declared in this scope [ 656s] make[2]: *** [tdeio/tdeio/CMakeFiles/tdeiocore-static.dir/kmimemagic.cpp.o] Error 1
It looks like many distributions ship with a libmagic that do NOT have the "magic_version()" function...
No problem in Debian/Jessie today. You may need to install libmagic-dev to build (I had a similar problem a few days ago when libmagic-dev wasn't in the list of dependencies.
Cheers Michele
Le 08/10/2014 10:48, Michele Calgaro a écrit :
No problem in Debian/Jessie today. You may need to install libmagic-dev to build (I had a similar problem a few days ago when libmagic-dev wasn't in the list of dependencies.
Cheers Michele
No, I have the libmagic development files installed, including /usr/include/magic.h and /usr/lib64/libmagic.so But I don't have magic_version() defined in magic.h . It looks like MAGIC_VERSION and magic_version() appeared in version 5.13 But I see that now there is a check #ifdef MAGIC_VERSION in tdelibs so it works again
François
Another FTBFS on old libmagic (version 4.17), because MAGIC_MIME_TYPE is not defined in magic.h
I have in magic.h :
#define MAGIC_NONE 0x000 /* No flags */ #define MAGIC_DEBUG 0x001 /* Turn on debugging */ #define MAGIC_SYMLINK 0x002 /* Follow symlinks */ #define MAGIC_COMPRESS 0x004 /* Check inside compressed files */ #define MAGIC_DEVICES 0x008 /* Look at the contents of devices */ #define MAGIC_MIME 0x010 /* Return a mime string */ #define MAGIC_CONTINUE 0x020 /* Return all matches */ #define MAGIC_CHECK 0x040 /* Print warnings to stderr */ #define MAGIC_PRESERVE_ATIME 0x080 /* Restore access time on exit */ #define MAGIC_RAW 0x100 /* Don't translate unprintable chars */ #define MAGIC_ERROR 0x200 /* Handle ENOENT etc as real errors */
Attached patch is supposed to fix this.
François
On Saturday 11 of October 2014 15:33:02 François Andriot wrote:
Another FTBFS on old libmagic (version 4.17), because MAGIC_MIME_TYPE is not defined in magic.h
I have in magic.h :
#define MAGIC_NONE 0x000 /* No flags */ #define MAGIC_DEBUG 0x001 /* Turn on debugging */ #define MAGIC_SYMLINK 0x002 /* Follow symlinks */ #define MAGIC_COMPRESS 0x004 /* Check inside compressed files */ #define MAGIC_DEVICES 0x008 /* Look at the contents of devices */ #define MAGIC_MIME 0x010 /* Return a mime string */ #define MAGIC_CONTINUE 0x020 /* Return all matches */ #define MAGIC_CHECK 0x040 /* Print warnings to stderr */ #define MAGIC_PRESERVE_ATIME 0x080 /* Restore access time on exit */ #define MAGIC_RAW 0x100 /* Don't translate unprintable chars */ #define MAGIC_ERROR 0x200 /* Handle ENOENT etc as real errors */
Attached patch is supposed to fix this.
François
Patch pushed to GIT in hash 8f117582.
Le 11/10/2014 17:30, Slávek Banko a écrit :
On Saturday 11 of October 2014 15:33:02 François Andriot wrote:
Another FTBFS on old libmagic (version 4.17), because MAGIC_MIME_TYPE is not defined in magic.h
I have in magic.h :
#define MAGIC_NONE 0x000 /* No flags */ #define MAGIC_DEBUG 0x001 /* Turn on debugging */ #define MAGIC_SYMLINK 0x002 /* Follow symlinks */ #define MAGIC_COMPRESS 0x004 /* Check inside compressed files */ #define MAGIC_DEVICES 0x008 /* Look at the contents of devices */ #define MAGIC_MIME 0x010 /* Return a mime string */ #define MAGIC_CONTINUE 0x020 /* Return all matches */ #define MAGIC_CHECK 0x040 /* Print warnings to stderr */ #define MAGIC_PRESERVE_ATIME 0x080 /* Restore access time on exit */ #define MAGIC_RAW 0x100 /* Don't translate unprintable chars */ #define MAGIC_ERROR 0x200 /* Handle ENOENT etc as real errors */
Attached patch is supposed to fix this.
François
Patch pushed to GIT in hash 8f117582.
Thank you. can you also look at the current patch in bug #2133 ? I think it's the last FTBFS occuring in opensuse build service packages.
François
On Saturday 11 of October 2014 17:34:11 François Andriot wrote:
Le 11/10/2014 17:30, Slávek Banko a écrit :
On Saturday 11 of October 2014 15:33:02 François Andriot wrote:
Another FTBFS on old libmagic (version 4.17), because MAGIC_MIME_TYPE is not defined in magic.h
I have in magic.h :
#define MAGIC_NONE 0x000 /* No flags */ #define MAGIC_DEBUG 0x001 /* Turn on debugging */ #define MAGIC_SYMLINK 0x002 /* Follow symlinks */ #define MAGIC_COMPRESS 0x004 /* Check inside compressed files */ #define MAGIC_DEVICES 0x008 /* Look at the contents of devices */ #define MAGIC_MIME 0x010 /* Return a mime string */ #define MAGIC_CONTINUE 0x020 /* Return all matches */ #define MAGIC_CHECK 0x040 /* Print warnings to stderr */ #define MAGIC_PRESERVE_ATIME 0x080 /* Restore access time on exit */ #define MAGIC_RAW 0x100 /* Don't translate unprintable chars */ #define MAGIC_ERROR 0x200 /* Handle ENOENT etc as real errors */
Attached patch is supposed to fix this.
François
Patch pushed to GIT in hash 8f117582.
Thank you. can you also look at the current patch in bug #2133 ? I think it's the last FTBFS occuring in opensuse build service packages.
François
Done :)
-
Darrell -
François Andriot -
Michele Calgaro -
Slávek Banko