Tim, Darrell,
In working tdebase patches, I note that one of the traditional patch files to the kdebase source (existing in patches.tar.bz2 - 08-kip_kdesktop_rounded_icon_text_corners.patch) is not applied in the current git source, and fails to apply due to the file name change. I think it is probably a good idea to keep the patch. The patch is:
diff -Naur kdebase-3.5.8.orig/kdesktop/kfileividesktop.cpp kdebase-3.5.8/kdesktop/kfileividesktop.cpp --- kdebase-3.5.8.orig/kdesktop/kfileividesktop.cpp 2007-10-08 15:58:03.000000000 +0200 +++ kdesktop/kfileividesktop.cpp 2007-11-20 13:57:09.000000000 +0100 @@ -100,6 +100,13 @@
// draw the pixmap as in KIconViewItem::paintItem(...) paintPixmap(p, colors); + if ( isSelected() ) { + p->setBrush( TQBrush( cg.highlight() ) ); + p->setPen( TQPen( cg.highlight() ) ); + p->drawRoundRect( textRect( FALSE ), + 1000 / textRect( FALSE ).width(), + 1000 / textRect( FALSE ).height() ); + }
My question is did all the code class names change as well?? I guess it doesn't matter here, but I've grepped and the only thing I come up with is:
tdefileividesktop.cpp:87:void KFileIVIDesktop::paintItem( TQPainter *p, const TQColorGroup &cg)
So I think the comment above is wrong as well. Do we want to try and apply the traditional KDE patches that remain in patches.tar.bz2 to the code before R14 release (fix them once and for all)? the only patches that remain are:
patches/08-kip_kdesktop_rounded_icon_text_corners.patch patches/03-kcontrol_advbg_step.patch patches/06-nspluginscan-xdgcompliance.patch patches/01-kicker-lockout-applet-button-order.patch
Let me know. I'll keep tweaking these for now.