Tim, Darrell,
Why does the common/cmake/modules/TDESetupPaths.cmake still include the reference to 'kde' in the HTML path?
_tde_internal_setup_path( HTML_INSTALL_DIR "${SHARE_INSTALL_PREFIX}/doc/kde/HTML"
I know Darrell has been working on patches to update this location. Couldn't we just set it here in cmake and then just build all packages letting this default set the proper location?
Why does the common/cmake/modules/TDESetupPaths.cmake still include the reference to 'kde' in the HTML path?
_tde_internal_setup_path( HTML_INSTALL_DIR "${SHARE_INSTALL_PREFIX}/doc/kde/HTML"
I know Darrell has been working on patches to update this location. Couldn't we just set it here in cmake and then just build all packages letting this default set the proper location?
My patches will fix that in all modules. The challenge is I need a few hours to patch-commit-push every module. Did you know there are 117 modules?
Darrell
On 04/10/2012 12:35 PM, Darrell Anderson wrote:
My patches will fix that in all modules. The challenge is I need a few hours to patch-commit-push every module. Did you know there are 117 modules?
Darrell
That's great news!
I have 86 TDE build scripts of which 68 are building after the gcc47 update (10 have never built) -- so that only leaves 49 to go :)
gcc47 current failures of those that were building prior to gcc47 (unknown number undiscovered in 39 untried packages)
tde-kipi-plugins mutiple declarations of 'TQListViewItemIterator it(d->listView)' in kipi-plugins/flickrexport/imageslist.cpp
tde-tdeedu tde-tdegraphics tde-tdepim tde-rosegarden tde-basket (gcc47 - fixed: patch tde-basket-gcc47.diff) tde-k3b tde-kima tde-krusader
Why does the common/cmake/modules/TDESetupPaths.cmake still include the reference to 'kde' in the HTML path?
_tde_internal_setup_path( HTML_INSTALL_DIR "${SHARE_INSTALL_PREFIX}/doc/kde/HTML"
I know Darrell has been working on patches to update this location. Couldn't we just set it here in cmake and then just build all packages letting this default set the proper location?
My patches will fix that in all modules. The challenge is I need a few hours to patch-commit-push every module. Did you know there are 117 modules?
Darrell
You do know that to update anything in cmake/ or admin/ you just need to push once to main/commmon/cmake or main/common/admin and the system will automatically bring those changes into all other TDE modules, correct?
Tim
You do know that to update anything in cmake/ or admin/ you just need to push once to main/commmon/cmake or main/common/admin and the system will automatically bring those changes into all other TDE modules, correct?
No I don't know that. Please provide the specifics!
Even after the admin and cmake directories replicate (how do they do that --- in your nightlies or during any local build?), that will not catch everything. So I probably still need to make another pass to create module specific packages, which, if I understand you correctly, means only a handful of patches rather than 117.
Darrell
You do know that to update anything in cmake/ or admin/ you just need to push once to main/commmon/cmake or main/common/admin and the system will automatically bring those changes into all other TDE modules, correct?
No I don't know that. Please provide the specifics!
Even after the admin and cmake directories replicate (how do they do that --- in your nightlies or during any local build?), that will not catch everything. So I probably still need to make another pass to create module specific packages, which, if I understand you correctly, means only a handful of patches rather than 117.
Darrell
The cmake/ and admin/ directories (and a few others such as libltdl) are replicated into each top level module via GIT submodules. This process occurs continually on the TDE GIT server, and usually catches changes within 24 hours, independent of the nightly build system.
In fact, you ***cannot*** change anything under admin/ or cmake/ in any of the TDE modules other than common/, as your change will be detected and reversed by the same system that keeps the submodules up to date.
Tim
The cmake/ and admin/ directories (and a few others such as libltdl) are replicated into each top level module via GIT submodules. This process occurs continually on the TDE GIT server, and usually catches changes within 24 hours, independent of the nightly build system.
In fact, you ***cannot*** change anything under admin/ or cmake/ in any of the TDE modules other than common/, as your change will be detected and reversed by the same system that keeps the submodules up to date.
Do you mean I can't push changes to admin/cmake in each individual module because the next time I resync they all will be overwritten? That any changes I always want to make to admin/cmake must be to the common ones and they must be pushed immediately?
How do I test here before pushing to the master server? If the replication occurs only at the main GIT server, then those replications do not occur locally to all of the modules in my local tree. Seems the only way to make this change is to patch my common admin/cmake and push immediately. But then I hold my breath that I did not break anything major.
Seems as though there is a point of uncertainty whne pushing changes to the common admin/cmake. I can't simulate the replication of the main GIT server.
Perhaps I am misunderstanding the whole thing.
I also need to concurrently push the changes to tdelibs because of kstandarddirs.cpp.
Darrell
The cmake/ and admin/ directories (and a few others such as libltdl) are replicated into each top level module via GIT submodules. This process occurs continually on the TDE GIT server, and usually catches changes within 24 hours, independent of the nightly build system.
In fact, you ***cannot*** change anything under admin/ or cmake/ in any of the TDE modules other than common/, as your change will be detected and reversed by the same system that keeps the submodules up to date.
Do you mean I can't push changes to admin/cmake in each individual module because the next time I resync they all will be overwritten?
Yes.
That any changes I always want to make to admin/cmake must be to the common ones and they must be pushed immediately?
No. You need to change the files in the common/ directory, yes, but there is no time limit to push them. :-)
How do I test here before pushing to the master server? If the replication occurs only at the main GIT server, then those replications do not occur locally to all of the modules in my local tree. Seems the only way to make this change is to patch my common admin/cmake and push immediately. But then I hold my breath that I did not break anything major.
You would patch your local admin/ directory, build, test, etc., then once it works generate a patch, apply the patch to the common/admin/ directory, and commit.
Make sense?
Tim
You would patch your local admin/ directory, build, test, etc., then once it works generate a patch, apply the patch to the common/admin/ directory, and commit.
Make sense?
I think. Maybe.
When I build locally, does each module pull from my local common admin/cmake? I remain unclear about that.
Do I have permissions to push to the common admin/cmake? I tried pushing some nominal typo corrections for qt3 and tqt3 and was rejected.
Darrell
You would patch your local admin/ directory, build, test, etc., then once it works generate a patch, apply the patch to the common/admin/ directory, and commit.
Make sense?
I think. Maybe.
When I build locally, does each module pull from my local common admin/cmake? I remain unclear about that.
No. You would need to issue a 'git submodule update' command inside a top level module (tdelibs, tdebase, etc.) in order to update any submodules (admin/, cmake/, libltdl/, etc.) from the TDE server.
Do I have permissions to push to the common admin/cmake? I tried pushing some nominal typo corrections for qt3 and tqt3 and was rejected.
You should--make sure that you are committing/pushing from within either admin/ or cmake/, not common/.
Tim
No. You would need to issue a 'git submodule update' command inside a top level module (tdelibs, tdebase, etc.) in order to update any submodules (admin/, cmake/, libltdl/, etc.) from the TDE server.
Ok. I don't need to do that. I'll push the common directory changes to GIT and wait until the next day to resync here. By then the main repo will have replicated those changes to all other modules.
I just now created the patches for common. Only three files involved and only a one-liner in each.
With those changes I'll push the tdelibs patch then too because kstandarddir.h/cpp need to be updated concurrently.
That still leaves individual module changes wioth various oddball changes, such as docbook files, but I can regenerate those patches after the master server has done the basics.
Do I have permissions to push to the common
admin/cmake? I tried pushing some nominal typo corrections for qt3 and tqt3 and was rejected.
You should--make sure that you are committing/pushing from within either admin/ or cmake/, not common/.
Ok.
Darrell
-
Darrell Anderson -
David C. Rankin -
Timothy Pearson