Archers - Tim, I am reviewing these patches now.
dbusfix.patch - is a arch specific compiler fix. It is hardcoded and should not be sent upstream. Don't merge.
kicker-lockout.patch - this is kind of silly, it allows you to either switch the spot of either Lock or Logout. It doesn't seem entirely useful. Especially not if I can push my changes for kickers logout before R14. I know extra configuration is good - but this seems to be manual solution. I think it would be better to have these items operate as regular entries, that way users could move/add/remove them as pleased. I wouldn't merge
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
kcontrol_advbg_step.patch - "this patch modifies the step of refresh time in advanced background settings of kcontrol step instead of being 5 is 1, the maximal value of refresh time is incremented too." - I am not sure this makes anything better or worse. I haven't had any problems with kcontrol's background. Pawel?
nsplugincontainer-xdgcomplaince.patch - Apparently makes this xdg compliant. I need someone to review this as well.
bigger_title_icons_in_kcontrol.patch - changes the hardcoded size of icons from 22 to 48 - not sure what value it adds, or if really needs to be changes.
On 02/23/2012 09:19 AM, Calvin Morrison wrote:
Archers - Tim, I am reviewing these patches now.
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
No documentation should go where LSB says it should
On 23 February 2012 09:47, Baho Utot baho-utot@columbus.rr.com wrote:
On 02/23/2012 09:19 AM, Calvin Morrison wrote:
Archers - Tim, I am reviewing these patches now.
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
No documentation should go where LSB says it should
Where is the proper location?
Calvin
On 02/23/2012 10:02 AM, Calvin Morrison wrote:
On 23 February 2012 09:47, Baho Utotbaho-utot@columbus.rr.com wrote:
On 02/23/2012 09:19 AM, Calvin Morrison wrote:
Archers - Tim, I am reviewing these patches now.
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
No documentation should go where LSB says it should
Where is the proper location?
Calvin
/usr/share/doc or something like that.
Just because you choose to put tde into /opt does not mean that the docs should not or can not be installed into /usr/share.
If you would place those things where LSB says it should go then that issue is completed and would need to be addressed when and if tde can go into /usr as it is already done and completed.
That's what I do in my current PKGBUILDS... I put it where is goes by LSB as long as it does create trouble.
ie if a package has the man files in /usr/man I relocate them in the packaing process to /usr/share/man/man[1..8]
namcap is very good at finding those things and a simple
install -vdm 755 ${pkgdir}/usr/share/man mv ${pkgdir}/usr/man/* ${pkgdir}/usr/share/man rm -rf ${pkgdir}/usr/man
and I am good to go. See nothing too hard and it is now where LSB and most distros expect it to be. I don't have to monkey with the man paths etc....it just works!
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
Note: This is the same problem reported in bug report 660. Automake and cmake packages need to be consistent and they are not.
Darrell
On 02/23/2012 08:19 AM, Calvin Morrison wrote:
bigger_title_icons_in_kcontrol.patch - changes the hardcoded size of icons from 22 to 48 - not sure what value it adds, or if really needs to be changes.
I HATE bit icons :) I say we kill this one.
On 23 February 2012 10:08, David C. Rankin drankinatty@suddenlinkmail.com wrote:
On 02/23/2012 08:19 AM, Calvin Morrison wrote:
bigger_title_icons_in_kcontrol.patch - changes the hardcoded size of icons from 22 to 48 - not sure what value it adds, or if really needs to be changes.
I HATE bit icons :) I say we kill this one.
-- David C. Rankin, J.D.,P.E.
better - it should just follow the default toolbar icons size as set in appearance -> icons
Calvin
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
On 23 February 2012 10:22, David C. Rankin drankinatty@suddenlinkmail.com wrote:
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
-- David C. Rankin, J.D.,P.E.
you can with sometimes avoid a rebuild, say you just need to bump a version number or add a depend
--noextract basically won't delete src/ and that should let the build files remain.
Calvin
On 02/23/2012 10:26 AM, Calvin Morrison wrote:
On 23 February 2012 10:22, David C. Rankin drankinatty@suddenlinkmail.com wrote:
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
-- David C. Rankin, J.D.,P.E.
you can with sometimes avoid a rebuild, say you just need to bump a version number or add a depend
--noextract basically won't delete src/ and that should let the build files remain.
No not easily when using a chroot. makechrootpkg -c -r cleans the environment every time.
If you are using a scripted systems which you should be then you have to alter the scripts which just is not worth doing, so one just reruns the scripts and waits.
On 02/23/2012 09:44 AM, Baho Utot wrote:
On 02/23/2012 10:26 AM, Calvin Morrison wrote:
On 23 February 2012 10:22, David C. Rankin drankinatty@suddenlinkmail.com wrote:
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
-- David C. Rankin, J.D.,P.E.
you can with sometimes avoid a rebuild, say you just need to bump a version number or add a depend
--noextract basically won't delete src/ and that should let the build files remain.
Just like Baho says, when you are building in a chroot (which you must if your packages will be used by someone other than you), then there is no way to pass custom parameters to makepkg:
https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_Clean_Chroo...
No not easily when using a chroot. makechrootpkg -c -r cleans the environment every time.
I set up a chroot specifically for Trinity building and start with Qt3/TQt3 and progress using:
sudo makechrootpkg -r $CHROOT -u
or just
sudo makechrootpkg -r $CHROOT (to avoid the pacman -Syu call)
then manually install the packages:
sudo makechrootpkg -r $CHROOT -I tde-package.tar.xz
then I manually copy the file to the $CHROOT/root/repo and do a repo-add to update the repo.
If something significant changes in a package, then I rebuild the effected package and start again with a fresh cleaned $CHROOT and rebuild from that point on with the [local] repo providing all the dependencies needed.
If you are using a scripted systems which you should be then you have to alter the scripts which just is not worth doing, so one just reruns the scripts and waits.
Yup!
But FINALLY!!!
==> Finished making: trinity-tdebase 3513-7 (Thu Feb 23 15:45:42 UTC 2012)
The pkgbuild source package is here:
http://www.3111skyline.com/dl/dt/trinity/arch/src/trinity-tdebase.tar.gz
On 02/23/2012 11:30 AM, David C. Rankin wrote:
On 02/23/2012 09:44 AM, Baho Utot wrote:
On 02/23/2012 10:26 AM, Calvin Morrison wrote:
On 23 February 2012 10:22, David C. Rankin drankinatty@suddenlinkmail.com wrote:
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
-- David C. Rankin, J.D.,P.E.
you can with sometimes avoid a rebuild, say you just need to bump a version number or add a depend
--noextract basically won't delete src/ and that should let the build files remain.
Just like Baho says, when you are building in a chroot (which you must if your packages will be used by someone other than you), then there is no way to pass custom parameters to makepkg:
https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_Clean_Chroo...
No not easily when using a chroot. makechrootpkg -c -r cleans the environment every time.
I set up a chroot specifically for Trinity building and start with Qt3/TQt3 and progress using:
sudo makechrootpkg -r $CHROOT -u
or just
sudo makechrootpkg -r $CHROOT (to avoid the pacman -Syu call)
then manually install the packages:
sudo makechrootpkg -r $CHROOT -I tde-package.tar.xz
you should also pass the -c option to makechrootpkg so that the devtools clean the chroot for every package. That way you can not get unintended dependencies.
This may be of some value to you then ( from my build scripts)
_chroot="/home/chroot" _path=${0%/*} # fetch directory name = module name _repos="/home/chroot/root/repo"
cd ${_path} rm build.log namcap.log filelist.log || true # update chroot and build package echo "Building---> ${_path}" ( sudo /usr/sbin/mkarchroot -u ${_chroot}/root |& tee build.log ) ( sudo /usr/sbin/makechrootpkg -c -r ${_chroot} |& tee -a build.log ) # Namcap package _pkg=$(echo *.pkg.*) [ -f ${_pkg} ] || ( echo "Missing package: ${_pkgname}";exit 4 ) ( /usr/bin/namcap ${_pkg} |& tee namcap.log ) # Create list of files in package ( /bin/tar -tf ${_pkg} |& tee filelist.log ) # Me and my repo mv -vf ${_pkg} ${_repos} /usr/bin/repo-add ${_repos}/local.db.tar.gz ${_repos}/${_pkg} exit 0
then I manually copy the file to the $CHROOT/root/repo and do a repo-add to update the repo.
If something significant changes in a package, then I rebuild the effected package and start again with a fresh cleaned $CHROOT and rebuild from that point on with the [local] repo providing all the dependencies needed.
If you are using a scripted systems which you should be then you have to alter the scripts which just is not worth doing, so one just reruns the scripts and waits.
Yup!
But FINALLY!!!
==> Finished making: trinity-tdebase 3513-7 (Thu Feb 23 15:45:42 UTC 2012)
The pkgbuild source package is here:
http://www.3111skyline.com/dl/dt/trinity/arch/src/trinity-tdebase.tar.gz
I would drop the trinity part from above
tdebase-VERSION.tar.xz is good enough
On 02/23/2012 10:22 AM, David C. Rankin wrote:
On 02/23/2012 09:11 AM, Calvin Morrison wrote:
better - it should just follow the default toolbar icons size as set in appearance -> icons
I removed it and updated the md5sum for patches.tar.bz2 and I've kicked off the build again. That is the WORST shortcoming of building in an archroot with an out-of-source build!
But building in a chroot is what is required. Many positive benefits come from that for but a little pain.
Teachs one to do it right/correct the first time ;)
You can't simply issue a 'makepkg -R'. Suck having to rebuild the whole tdebase package for a packaging issue after the source is 100% complete!
Oh well - 9% and kicking...
Well now you have time to go get a coffee don't you.
See it does have its benefit.
On Thu, Feb 23, 2012 at 3:19 PM, Calvin Morrison mutantturkey@gmail.com wrote:
Archers - Tim, I am reviewing these patches now.
dbusfix.patch - is a arch specific compiler fix. It is hardcoded and should not be sent upstream. Don't merge.
kicker-lockout.patch - this is kind of silly, it allows you to either switch the spot of either Lock or Logout. It doesn't seem entirely useful. Especially not if I can push my changes for kickers logout before R14. I know extra configuration is good - but this seems to be manual solution. I think it would be better to have these items operate as regular entries, that way users could move/add/remove them as pleased. I wouldn't merge
doc_location.patch - is a fix for cmake's HTML_INSTALL_DIR. changes the destination from /doc/kde/HTML to /doc/HTML. Maybe this should be /doc/tde/HTML? either way I would merge it.
kcontrol_advbg_step.patch - "this patch modifies the step of refresh time in advanced background settings of kcontrol step instead of being 5 is 1, the maximal value of refresh time is incremented too." - I am not sure this makes anything better or worse. I haven't had any problems with kcontrol's background. Pawel?
This is for dynamic desktop controlled by kwebdesktop and so on. Let's say you want this to be refreshed every minute, without this patch you can't since the step is set to 5. Same if you want to refresh it every 12mins, you can't. As the maximal vaule, it should be increased, since it seems to low for me (don't remember how much tho atm). This isn't making anything worse or better, it allows more flexibility in the configuration. Me thinks it should be sent upstream.
nsplugincontainer-xdgcomplaince.patch - Apparently makes this xdg compliant. I need someone to review this as well.
bigger_title_icons_in_kcontrol.patch - changes the hardcoded size of icons from 22 to 48 - not sure what value it adds, or if really needs to be changes.
To unsubscribe, e-mail: trinity-devel-unsubscribe@lists.pearsoncomputing.net For additional commands, e-mail: trinity-devel-help@lists.pearsoncomputing.net Read list messages on the web archive: http://trinity-devel.pearsoncomputing.net/ Please remember not to top-post: http://trinity.pearsoncomputing.net/mailing_lists/#top-posting
-
Baho Utot -
Calvin Morrison -
Darrell Anderson -
David C. Rankin -
Pawel Soltys