The new "patches from GIT" page looks good and so does the search field at the bottom. Anyhow IMO there are still a few things to fix:
1) email addresses are shown in full, which is not that good being a page available without any login. It would be advisable to remove them, both from the committer column and the Log message column (for signed-off commits).
2) I believe the correct name of the committer column should be "Author"
3) The page still displays with problems if the width of the browser window is small enough (the blue left side menu overlaps the page contents)
4) The search field would probably be better if it was at the top, since it does not take up much page space. At the moment we need to scroll the whole page if we want to search for a particular commit
5) the 'page navigation' (the one saying 'Now viewing patches...') would be better if it had links to the next and previous adjacent pages as in most search engines (something like [1], [2], [3], .... to make it clear)
6) IMO, the name "Patches from GIT" is misleading for new users, as I already said in a previous email. Would be better to call it "GIT Commits" or "Commit history" or something with "commit" in it
Hope this is useful. Cheers Michele
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
The new "patches from GIT" page looks good and so does the search field at the bottom. Anyhow IMO there are still a few things to fix:
- email addresses are shown in full, which is not that good being a
page available without any login. It would be advisable to remove them, both from the committer column and the Log message column (for signed-off commits).
While I don't fully agree with this (e.g. anyone can go to CGIT via the "View" link and see all the Email addresses there, or even download the repositories via GIT and retrieve all the Email addresses automatically from that local copy) the Email addresses were wasting valuable space so I went ahead and removed them. Publicly-known Email addresses are one of the hazards of contributing to open source. ;-)
- I believe the correct name of the committer column should be "Author"
Fixed.
- The page still displays with problems if the width of the browser
window is small enough (the blue left side menu overlaps the page contents)
Not sure I can do anything about this; E. Liddell would have to comment.
- The search field would probably be better if it was at the top, since
it does not take up much page space. At the moment we need to scroll the whole page if we want to search for a particular commit
Reworked.
- the 'page navigation' (the one saying 'Now viewing patches...') would
be better if it had links to the next and previous adjacent pages as in most search engines (something like [1], [2], [3], .... to make it clear)
I reworked the navigation system; is it more functional now?
- IMO, the name "Patches from GIT" is misleading for new users, as I
already said in a previous email. Would be better to call it "GIT Commits" or "Commit history" or something with "commit" in it
Opinions from the list are welcome here. I will probably go with "Commit History" if no one else has a better suggestion.
Hope this is useful. Cheers Michele
Yes, thanks!
Tim
On Sun, 26 Oct 2014 16:58:04 -0500 "Timothy Pearson" kb9vqf@pearsoncomputing.net wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
The new "patches from GIT" page looks good and so does the search field at the bottom. Anyhow IMO there are still a few things to fix:
[...]
- The page still displays with problems if the width of the browser
window is small enough (the blue left side menu overlaps the page contents)
Not sure I can do anything about this; E. Liddell would have to comment.
It's Complicated. For webdev, adding padding-left:170px; to the CSS style for .patchtable should help. For the page as currently deployed, there is no fix that doesn't break centering, not that I've been able to find. Then again, I can scale that page down to below 800x600 without problems occurring--it kind of depends on your font.
The navigation will need to be enclosed in a div so that it can get similar treatment--I'll tinker with it tomorrow if I have time.
(If we were keeping the original design, I'd want to rebuild that page to have a different internal setup from the others; under the circumstances, I don't think it's necessary.)
E. Liddell
On 2014/10/27 06:58 AM, Timothy Pearson wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
The new "patches from GIT" page looks good and so does the search field at the bottom. Anyhow IMO there are still a few things to fix:
- email addresses are shown in full, which is not that good being a
page available without any login. It would be advisable to remove them, both from the committer column and the Log message column (for signed-off commits).
While I don't fully agree with this (e.g. anyone can go to CGIT via the "View" link and see all the Email addresses there, or even download the repositories via GIT and retrieve all the Email addresses automatically from that local copy) the Email addresses were wasting valuable space so I went ahead and removed them. Publicly-known Email addresses are one of the hazards of contributing to open source. ;-)
- I believe the correct name of the committer column should be "Author"
Fixed.
- The page still displays with problems if the width of the browser
window is small enough (the blue left side menu overlaps the page contents)
Not sure I can do anything about this; E. Liddell would have to comment.
- The search field would probably be better if it was at the top, since
it does not take up much page space. At the moment we need to scroll the whole page if we want to search for a particular commit
Reworked.
- the 'page navigation' (the one saying 'Now viewing patches...') would
be better if it had links to the next and previous adjacent pages as in most search engines (something like [1], [2], [3], .... to make it clear)
I reworked the navigation system; is it more functional now?
- IMO, the name "Patches from GIT" is misleading for new users, as I
already said in a previous email. Would be better to call it "GIT Commits" or "Commit history" or something with "commit" in it
Opinions from the list are welcome here. I will probably go with "Commit History" if no one else has a better suggestion.
Hope this is useful. Cheers Michele
Tim, good work, thanks! Just one thing I think we could improve: the links to [First Page] [Previous Page] [Next Page] [Last Page] could be either moved or duplicated at the top of the page. If a user wants to quickly scroll pages, at this time he has to scroll at the end of each page (or alternatively modify the address manually). What do you think?
"Commit history" sounds good.
Cheers Michel
PS: by the way I am edging closer to complete bug 1859 (free time is again a rarity these days). I should be able to get it done by this week.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On 2014/10/27 06:58 AM, Timothy Pearson wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
The new "patches from GIT" page looks good and so does the search field at the bottom. Anyhow IMO there are still a few things to fix:
- email addresses are shown in full, which is not that good being a
page available without any login. It would be advisable to remove them, both from the committer column and the Log message column (for signed-off commits).
While I don't fully agree with this (e.g. anyone can go to CGIT via the "View" link and see all the Email addresses there, or even download the repositories via GIT and retrieve all the Email addresses automatically from that local copy) the Email addresses were wasting valuable space so I went ahead and removed them. Publicly-known Email addresses are one of the hazards of contributing to open source. ;-)
- I believe the correct name of the committer column should be
"Author"
Fixed.
- The page still displays with problems if the width of the browser
window is small enough (the blue left side menu overlaps the page contents)
Not sure I can do anything about this; E. Liddell would have to comment.
- The search field would probably be better if it was at the top,
since it does not take up much page space. At the moment we need to scroll the whole page if we want to search for a particular commit
Reworked.
- the 'page navigation' (the one saying 'Now viewing patches...')
would be better if it had links to the next and previous adjacent pages as in most search engines (something like [1], [2], [3], .... to make it clear)
I reworked the navigation system; is it more functional now?
- IMO, the name "Patches from GIT" is misleading for new users, as I
already said in a previous email. Would be better to call it "GIT Commits" or "Commit history" or something with "commit" in it
Opinions from the list are welcome here. I will probably go with "Commit History" if no one else has a better suggestion.
Hope this is useful. Cheers Michele
Tim, good work, thanks! Just one thing I think we could improve: the links to [First Page] [Previous Page] [Next Page] [Last Page] could be either moved or duplicated at the top of the page. If a user wants to quickly scroll pages, at this time he has to scroll at the end of each page (or alternatively modify the address manually). What do you think?
I had thought of this yesterday but didn't have time to refactor the code just then. Fixed. :-)
"Commit history" sounds good.
Fixed.
Thanks for your input!
Tim
<snip>
Tim, good work, thanks! Just one thing I think we could improve: the links to [First Page] [Previous Page] [Next Page] [Last Page] could be either moved or duplicated at the top of the page. If a user wants to quickly scroll pages, at this time he has to scroll at the end of each page (or alternatively modify the address manually). What do you think?
I had thought of this yesterday but didn't have time to refactor the code just then. Fixed. :-)
"Commit history" sounds good.
Fixed.
Thanks for your input!
Thanks again Tim. Another thing I thought about this morning is that only the commits from the main repo are shown on the page. Now the links refer to cgit directly and do not require so much disk space (if my understanding is correct), so perhaps we could also list the commits from the packaging repo. Or create different pages for main repo, packaging repo, uLAb.
What do you think?
Cheers Michele
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
<snip> >> >> Tim, good work, thanks! >> Just one thing I think we could improve: the links to [First Page] >> [Previous Page] [Next Page] [Last Page] could be either moved or >> duplicated at the top of the page. If a user wants to quickly scroll >> pages, at this time he has to scroll at the end of each page (or >> alternatively modify the address manually). What do you think? > > I had thought of this yesterday but didn't have time to refactor the > code > just then. Fixed. :-) > >> "Commit history" sounds good. > > Fixed. > > Thanks for your input! >
Thanks again Tim. Another thing I thought about this morning is that only the commits from the main repo are shown on the page. Now the links refer to cgit directly and do not require so much disk space (if my understanding is correct), so perhaps we could also list the commits from the packaging repo. Or create different pages for main repo, packaging repo, uLAb.
What do you think?
Cheers Michele
Yeah I'd thought of that years ago when I designed the system; there is no technical reason I can't but I didn't do so back then as I suspected it would clutter up the page and make it needlessly hard to use. I don't think this has changed; for the packaging and repositories cgit has very nice summaries and logs: https://git.trinitydesktop.org/cgit/tde-packaging/ https://git.trinitydesktop.org/cgit/ulab/
In comparison this is what the main repository shows up as in cgit (i.e. the fundamental reason why the patches page has to exist at all): https://git.trinitydesktop.org/cgit/tde/
Would it help to add links to the other two repositories to the sidebar navigation on the main site, and possibly rename "Commit History" to "Source Commit History" then add "Packaging Commit History" etc.?
Tim
On 10/30/2014 06:19 AM, Timothy Pearson wrote:
Yeah I'd thought of that years ago when I designed the system; there is no technical reason I can't but I didn't do so back then as I suspected it would clutter up the page and make it needlessly hard to use. I don't think this has changed; for the packaging and repositories cgit has very nice summaries and logs: https://git.trinitydesktop.org/cgit/tde-packaging/ https://git.trinitydesktop.org/cgit/ulab/
In comparison this is what the main repository shows up as in cgit (i.e. the fundamental reason why the patches page has to exist at all): https://git.trinitydesktop.org/cgit/tde/
Would it help to add links to the other two repositories to the sidebar navigation on the main site, and possibly rename "Commit History" to "Source Commit History" then add "Packaging Commit History" etc.?
I think that would be good enough. I usually check git logs directly from a console when I am using TDE on my computer, but occasionally I am on someone else's computer, so a link from them main page menu bar will do :-)
Thanks again. Cheers Michele
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On 10/30/2014 06:19 AM, Timothy Pearson wrote:
Yeah I'd thought of that years ago when I designed the system; there is no technical reason I can't but I didn't do so back then as I suspected it would clutter up the page and make it needlessly hard to use. I don't think this has changed; for the packaging and repositories cgit has very nice summaries and logs: https://git.trinitydesktop.org/cgit/tde-packaging/ https://git.trinitydesktop.org/cgit/ulab/
In comparison this is what the main repository shows up as in cgit (i.e. the fundamental reason why the patches page has to exist at all): https://git.trinitydesktop.org/cgit/tde/
Would it help to add links to the other two repositories to the sidebar navigation on the main site, and possibly rename "Commit History" to "Source Commit History" then add "Packaging Commit History" etc.?
I think that would be good enough. I usually check git logs directly from a console when I am using TDE on my computer, but occasionally I am on someone else's computer, so a link from them main page menu bar will do :-)
Thanks again. Cheers Michele
Updated. I couldn't change the headers to my suggestions as they ended up being too wide, but I think the current names are descriptive enough.
Tim
-
E. Liddell -
Michele Calgaro -
Timothy Pearson