New package set built today. The klipper icon is gone. The space occupied by the icon in the system tray is being used and I can click the empty to open the klipper menu. Klipper is running. Just no icon is displayed. I tried different icon sets and a fresh profile. No icon. Probably related to commit 745063fa.
New package set built today. The klipper icon is gone. The space occupied by the icon in the system tray is being used and I can click the empty to open the klipper menu. Klipper is running. Just no icon is displayed. I tried different icon sets and a fresh profile. No icon. Probably related to commit 745063fa.
Confirmed! Darrell, please open a bug report. This will have to be added to v14.0.0 bug list: not a major loss of functionality, but it doesn't look good and the klipper icon is on any taskbar I have seen in my life.
Cheers Michele
On Sunday 13 of July 2014 14:37:28 Michele Calgaro wrote:
New package set built today. The klipper icon is gone. The space occupied by the icon in the system tray is being used and I can click the empty to open the klipper menu. Klipper is running. Just no icon is displayed. I tried different icon sets and a fresh profile. No icon. Probably related to commit 745063fa.
Confirmed! Darrell, please open a bug report. This will have to be added to v14.0.0 bug list: not a major loss of functionality, but it doesn't look good and the klipper icon is on any taskbar I have seen in my life.
Cheers Michele
As I discovered, the icon with corresponding size is loaded and scaled in paintEvent method. This method draws only m_scaledpixmap, not initially loaded m_pixmap. When m_iconOrigWidth and m_iconOrigHeight was set to the correct values, icon is not loaded and scaled in paintEvent => m_scaledpixmap remained empty => was drawn a blank icon.
Fixed in commit 1574938e.
On Sun July 13 2014 11:52:20 am Slávek Banko wrote:
As I discovered, the icon with corresponding size is loaded and scaled in paintEvent method. This method draws only m_scaledpixmap, not initially loaded m_pixmap. When m_iconOrigWidth and m_iconOrigHeight was set to the correct values, icon is not loaded and scaled in paintEvent => m_scaledpixmap remained empty => was drawn a blank icon.
Fixed in commit 1574938e.
Fix confirmed. Thank you.
Darrell
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
New package set built today. The klipper icon is gone. The space occupied by the icon in the system tray is being used and I can click the empty to open the klipper menu. Klipper is running. Just no icon is displayed. I tried different icon sets and a fresh profile. No icon. Probably related to commit 745063fa.
Can you test a build with that commit reverted to see if functionality is restored? All that commit did was fall back on the default icon size if the tray icon is not yet visible; it *should* not have been able to completely break the tray icon visibility.
Thanks!
Tim
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
New package set built today. The klipper icon is gone. The space occupied by the icon in the system tray is being used and I can click the empty to open the klipper menu. Klipper is running. Just no icon is displayed. I tried different icon sets and a fresh profile. No icon. Probably related to commit 745063fa.
Can you test a build with that commit reverted to see if functionality is restored? All that commit did was fall back on the default icon size if the tray icon is not yet visible; it *should* not have been able to completely break the tray icon visibility.
Thanks!
Tim
Never mind, just saw Slavek's response. Thanks Slavek for the fast patch!
Tim
-
Darrell -
Michele Calgaro -
Slávek Banko -
Timothy Pearson