Tim,
looking at the recent changes in the tde-packaging I see several varieties of adverse renaming. For example:
-debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.la -debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.so -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.la -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.so +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.la +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.so +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.la +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.so
...and many other chalk* => chaltde*
-debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tasklist.ktf -debian/tmp/opt/trinity/share/apps/kplato/reports/tasklist.desktop +debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tastdelist.ktf +debian/tmp/opt/trinity/share/apps/kplato/reports/tastdelist.desktop
-debian/tmp/opt/trinity/include/tdeparts/dockmainwindow.h +debian/tmp/opt/trinity/include/tdeparts/doctdemainwindow.h
-debian/tmp/opt/trinity/include/tdetexteditor/blockselectioninterface.h +debian/tmp/opt/trinity/include/tdetexteditor/bloctdeselectioninterface.h
-debian/tmp/opt/trinity/include/kopete/ui/addressbookselectordialog.h -debian/tmp/opt/trinity/include/kopete/ui/addressbookselectorwidget.h +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectordialog.h +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectorwidget.h
In addition, some partial repairs but also other adverse renaming:
---- kiosktool/tdeiosktool/tdeioskrun.cpp 2005-04-25 10:46:33.000000000 +0100 -+++ kiosktool/tdeiosktool/tdeioskrun.cpp 2007-07-20 16:56:07.000000000 +0100 +--- kiosktool/kiosktool/tdeioskrun.cpp 2005-04-25 10:46:33.000000000 +0100 ++++ kiosktool/kiosktool/tdeioskrun.cpp 2007-07-20 16:56:07.000000000 +0100
-+ return "Error in Kiosktool Kubuntu modifications"; ++ return "Error in Kiostdetool Kubuntu modifications";
These are just some examples, which I happened to notice. I'm afraid that it will take a lot of eyes, to reveal all the adverse renaming. I think it is right to make this great renaming before release final R14, but I believe that the recently proposed date for release final R14 need to be revisited.
Slavek --
Tim,
looking at the recent changes in the tde-packaging I see several varieties of adverse renaming. For example:
-debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.la -debian/tmp/opt/trinity/lib/trinity/chalkselectiontools.so -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.la -debian/tmp/opt/trinity/lib/trinity/chalkselectopaque.so +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.la +debian/tmp/opt/trinity/lib/trinity/chaltdeselectiontools.so +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.la +debian/tmp/opt/trinity/lib/trinity/chaltdeselectopaque.so
...and many other chalk* => chaltde*
-debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tasklist.ktf -debian/tmp/opt/trinity/share/apps/kplato/reports/tasklist.desktop +debian/tmp/opt/trinity/share/apps/kplato/reports/.source/tastdelist.ktf +debian/tmp/opt/trinity/share/apps/kplato/reports/tastdelist.desktop
-debian/tmp/opt/trinity/include/tdeparts/dockmainwindow.h +debian/tmp/opt/trinity/include/tdeparts/doctdemainwindow.h
-debian/tmp/opt/trinity/include/tdetexteditor/blockselectioninterface.h +debian/tmp/opt/trinity/include/tdetexteditor/bloctdeselectioninterface.h
-debian/tmp/opt/trinity/include/kopete/ui/addressbookselectordialog.h -debian/tmp/opt/trinity/include/kopete/ui/addressbookselectorwidget.h +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectordialog.h +debian/tmp/opt/trinity/include/kopete/ui/addressbootdeselectorwidget.h
In addition, some partial repairs but also other adverse renaming:
---- kiosktool/tdeiosktool/tdeioskrun.cpp 2005-04-25 10:46:33.000000000 +0100 -+++ kiosktool/tdeiosktool/tdeioskrun.cpp 2007-07-20 16:56:07.000000000 +0100 +--- kiosktool/kiosktool/tdeioskrun.cpp 2005-04-25 10:46:33.000000000 +0100 ++++ kiosktool/kiosktool/tdeioskrun.cpp 2007-07-20 16:56:07.000000000 +0100
-+ return "Error in Kiosktool Kubuntu modifications"; ++ return "Error in Kiostdetool Kubuntu modifications";
These are just some examples, which I happened to notice. I'm afraid that it will take a lot of eyes, to reveal all the adverse renaming. I think it is right to make this great renaming before release final R14, but I believe that the recently proposed date for release final R14 need to be revisited.
Slavek
Yes, the R14 release will probably need to be pushed back. This renaming effort will end up being a multi-stage process with pauses to search for problems such as the ones you noticed already.
So if I have this correct, you have noticed the following invalid strings: chaltde tastdelist doctdemain loctdeselect bootdeselect tdeiosk Kiostde
I have already noticed and corrected several of these, but you also spotted some that I did not see at first.
Most of the problems are caused by the fact that the KDE developers prefixed most libraries and header file names, not to mention application names, with a single letter 'k'. In hindsight, this practice makes any renaming projects much more difficult than if a multiple character unique prefix such as 'kde' was used instead, not to mention increasing the chances of collision with existing libraries outside of KDE (e.g. a hypothetical Kerberos interface library might try to add a 'k' prefix to its class names through the same logic). I am consistently replacing all K class prefixes with TDE to mitigate this problem, however as you noticed this process is quite error prone.
Tim
Dne so 2. února 2013 Timothy Pearson napsal(a):
So if I have this correct, you have noticed the following invalid strings: chaltde tastdelist doctdemain loctdeselect bootdeselect tdeiosk Kiostde
During the preparation of patch to add support for network configuration on newer Debian and Ubuntu, I happened to notice other adverse rename:
tdeadmin - knetwortdeconf
Slavek --
Dne so 2. února 2013 Timothy Pearson napsal(a):
So if I have this correct, you have noticed the following invalid strings: chaltde tastdelist doctdemain loctdeselect bootdeselect tdeiosk Kiostde
During the preparation of patch to add support for network configuration on newer Debian and Ubuntu, I happened to notice other adverse rename:
tdeadmin - knetwortdeconf
Slavek
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
On Wednesday 06 of February 2013 18:49:09 Timothy Pearson wrote:
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Hi Tim,
By chance, I noticed another adverse renaming - qt3 commit d3e87ed4, tqt3 commit b283cf86 - LOCTDEFILE. Unfortunately now I can not search the entire GIT tree for other similar occurrences.
Slavek --
On Wednesday 13 of February 2013 02:41:13 Slávek Banko wrote:
On Wednesday 06 of February 2013 18:49:09 Timothy Pearson wrote:
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Hi Tim,
By chance, I noticed another adverse renaming - qt3 commit d3e87ed4, tqt3 commit b283cf86 - LOCTDEFILE. Unfortunately now I can not search the entire GIT tree for other similar occurrences.
Slavek
Since I already have the current GIT tree for the master branch, fix renaming LOCTDEFILE => LOCKFILE I made myself. Except experimental GIT module to which I do not have write permissions.
Slavek --
On Wednesday 06 of February 2013 18:49:09 Timothy Pearson wrote:
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Hi Tim,
I noticed another unwanted renaming - tdeutils / kdf : disklist* => distdelist*.
Slavek --
On Wednesday 06 of February 2013 18:49:09 Timothy Pearson wrote:
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Hi Tim,
I noticed another unwanted renaming - tdeutils / kdf : disklist* => distdelist*.
Slavek
Should be fixed now; thanks for the heads up!
Tim
Dne st 6. února 2013 Timothy Pearson napsal(a):
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Tim,
as you probably noticed, I try to find and fix unwanted renaming k => tde. During this time I discovered that I do not have write access to git repositories experimental and libart-lgpl. In these modules, because I could not perform fixes.
How about it?
Slavek --
Dne st 6. února 2013 Timothy Pearson napsal(a):
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Tim,
as you probably noticed, I try to find and fix unwanted renaming k => tde. During this time I discovered that I do not have write access to git repositories experimental and libart-lgpl. In these modules, because I could not perform fixes.
How about it?
Slavek
You should now have access. Thanks for working on the cleanup!
Tim
On Wednesday 20 of February 2013 00:07:12 Timothy Pearson wrote:
Dne st 6. února 2013 Timothy Pearson napsal(a):
Fixed in GIT.
I have uploaded all of the renames recently applied to an Etherpad: http://trinity.etherpad.trinitydesktop.org/62
If you see anything else amiss, please let me know ASAP!
Thanks!
Tim
Tim,
as you probably noticed, I try to find and fix unwanted renaming k => tde. During this time I discovered that I do not have write access to git repositories experimental and libart-lgpl. In these modules, because I could not perform fixes.
How about it?
Slavek
You should now have access. Thanks for working on the cleanup!
Tim
Thank you, commits successfully pushed to both.
The cleaning I will continue - I still have a lot of lines to check. However, in my timezone is already a later hour, and I guess I'll go to bed early...
Slavek --