7 Sep
2013
7 Sep
'13
6:20 a.m.
Additional xsession-error log messages that might be related to the
recent renaming (or they might be isolated bugs):
* tdeio (KIOConnection): ERROR: Header read failed, errno=104
* tdeio (KIOConnection): ERROR: Header has invalid size (-1)
* tdeio (KIOConnection): ERROR: Could not write data
* tdeio (TDELauncher): ERROR: SlavePool: No communication with
slave.
* tdecore (TDEProcess): WARNING: _attachPty() 17
* tdecore (TDEProcess): WARNING: _attachPty() 13
* tdesu: WARNING: unknown super user command
For consistency, should KIOConnection be renamed to
TDEIOConnection? Looks like tdelibs is the only affected module,
although there are some remaining remnant "KIO" usages in tdelibs,
tdepim, tdenetwork, tdebase, tdevelop, tdesdk, tde-i18n, kshowmail,
krusader, kdirstat, tdeio-apt, tork, digikam.
Darrell
7 Sep
7 Sep
7:47 a.m.
New subject: [trinity-devel] (More) Possible bugs introduced from latest k->tde patches
2013/9/7 Darrell Anderson <darrella(a)hushmail.com>
Additional xsession-error log messages that might be
related to the
recent renaming (or they might be isolated bugs):
* tdeio (KIOConnection): ERROR: Header read failed, errno=104
* tdeio (KIOConnection): ERROR: Header has invalid size (-1)
* tdeio (KIOConnection): ERROR: Could not write data
* tdeio (TDELauncher): ERROR: SlavePool: No communication with
slave.
* tdecore (TDEProcess): WARNING: _attachPty() 17
* tdecore (TDEProcess): WARNING: _attachPty() 13
* tdesu: WARNING: unknown super user command
For consistency, should KIOConnection be renamed to
TDEIOConnection? Looks like tdelibs is the only affected module,
although there are some remaining remnant "KIO" usages in tdelibs,
tdepim, tdenetwork, tdebase, tdevelop, tdesdk, tde-i18n, kshowmail,
krusader, kdirstat, tdeio-apt, tork, digikam.
Darrell
Those errors aren't supposed to be something new or related with
renaming...
Before patch git hash 5354555 all messages passed to kd{Error,Warning} have
gone nowhere but now they go to stderr by default.
So, these is old errors, but previously masked.
12:37 p.m.
New subject: [trinity-devel] (More) Possible bugs introduced from latest k->tde patches
On Saturday 07 of September 2013 08:20:12 Darrell Anderson wrote:
* tdesu: WARNING: unknown super user command
Test the super user command is a one tdelibs/tdesu/su.cpp a second time in
tdebase/tdesu/sudlg.spp. Valid is considered "sudo" or "su".
For tdebase is in tdebase/tdesu/CMakeLists.txt defined:
if( WITH_SUDO_TDESU_BACKEND )
set( DEFAULT_SUPER_USER_COMMAND sudo CACHE INTERNAL "" FORCE )
else()
set( DEFAULT_SUPER_USER_COMMAND su CACHE INTERNAL "" FORCE )
endif()
For tdelibs is in tdelibs/CMakeLists.txt defined:
# FIXME for unknown reason cmake cannot find su
#find_program( __PATH_SU su )
set( __PATH_SU "/bin/su" )
if( __PATH_SU )
set( DEFAULT_SUPER_USER_COMMAND ${__PATH_SU} )
else( __PATH_SU )
message( STATUS "WARNING: su was not found" )
endif( __PATH_SU )
# FIXME for unknown reason cmake cannot find sudo
# find_program( __PATH_SUDO "sudo" )
set( __PATH_SUDO "/usr/bin/sudo" )
if( WITH_SUDO_TDESU_BACKEND )
if( __PATH_SUDO )
set( DEFAULT_SUPER_USER_COMMAND ${__PATH_SUDO} )
else( __PATH_SUDO )
message( FATAL_ERROR "sudo was chosen as tdesu backend, but was not found
in path." )
endif( __PATH_SUDO )
endif( WITH_SUDO_TDESU_BACKEND )
In neither case does not test for the presence sudo. And in tdelibs instead of
setting DEFAULT_SUPER_USER_COMMAND to su or sudo is used full path to binary,
which is incorrect.
Proposed patches attached.
Slavek
--
3896
days inactive
3896
days old
2 comments
3 participants
participants (3)
-
Darrell Anderson -
Fat-Zer -
Slávek Banko