On 04/04/2012 11:35 PM, David C. Rankin wrote: I went ahead and opened http://bugs.pearsoncomputing.net/bugzilla/show_bug.cgi?id=957 to give us a page to capture the kipi-plugins issues on. -- David C. Rankin, J.D.,P.E.

On 04/05/2012 10:59 AM, Darrell Anderson wrote: Hmm - that makes two of us. Nothing makes sense right now :( I see that the changes only affected the lines around 'TQListViewItemIterator it' and not the iterator itself. Grepping it looks like the gpssyncdialog.cpp and imageslist.cpp both contain the same declaration, but if it is limited to file scope that shouldn't matter: 12:55 archangel:/dat_e/chroot/david/build/src/kipi-plugins> grep -r 'TQListViewItemIterator it' * kipi-plugins/kameraklient/camerafolderview.cpp: TQListViewItemIterator it(this); kipi-plugins/kameraklient/setupcamera.cpp: TQListViewItemIterator it(listView_); kipi-plugins/ipodexport/ipodexportdialog.cpp: TQListViewItemIterator it2( m_uploadList ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it( d->listView ); kipi-plugins/gpssync/gpssyncdialog.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/rawconverter/batchdialog.cpp: TQListViewItemIterator it( m_listView ); kipi-plugins/rawconverter/batchdialog.cpp: TQListViewItemIterator it( m_listView ); kipi-plugins/batchprocessimages/batchprocessimagesdialog.cpp: TQListViewItemIterator it2( m_listFiles ); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); kipi-plugins/flickrexport/imageslist.cpp: TQListViewItemIterator it(d->listView); But when it gets to the imagelist.cpp build, gcc is complaining that it has 2 declarations for 'TQListViewItemIterator it'??? libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. -I/opt/trinity/include -I/opt/trinity/include -I../../kipi-plugins/common/include -I/opt/trinity/include -I/opt/trinity/include -I/opt/tqt3/include -I. -include tqt.h -I/opt/trinity/include/tde -DQT_THREAD_SUPPORT -D_REENTRANT -Wno-long-long -Wundef -ansi -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -fno-builtin -g3 -fno-inline -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4 -D_FORTIFY_SOURCE=2 -fpermissive -fpermissive -Wformat-security -Wmissing-format-attribute -Wno-non-virtual-dtor -fno-exceptions -fno-check-new -fno-common -I/usr/include/tqt -DQT_CLEAN_NAMESPACE -DQT_NO_ASCII_CAST -DQT_NO_STL -DQT_NO_COMPAT -DQT_NO_TRANSLATION -MT imageslist.lo -MD -MP -MF .deps/imageslist.Tpo -c imageslist.cpp -fPIC -DPIC -o .libs/imageslist.o In file included from /opt/trinity/include/kfileitem.h:31:0, from /opt/trinity/include/kio/previewjob.h:27, from imageslist.cpp:42: /opt/trinity/include/kfilemetainfo.h:1237:34: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] imageslist.cpp: In member function 'void KIPIFlickrExportPlugin::ImagesList::slotAddImages(const KURL::List&)': imageslist.cpp:231:35: error: redeclaration of 'TQListViewItemIterator it' imageslist.cpp:223:36: error: 'TQValueList<KURL>::const_iterator it' previously declared here I think your patch is in the clear, it looks like this will be another gcc 4.7 present... -- David C. Rankin, J.D.,P.E.

On 04/05/2012 01:39 PM, Darrell Anderson wrote: I 'think' it is this: -> G++ now correctly implements the two-phase lookup rules such that an unqualified name used in a template must have: (1) an appropriate declaration found either in scope at the point of definition of the template; or (2) by argument-dependent lookup at the point of instantiation. The question is if you have (1) & (2) instead of (1) | (2) do you get this redeclaration error?? -- David C. Rankin, J.D.,P.E.

I won't say for sure, but in commit 21705d1b 2012-04-05 where I cleaned some typos, that effort inadvertently created two identical declarations. The code never failed previously because the typos actually caused two different declarations, one of which was no longer being used. The remaining declaration one was abandoned in place, so to speak, but caused no harm. My typo scrubbing caused the two declarations to become identical. I had to fix that in commit 63df5ccd 2012-04-06. Point being? Let the gurus decide but I think only one of the five declarations is being duplicated, but perhaps the solution is as simple as deleting the explicit declaration in function slotAddImages. Darrell

I think I see the problem, but haven't recompiled to test if this idea resolves it for sure. It looks like for whatever reason gcc < 4.7 was't barfing when the new "it" object was created within the scope of the existing "it" object, which was created within the for loop definition. Thus, gcc's new behaviour is definitely correct. The easiest fix is to replace all instances of "TQListViewItemIterator it(d->listView);" with "TQListViewItemIterator it2(d->listView);" or similar. Tim

On 04/12/2012 11:03 PM, David C. Rankin wrote: Here is the question -- "Which 'it's to I change to (eg: it6) in the code: for(KURL::List::const_iterator it = list.begin(); it != list.end(); ++it) { KURL imageUrl = *it; // Check if the new item already exist in the list. bool find = false; -> TQListViewItemIterator it6(d->listView); -> while (it.current()) { -> ImagesListViewItem* item = dynamic_cast<ImagesListViewItem*>(*it); if (item->url() == imageUrl) find = true; -> ++it; // does this become '++it6;' } if (!find) { new ImagesListViewItem(d->listView, imageUrl); urls.append(imageUrl); } } How do I confirm that the 'it' I have marked with the sidebar '->' are the correct 'it's to change to 'it6' and not 'it's that should remain 'it's under the KURL::List construct?? -- David C. Rankin, J.D.,P.E.