Le 25/10/2012 20:21, Darrell Anderson a écrit : Adding comment is a good idea. While building TDE I also looked at CMakeLists.txt and sometimes I saw things like: "WITH_GADU: enables the gadu support" OK this is pretty straightforward, but, what exactly is "gadu" ? What TDE functionality will I lose if I build without it ? Some explanations about options would be appreciated. Francois

2012/10/26 Fat-Zer <fatzer2(a)gmail.com>

2012/10/27 Darrell Anderson <humanreadable(a)yahoo.com> I' ve noticed that but decided not to send the third letter in a raw... anyway it could be applied by passing -R option to patch... here is the normal one... + some fixes

2012/10/27 Darrell Anderson &lt;humanreadable(a)yahoo.com&gt; fixed fixed actualy it's a kioslave. changed to «kioslaves(thumbnail)» affects <nothing yet> when it will be pushed to git it supposed to be changed... but before that you shouldn't mislead anybody... also, here is a small patch to tdeartwork... generally there is nothing to describe. but for the tick...

2012/10/29 Darrell Anderson &lt;humanreadable(a)yahoo.com&gt; hm... I see... Tim has used different inclusion guards for that and defined them only in config.h.cmake... what's why I haven't noticed them... it seems to be a temporary solution, isn't it? I've added an «affections» but I can't handle the description now... cause I still don't understand how it works/what it uses etc. tdeartwork suggested change: not «how» but «which»... fixed... /thoughts aloud/ writing a documentation by a person who doesn't know english very well is not a really good idea...

Great! Suggested changes: adds support for t1lb -a library -> adds support for t1lb, a library loose -> lose this library is used only for set default parametrs -> this library sets default parameters planed -> planned but it wasn't implemented or was rejected -> but hasn't yet been ported A quick history of cmake in Trinity: The cmake ports are an ongoing process. There are additional packages where the cmake port was started but have not matured to a point of usability. All packages contains some rudiments of porting to cmake, but this is a long term process. One of our R14 goals is to complete the ports for some more packages. Note too that with each port the build process must be tested on different distros, toggling the options to test the results, etc. That is one reason we don't delete the automake files because they serve as a long-term reference for the cmake ports. Although the existing cmake ports are in good shape, not every single build option was ported. Mostly this is a result that the people porting the builds did not have access to those options. Thus we notice an occasional missing build option. Browse the bug tracker to notice where we have tagged some of those absences (for example, amarok). Thus in the example of the comment for kviewshell(plugins/djvu), a reasonable plan is to investigate the original automake build options. If the option was supported in automake but was not ported to cmake, then a bug report would be appropriate. If the option never was supported in automake, perhaps a bug report might still be in order to provide that support. :) Side comments: even if you are using 3.5.13.1, notice that in the R14 development branch that there has been significant package and app renaming. Thus kdegraphics is now tdegraphics. Therefore some comments might seem appropriate in 3.5.13.1 but will not apply in R14. Hence the continuing review of these changes. Eventually I'll push them to GIT. Slavek will decide whether to backport the changes to 3.5.13.1 but often with these types of changes he has to cherry pick, which is more work than just backporting the whole patch. :) Darrell

Suggested changes to tdebase: setted concurantly -> set concurrently if it is so, when WITH_SHADOW will have no effect -> WITH_PAM will override WITH_SHADOW next options are also required -> then the following options are also required Permanent. :) Not everybody is building and using packages from GIT for the simple reason that GIT is, technically, the development/experimental branch. Thus many people might not notice these changes. I have been using the GIT branch as my primary desktop environment for several months. Therefore I'm more intimate with these changes than most people using Trinity. :) Description: The TDEHW libs provide hardware detection formerly provided by HAL. We are using bug report 850 to track TDEHW implementation. I have been providing technical writing services for three decades. Thus, I have an eye to catch these things. :) I'm a tad lazy with my correspondence in this list, but for the official documentation I have high standards. So don't worry too much. I could make the changes myself and push to GIT but that would not provide you an opportunity to know what could or should be changed. I also don't believe I should make changes without your knowledge because that action would be construed as subversive and not courteous. :) My only goal is to ensure Trinity documentation is professional, not to be an anal ass about what you propose. ;) There are others in the project who do not speak/write English natively. I watch for that and try to help, just as I am doing here. Conversely, I don't speak/write other languages and I rely on them to ensure texts are translated correctly. :) Adding the comments to the CMakeLists.txt files is a great idea. As long as we are patient with one another the patches will get pushed to GIT. :) Darrell

I pushed to GIT the comment additions for tdebase, tdegraphics, and tdeartwork. :) Darrell

2012/11/20 Fat-Zer &lt;fatzer2(a)gmail.com&gt;om>: sorry, haven't saved the file... here is the right one.

2012/11/21 Darrell Anderson &lt;humanreadable(a)yahoo.com&gt;