Hello, a typo in git hash 888a696a http://www.trinitydesktop.org/patches/1376773191:888a696a3d1c31bbd32c75f80a69dab8e6d031ee.diff is causing FTBFS in kcontrol/tdm/tdm-shut.cpp, because invalid syntax.
diff --git a/kcontrol/tdm/tdm-shut.cpp b/kcontrol/tdm/tdm-shut.cpp index 2d8a565..5b295b5 100644 --- a/kcontrol/tdm/tdm-shut.cpp +++ b/kcontrol/tdm/tdm-shut.cpp @@ -1,4 +1,4 @@ -/* This file is part of the KDE Display Manager Configuration package +*/ This file is part of the KDE Display Manager Configuration package Copyright (C) 1997-1998 Thomas Tanghus (tanghus@earthling.net)
This program is free software; you can redistribute it and/or
Please fix it,
Thanks Francois
On Sunday 18 of August 2013 10:25:10 François Andriot wrote:
Hello, a typo in git hash 888a696a http://www.trinitydesktop.org/patches/1376773191:888a696a3d1c31bbd32c75f80 a69dab8e6d031ee.diff is causing FTBFS in kcontrol/tdm/tdm-shut.cpp, because invalid syntax.
diff --git a/kcontrol/tdm/tdm-shut.cpp b/kcontrol/tdm/tdm-shut.cpp index 2d8a565..5b295b5 100644 --- a/kcontrol/tdm/tdm-shut.cpp +++ b/kcontrol/tdm/tdm-shut.cpp @@ -1,4 +1,4 @@ -/* This file is part of the KDE Display Manager Configuration package +*/ This file is part of the KDE Display Manager Configuration package Copyright (C) 1997-1998 Thomas Tanghus (tanghus@earthling.net)
This program is free software; you can redistribute it and/orPlease fix it,
Thanks Francois
Fixed in GIT hash df510360. Thanks for warning!
Slavek
Le 18/08/2013 10:41, Slávek Banko a écrit :
Fixed in GIT hash df510360. Thanks for warning!
Slavek
Thank you Slávek ! While you're here, can you please update the "create_tarball" script too ? I've just discovered the "pigz" utility, which creates gzip archives but with multithreaded compression, making it much faster! http://zlib.net/pigz/
(maybe there are same kind of utilities for bzip2 and XZ too)
Line 17: "gzip"|"pigz") TAR_SUFFIX="gz";;
Thanks François
On Sunday 18 of August 2013 11:22:27 François Andriot wrote:
Le 18/08/2013 10:41, Slávek Banko a écrit :
Fixed in GIT hash df510360. Thanks for warning!
Slavek
Thank you Slávek ! While you're here, can you please update the "create_tarball" script too ? I've just discovered the "pigz" utility, which creates gzip archives but with multithreaded compression, making it much faster! http://zlib.net/pigz/
(maybe there are same kind of utilities for bzip2 and XZ too)
Line 17: "gzip"|"pigz") TAR_SUFFIX="gz";;
Thanks François
That sounds good. I looked around and found pbzip2 and pxz. So I added support for all three.
Added in GIT hash a48d32b2
Thanks Slávek
-
François Andriot -
Slávek Banko