Tim, Serghei,
As we find the headers that need to be patched with '#include <cstddef>', can those be updated in SVN? Is there any reason not? If adding the include won't impact those building on gcc < 4.6, then I say we do it so that the code is 4.6 compliant and won't need fixing later.
What say the experts?
So far I have:
kdegraphics:
--- kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h +++ kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h 2011-05-08 11:47:20.000000000 -0500 @@ -56,6 +56,7 @@
#ifndef _GSMARTPOINTER_H_ #define _GSMARTPOINTER_H_ +#include <cstddef> #ifdef HAVE_CONFIG_H #include "config.h" #endif
They can be handled in the build scripts, but I would like to minimize the proliferation of patch files and eliminated the if "already applied" then "don't patch again dummy" fi statements :p
Le Mon, 09 May 2011 17:18:11 -0500, "David C. Rankin" drankinatty@suddenlinkmail.com a écrit :
Tim, Serghei,
As we find the headers that need to be patched with '#include <cstddef>', can those be updated in SVN? Is there any reason not? If adding the include won't impact those building on gcc < 4.6, then I say we do it so that the code is 4.6 compliant and won't need fixing later.
If #include'ing <cstddef> to a header breaks compilation of the code with any compiler, there are serious problems with the code and they shall be solved.
What say the experts?
So far I have:
kdegraphics:
--- kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h +++ kdegraphics/kviewshell/plugins/djvu/libdjvu/GSmartPointer.h 2011-05-08 11:47:20.000000000 -0500 @@ -56,6 +56,7 @@
#ifndef _GSMARTPOINTER_H_ #define _GSMARTPOINTER_H_ +#include <cstddef> #ifdef HAVE_CONFIG_H #include "config.h" #endif
They can be handled in the build scripts, but I would like to minimize the proliferation of patch files and eliminated the if "already applied" then "don't patch again dummy" fi statements :p
Le Mon, 09 May 2011 17:18:11 -0500, "David C. Rankin" drankinatty@suddenlinkmail.com a écrit :
Tim, Serghei,
As we find the headers that need to be patched with '#include <cstddef>', can those be updated in SVN? Is there any reason not? If adding the include won't impact those building on gcc < 4.6, then I say we do it so that the code is 4.6 compliant and won't need fixing later.
If #include'ing <cstddef> to a header breaks compilation of the code with any compiler, there are serious problems with the code and they shall be solved.
Both of you are correct. As you find them, please add the filenames to the list at http://trinity.etherpad.trinitydesktop.org/27 and I or Serghei will commit them to SVN and remove them from that list every now and then
Thanks!
Tim
theres a correct build with gcc 4.6 support.. this can be helpfull
see : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611255
a release of qt3 susesfully patched for gcc 4.6 can be!
On 5/9/11, Timothy Pearson kb9vqf@pearsoncomputing.net wrote:
Le Mon, 09 May 2011 17:18:11 -0500, "David C. Rankin" drankinatty@suddenlinkmail.com a écrit :
Tim, Serghei,
As we find the headers that need to be patched with '#include <cstddef>', can those be updated in SVN? Is there any reason not? If adding the include won't impact those building on gcc < 4.6, then I say we do it so that the code is 4.6 compliant and won't need fixing later.
If #include'ing <cstddef> to a header breaks compilation of the code with any compiler, there are serious problems with the code and they shall be solved.
Both of you are correct. As you find them, please add the filenames to the list at http://trinity.etherpad.trinitydesktop.org/27 and I or Serghei will commit them to SVN and remove them from that list every now and then
Thanks!
Tim
To unsubscribe, e-mail: trinity-devel-unsubscribe@lists.pearsoncomputing.net For additional commands, e-mail: trinity-devel-help@lists.pearsoncomputing.net Read list messsages on the Web archive: http://trinity-devel.pearsoncomputing.net/ Please remember not to top-post: http://trinity.pearsoncomputing.net/mailing_lists/#top-posting
On Tue, May 10, 2011 at 14:48, PICCORO McKAY Lenz mckaygerhard@gmail.com wrote:
theres a correct build with gcc 4.6 support.. this can be helpfull
see : http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=611255
a release of qt3 susesfully patched for gcc 4.6 can be!
which has nothing to do with this topic, so let's leave that be. besides, we've gone over the gcc46 patch a lot already.
-
/dev/ammo42 -
David C. Rankin -
PICCORO McKAY Lenz -
Robert Xu -
Timothy Pearson