On Tuesday 18 of February 2014 23:00:24 David C. Rankin wrote:

On 02/18/2014 03:36 PM, David C. Rankin wrote:

...

On 02/18/2014 03:30 PM, David C. Rankin wrote:

...

All,

Working further with kmymoney, I have run across a build failure due to a missing icon: kmymoneytitlelabel.png. The failure occurs at the end of the build during the packaging stage:

/usr/bin/install -c -p -m 644 /build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/$file /build/tde-kmymoney/pkg/tde-kmymoney/opt/trinity/share/apps/kmymoney2/pi cs; \ done /usr/bin/install: cannot stat '/build/tde-kmymoney/src/kmymoney/kmymoney2/widgets/kmymoneytitlelabel.p ng': No such file or directory

The icons is not in the tde git tree:

15:23 phoinix:/dat_e/tde/tde/main/applications/kmymoney> find . -name kmymoneytitlelabel.png

<nothing>

The build system looks for the icon here:

kmymoney2/widgets/Makefile:689:WIDGET_PNGS = kmymoneytitlelabel.png kmymoney2/widgets/Makefile.am:54:WIDGET_PNGS = kmymoneytitlelabel.png kmymoney2/widgets/Makefile.in:689:WIDGET_PNGS = kmymoneytitlelabel.png

Does anyone have a patch/substitute for this icon? It is apparently triggered when building with 'libofx' features enabled:

./configure \ --prefix=${TDEDIR} \ --with-qmake=${QTDIR}/bin/tqmake \ --with-qt-dir=${QTDIR} \ --with-qt-includes=${QTDIR}/include \ --with-qt-libraries=${QTDIR}/lib \ --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \ --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \ --sysconfdir=${TDEDIR}/etc \ --localstatedir=/var \ --disable-dependency-tracking \ --disable-gcc-hidden-visibility \ $enable_pdfdocs \ --enable-new-ldflags \ --enable-rpath \ --enable-ofxplugin \ --enable-ofxbanking \ --enable-qtdesigner \ --disable-sqlite3 \ --enable-qtdesigner \ --disable-debug \ --disable-final \ --enable-closure

I am tinkering with enabling more of the options after Francios confirmed he was able to build with those options enabled. The build completed fine, the packaging of the icon is the problem.

Here is the answer from the changelog at sourceforge:

2011-05-21 06:32 conet

• kmymoney/widgets/CMakeLists.txt, kmymoney/widgets/kmymoneytitlelabel.png: Remove unused file.

http://kmymoney2.sourceforge.net/ChangeLog-4.5.95.txt

I'll work on a patch.

The easiest fix is just to add the missing icon back to the tde git tree, since the icon IS required for the TDE build. I have obtained a copy of the icon from one of Francios old packages and kmymoney then builds fine. The old package containing the icon was:

ftp://fr2.rpmfind.net/linux/sourceforge/m/ma/magiclinux-plus/update30/RPMS. trinity/trinity-kmymoney-common-1.0.5-4mgc30.opt.x86_64.rpm

The icon is attached. Darrell/Slavek/Francios please push this icon to git in the /tde/main/applications/kmymoney/kmymoney2/widgets directory.

This icon is very much needed in the TDE version of kmymoney with the options above.

Interesting. I checked build.log and in my building kmymoneytitlelabel.png is not asked.

I tried to find out if this icon is sometimes used, and I could not find any place. It would be better instead of returning unused image, cancel the installation of this image?

Slavek --

On 02/18/2014 04:29 PM, David C. Rankin wrote:

On 02/18/2014 04:16 PM, E. Liddell wrote:

...

On Tue, 18 Feb 2014 15:30:14 -0600 "David C. Rankin" drankinatty@suddenlinkmail.com wrote:

...

All,

Working further with kmymoney, I have run across a build failure due to a missing icon: kmymoneytitlelabel.png. [...]

Does anyone have a patch/substitute for this icon?

The file still exists in the application's repository on SourceForge: http://kmymoney2.cvs.sourceforge.net/viewvc/kmymoney2/kmymoney2/kmymoney2/wi...

E. Liddell

That's just bizarre. It exists in the sourceforge source, it is listed as being removed in the sourceforge changelog in 2011, and it is missing from the TDE git tree -- Go Figure -- Glad to know the rest of the world runs like a well oiled machine :)

How do you square that with the changelog?

2011-05-21 06:32 conet

• kmymoney/widgets/CMakeLists.txt, kmymoney/widgets/kmymoneytitlelabel.png: Remove unused file.

http://kmymoney2.sourceforge.net/ChangeLog-4.5.95.txt

I just copied the icon back to the proper kmymoney2/widgets directory in my sources and the build completes fine. We need to make sure it gets put back in the TDE kmymoney source...

I can confirm a successful build/install of kmymoney with every option except sqlite3 with the following:

depends=('tde-tdebase' 'libofx')

[ "$QTDIR" = "" ] && . /etc/profile.d/tqt3.sh # or tqt3.sh [ "$TDEDIR" = "" ] && . /etc/profile.d/trinity.sh # or tde.sh

## test for html2ps and set enabe/disable pdf-docs if test -x "/usr/bin/html2ps"; then enable_pdfdocs='--enable-pdf-docs' else enable_pdfdocs='--disable-pdf-docs' fi

## replace kmymoneytitlelabel.png missing in TDE git tree cd ${srcdir}/${pkgname#*-} cp -a ${srcdir}/kmymoneytitlelabel.png kmymoney2/widgets/

## Generate config files and update with autoreconf (as needed) cp /usr/share/aclocal/libtool.m4 ./admin/libtool.m4.in cp /usr/share/libtool/config/ltmain.sh ./admin make -f admin/Makefile.common

./configure \ --prefix=${TDEDIR} \ --with-qmake=${QTDIR}/bin/tqmake \ --with-qt-dir=${QTDIR} \ --with-qt-includes=${QTDIR}/include \ --with-qt-libraries=${QTDIR}/lib \ --with-extra-includes="/usr/include/tqt:/usr/include/tqt/Qt" \ --with-extra-libs="${TDEDIR}/lib:${TDEDIR}/lib/trinity" \ --sysconfdir=${TDEDIR}/etc \ --localstatedir=/var \ --disable-dependency-tracking \ --disable-gcc-hidden-visibility \ $enable_pdfdocs \ --pdfdir=${TDEDIR}/share/doc \ --psdir=${TDEDIR}/share/doc \ --htmldir=${TDEDIR}/share/doc \ --enable-new-ldflags \ --enable-rpath \ --enable-ofxplugin \ --enable-ofxbanking \ --enable-qtdesigner \ --disable-sqlite3 \ --enable-qtdesigner \ --disable-debug \ --disable-final \ --enable-closure

make $NUMJOBS # VERBOSE=1

Other than sqlite3, the only other build failure I can detect is that any wanted documentation except for the TDE help system files will need to be manually installed during packaging. For example:

kmymoney/doc/en/kmymoney-user.pdf kmymoney/developer-doc/phb/kmymoney-phb.pdf

These docs are created but never installed by the automake files.

On 02/18/2014 06:06 PM, E. Liddell wrote:

One was in kmymoney/widgets and the other is in kmymoney*2*/widgets, thus winning them some sort of Confusing Directory Nomenclature award? Mention of the file was removed from the CMake build scripts, but no one actually noticed that the file itself was still in the repository? Take your pick.

E. Liddell

Confused? Yep!

But how did is disappear from /tde/main/applications/kmymoney/kmymoney2/widgets?

On 03/02/2014 12:52 PM, Slávek Banko wrote:

Please test build with commit 2031fb9c: Remove unused kmymoneytitlelable.png from installation.

OK, I will update to the latest git and build