Hi,
I noticed in the Amarok tray icon menu are missing entries Restore and Quit. So far I have not determine whether this is due to commit f3088bc3...
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
Hi,
I noticed in the Amarok tray icon menu are missing entries Restore and Quit. So far I have not determine whether this is due to commit f3088bc3...
Confirmed.
Darrell
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
I noticed in the Amarok tray icon menu are missing entries Restore and Quit. So far I have not determine whether this is due to commit f3088bc3...
On my system reversing commit f3088bc3 restores the missing menu options.
Darrell
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
I noticed in the Amarok tray icon menu are missing entries Restore and Quit. So far I have not determine whether this is due to commit f3088bc3...
On my system reversing commit f3088bc3 restores the missing menu options.
Darrell
I forgot to declare resizeEvent and showEvent as virtual void in amarok/src/systray.h; I haven't yet tested if fixing this will repair the regression. Aside from this slip-up I don't see anything in that commit that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods please let me know if it fixes the problem. Otherwise I'll try to track this down tomorrow when I have more time.
Thanks!
Tim
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
I forgot to declare resizeEvent and showEvent as virtual void in amarok/src/systray.h; I haven't yet tested if fixing this will repair the regression. Aside from this slip-up I don't see anything in that commit that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods please let me know if it fixes the problem. Otherwise I'll try to track this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h --- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500 +++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500 @@ -30,8 +30,8 @@ virtual void engineTrackPositionChanged( long position, bool /*userSeek*/ ); // get notified of 'highlight' color change virtual void paletteChange( const TQPalette & oldPalette ); - void resizeEvent ( TQResizeEvent * ); - void showEvent ( TQShowEvent * ); + virtual void resizeEvent ( TQResizeEvent * ); + virtual void showEvent ( TQShowEvent * );
private: bool event( TQEvent* );
Darrell
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
I forgot to declare resizeEvent and showEvent as virtual void in amarok/src/systray.h; I haven't yet tested if fixing this will repair the regression. Aside from this slip-up I don't see anything in that commit that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods please let me know if it fixes the problem. Otherwise I'll try to track this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h --- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500 +++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500 @@ -30,8 +30,8 @@ virtual void engineTrackPositionChanged( long position, bool /*userSeek*/ ); // get notified of 'highlight' color change virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
- virtual void resizeEvent ( TQResizeEvent * );
- virtual void showEvent ( TQShowEvent * );
private: bool event( TQEvent* );
Darrell
OK, thanks for testing.
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf5234...
Thanks!
Tim
On Monday 14 of July 2014 02:49:11 Timothy Pearson wrote:
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
I forgot to declare resizeEvent and showEvent as virtual void in amarok/src/systray.h; I haven't yet tested if fixing this will repair the regression. Aside from this slip-up I don't see anything in that commit that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods please let me know if it fixes the problem. Otherwise I'll try to track this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h --- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500 +++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500 @@ -30,8 +30,8 @@ virtual void engineTrackPositionChanged( long position, bool /*userSeek*/ ); // get notified of 'highlight' color change virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
- virtual void resizeEvent ( TQResizeEvent * );
- virtual void showEvent ( TQShowEvent * );
private: bool event( TQEvent* );
Darrell
OK, thanks for testing.
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523 4cb8327b2bfa1e0a025
Thanks!
Tim
Yes, I can look at it, but later - now I have time to go to sleep :)
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf5234...
Fixed in commit 609b1bf. The showEvent() needs to be passed to the parent class as well to allow full rendering of the menu. Cheers Michele
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA224
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf5234...
Fixed in commit 609b1bf. The showEvent() needs to be passed to the parent class as well to allow full rendering of the menu. Cheers Michele
I had been wondering if that was the case, but had not yet been able to test. Thanks for tracking that down and fixing it!
Tim
On Mon July 14 2014 10:11:17 am Michele Calgaro wrote:
Slavek, can you see any way that this commit could have affected the tray icon menu? https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf5234...
Fixed in commit 609b1bf. The showEvent() needs to be passed to the parent class as well to allow full rendering of the menu.
Looks fixed here. Thank you.
Darrell
-
Darrell -
Michele Calgaro -
Slávek Banko -
Timothy Pearson