13 Jul
2014
13 Jul
'14
6:39 p.m.
Hi,
I noticed in the Amarok tray icon menu are missing entries Restore and Quit.
So far I have not determine whether this is due to commit f3088bc3...
--
Slávek
13 Jul
13 Jul
6:47 p.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
Hi,
I noticed in the Amarok tray icon menu are missing entries Restore and Quit.
So far I have not determine whether this is due to commit f3088bc3...
Confirmed.
Darrell
9:21 p.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
I noticed in the Amarok tray icon menu are missing
entries Restore and Quit.
So far I have not determine whether this is due to commit f3088bc3...
On my system reversing commit f3088bc3 restores the missing menu options.
Darrell
14 Jul
14 Jul
12:01 a.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224
On Sun July 13 2014 1:39:42 pm Slávek Banko wrote:
I forgot to declare resizeEvent and showEvent as virtual void in
amarok/src/systray.h; I haven't yet tested if fixing this will repair the
regression. Aside from this slip-up I don't see anything in that commit
that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods
please let me know if it fixes the problem. Otherwise I'll try to track
this down tomorrow when I have more time.
Thanks!
Tim
I noticed in the Amarok tray icon menu are
missing entries Restore and
Quit.
So far I have not determine whether this is due to commit f3088bc3...
On my system reversing commit f3088bc3 restores the missing menu options.
Darrell -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iFYEARELAAYFAlPDHdMACgkQLaxZSoRZrGEPCwDfTokvvBMGXa33khfYM/QZr1UZ
xa7s7P4tBMuqUgDfVrCyLhy6bFhcAsbusgnYCgs0rtpXiXb4/CcTWw==
=ipuV
-----END PGP SIGNATURE-----
12:44 a.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
I forgot to declare resizeEvent and showEvent as
virtual void in
amarok/src/systray.h; I haven't yet tested if fixing this will repair the
regression. Aside from this slip-up I don't see anything in that commit
that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two methods
please let me know if it fixes the problem. Otherwise I'll try to track
this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h
--- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500
+++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500
@@ -30,8 +30,8 @@
virtual void engineTrackPositionChanged( long position, bool /*userSeek*/ );
// get notified of 'highlight' color change
virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
+ virtual void resizeEvent ( TQResizeEvent * );
+ virtual void showEvent ( TQShowEvent * );
private:
bool event( TQEvent* );
Darrell
12:49 a.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224
On Sun July 13 2014 7:01:24 pm Timothy Pearson wrote:
OK, thanks for testing.
Slavek, can you see any way that this commit could have affected the tray
icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523…
Thanks!
Tim
I forgot to declare resizeEvent and showEvent as
virtual void in
amarok/src/systray.h; I haven't yet tested if fixing this will repair
the
regression. Aside from this slip-up I don't see anything in that commit
that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two
methods
please let me know if it fixes the problem. Otherwise I'll try to track
this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h
--- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500
+++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500
@@ -30,8 +30,8 @@
virtual void engineTrackPositionChanged( long position, bool
/*userSeek*/ );
// get notified of 'highlight' color change
virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
+ virtual void resizeEvent ( TQResizeEvent * );
+ virtual void showEvent ( TQShowEvent * );
private:
bool event( TQEvent* );
Darrell -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iFYEARELAAYFAlPDKQcACgkQLaxZSoRZrGE3PwDaA/B9C81xy7Yi/y/7g0dmYufP
EedM+MCcJLJ6vQDfQkoCI1kNsKYVUr35r02i0HV9iXUWAC1bSJBxRQ==
=OKzL
-----END PGP SIGNATURE-----
1:46 a.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
On Monday 14 of July 2014 02:49:11 Timothy Pearson wrote:
Yes, I can look at it, but later - now I have time to go to sleep :)
--
Slavek
On Sun July 13
2014 7:01:24 pm Timothy Pearson wrote:
OK, thanks for testing.
Slavek, can you see any way that this commit could have affected the tray
icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523
4cb8327b2bfa1e0a025
Thanks!
Tim
I forgot to declare resizeEvent and showEvent as
virtual void in
amarok/src/systray.h; I haven't yet tested if fixing this will repair
the
regression. Aside from this slip-up I don't see anything in that commit
that should affect the menu options whatsoever.
If you want to try adding the missing virtual keyword to those two
methods
please let me know if it fixes the problem. Otherwise I'll try to track
this down tomorrow when I have more time.
The following patch does not resolve the missing menu:
diff -urN amarok/amarok/src/systray.h amarok.new/amarok/src/systray.h
--- amarok/amarok/src/systray.h 2014-07-09 19:52:56.000000000 -0500
+++ amarok.new/amarok/src/systray.h 2014-07-13 19:26:44.506064803 -0500
@@ -30,8 +30,8 @@
virtual void engineTrackPositionChanged( long position, bool
/*userSeek*/ );
// get notified of 'highlight' color change
virtual void paletteChange( const TQPalette & oldPalette );
- void resizeEvent ( TQResizeEvent * );
- void showEvent ( TQShowEvent * );
+ virtual void resizeEvent ( TQResizeEvent * );
+ virtual void showEvent ( TQShowEvent * );
private:
bool event( TQEvent* );
Darrell 
3:11 p.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
Slavek, can you see any way that this commit could
have affected the tray icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523…
Fixed in commit 609b1bf.
The showEvent() needs to be passed to the parent class as well to allow full rendering of
the menu.
Cheers
Michele
3:19 p.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA224
I had been wondering if that was the case, but had not yet been able to
test. Thanks for tracking that down and fixing it!
Tim
Slavek, can
you see any way that this commit could have affected the
tray icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523…
Fixed in commit 609b1bf.
The showEvent() needs to be passed to the parent class as well to allow
full rendering of the menu.
Cheers
Michele -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iFYEARELAAYFAlPD9RgACgkQLaxZSoRZrGH5iQDgyWAJecTZD9ykrzJwAukROgQI
UEecxwTpGHdAOQDdH2A+ORVYeYgjAhb/rXk3VkM2386g1JoOz6ppBA==
=at6V
-----END PGP SIGNATURE-----
5:46 p.m.
New subject: [trinity-devel] Missing entries in Amarok tray icon menu
On Mon July 14 2014 10:11:17 am Michele Calgaro wrote:
Looks fixed here. Thank you.
Darrell
Slavek, can
you see any way that this commit could have affected the tray icon menu?
https://git.trinitydesktop.org/cgit/amarok/commit/?id=f3088bc3de7db3d3bf523…
Fixed in commit 609b1bf.
The showEvent() needs to be passed to the parent class as well to allow full rendering of
the menu.
3581
days inactive
3582
days old
9 comments
4 participants
participants (4)
-
Darrell -
Michele Calgaro -
Slávek Banko -
Timothy Pearson