All,
Attachment 1958 is the completed source code that contains both patches supplied by Francios (attachment 1944 & 1945) applied. This code is ready to be added to the git tree under tde/main/applications. Once there, we will submit by patch a commit to change the menu location. Who will be the one that will push this over?
Likewise, the code for the katesort-plugin (attachment 1956) is ready to be added to the git tree as well. This as well go to tde/main/applications.
Who will be the one that can add the sources to the tree? Let's get this done before the 2/28 target date for R14 freeze.
Attachment 1958 is the completed source code that contains both patches supplied by Francios (attachment 1944 & 1945) applied. This code is ready to be added to the git tree under tde/main/applications. Once there, we will submit by patch a commit to change the menu location. Who will be the one that will push this over?
Likewise, the code for the katesort-plugin (attachment 1956) is ready to be added to the git tree as well. This as well go to tde/main/applications.
Who will be the one that can add the sources to the tree? Let's get this done before the 2/28 target date for R14 freeze.
I can push both xmleditor and kate sort but I won't. They have to be tested. Normal testing requires at least two different distros, preferably three such as Debian based system, an RPM system, and an independent such as Arch or Slackware. Ever since I have been involved in this project I have seen many times where something works with one distro but not another. Sources can't be pushed flippantly because the Debian folks have to validate their packaging rules.
Regarding kate sort, I created two optional packages, which I'll attach later to the bug report. In one version I stripped all the cruft from the sources and updated the help handbook. That version can be added as a stand-alone package in applications. With the other option I merged the necessary files into tdeaddons/kate-plugins. I merged the sort handbook into the kate plugins handbook as well. I prefer this latter option because tdeaddons has been converted to cmake. As a stand-alone package I have to use --enable-closure to build with automake. The plugin works fine and is simple to use.
This is the kind of work and review thing I mean by quality control, not "works for me so push."
Don't worry about the Feb. 28 soft freeze. The etherpad states that minor enhancements and new features are still allowed until the hard freeze. Because these two additions are minor they qualify for being pushed after Feb. 28. In the mean time you have working patches for yourself and that should suffice until the review process completes.
I still have to test xmleditor, review the handbook, and verify I can build. If the handbook is html rather than docbook then that will require additional time to convert.
Right now I am trying to figure out what the hell happened to the bugzilla that I can't log in and my browser cookies are no longer recognized.
Darrell
Dne st 26. února 2014 Darrell napsal(a):
Right now I am trying to figure out what the hell happened to the bugzilla that I can't log in and my browser cookies are no longer recognized.
Darrell
Check if you do not have "/bugzilla/" in url. After the update, is bugzilla allergic to it.
On Wed February 26 2014 12:56:13 pm Slávek Banko wrote:
Dne st 26. února 2014 Darrell napsal(a):
Right now I am trying to figure out what the hell happened to the bugzilla that I can't log in and my browser cookies are no longer recognized.
Darrell
Check if you do not have "/bugzilla/" in url. After the update, is bugzilla allergic to it.
I finally got logged into the main page but when I select a bug report to review I'm logged back out.
I also can't figure out why everything is now underlined.
Darrell
On 02/26/2014 12:51 PM, Darrell wrote:
Attachment 1958 is the completed source code that contains both patches supplied by Francios (attachment 1944 & 1945) applied. This code is ready to be added to the git tree under tde/main/applications. Once there, we will submit by patch a commit to change the menu location. Who will be the one that will push this over?
Likewise, the code for the katesort-plugin (attachment 1956) is ready to be added to the git tree as well. This as well go to tde/main/applications.
Who will be the one that can add the sources to the tree? Let's get this done before the 2/28 target date for R14 freeze.
I can push both xmleditor and kate sort but I won't. They have to be tested. Normal testing requires at least two different distros, preferably three such as Debian based system, an RPM system, and an independent such as Arch or Slackware. Ever since I have been involved in this project I have seen many times where something works with one distro but not another. Sources can't be pushed flippantly because the Debian folks have to validate their packaging rules.
Regarding kate sort, I created two optional packages, which I'll attach later to the bug report. In one version I stripped all the cruft from the sources and updated the help handbook. That version can be added as a stand-alone package in applications. With the other option I merged the necessary files into tdeaddons/kate-plugins. I merged the sort handbook into the kate plugins handbook as well. I prefer this latter option because tdeaddons has been converted to cmake. As a stand-alone package I have to use --enable-closure to build with automake. The plugin works fine and is simple to use.
This is the kind of work and review thing I mean by quality control, not "works for me so push."
Don't worry about the Feb. 28 soft freeze. The etherpad states that minor enhancements and new features are still allowed until the hard freeze. Because these two additions are minor they qualify for being pushed after Feb. 28. In the mean time you have working patches for yourself and that should suffice until the review process completes.
I still have to test xmleditor, review the handbook, and verify I can build. If the handbook is html rather than docbook then that will require additional time to convert.
Right now I am trying to figure out what the hell happened to the bugzilla that I can't log in and my browser cookies are no longer recognized.
Darrell
That's fine -- let's get them tested. If we are freezing on Friday or Monday, they need to be tested and pushed by then. I've tested both on my end and they are fine to push. Get a couple more signoffs and then let's add them and close the bugs. I know we are all busy and I don't want these to slip through the cracks.
They are short and simple builds. I guarantee you that it took me longer to convert/debug them than it will take to build/test them :)
On 02/26/2014 01:03 AM, David C. Rankin wrote:
All,
Attachment 1958 is the completed source code that contains both patches supplied by Francios (attachment 1944 & 1945) applied. This code is ready to be added to the git tree under tde/main/applications. Once there, we will submit by patch a commit to change the menu location. Who will be the one that will push this over?
Likewise, the code for the katesort-plugin (attachment 1956) is ready to be added to the git tree as well. This as well go to tde/main/applications.
Who will be the one that can add the sources to the tree? Let's get this done before the 2/28 target date for R14 freeze.
Darrell, Slavek,
Will somebody please push the original source to git so we can apply the qt-tqt, kde-tde scripts and have this ready for Monday.
Darrell, also, push
http://bugs.pearsoncomputing.net/attachment.cgi?id=1965
This is the katesort plugin source, before conversion, as Slavek requested, renamed as you did to 'katesort' to become a subdir of the tdeaddons code and cleaned of ALL cruft. I have tested the conversion/build below and I am running it now (details in the bug report). All that will need to be done after pushing to build on R14 is:
(1) convert_existing_qt3_app_to_tqt3 (2) convert_existing_kde3_app_to_tde (3) copy Darrell's docbook fix/merge to doc dir
Let get these pushed, so the conversion on both will be done by soft-freeze on Monday.
Will somebody please push the original source to git so we can apply the qt-tqt, kde-tde scripts and have this ready for Monday.
Darrell, also, push
http://bugs.pearsoncomputing.net/attachment.cgi?id=1965
This is the katesort plugin source, before conversion, as Slavek requested, renamed as you did to 'katesort' to become a subdir of the tdeaddons code and cleaned of ALL cruft. I have tested the conversion/build below and I am running it now (details in the bug report). All that will need to be done after pushing to build on R14 is:
(1) convert_existing_qt3_app_to_tqt3 (2) convert_existing_kde3_app_to_tde (3) copy Darrell's docbook fix/merge to doc dir
Let get these pushed, so the conversion on both will be done by soft-freeze on Monday.
What is your panic and urgency? I wrote previously that a soft freeze allows for minor changes. The hard freeze stops everything and focuses only on bug fixes. We are not even close to the hard freeze.
The two patches will get merged for R14. Slavek knows how to do that. I don't.
Until then you have working patches to satisfy your usage. I am doing the same.
Darrell
On 03/01/2014 01:18 PM, Darrell wrote:
What is your panic and urgency? I wrote previously that a soft freeze allows for minor changes. The hard freeze stops everything and focuses only on bug fixes. We are not even close to the hard freeze.
The two patches will get merged for R14. Slavek knows how to do that. I don't.
Until then you have working patches to satisfy your usage. I am doing the same.
Darrell
I'm good with that, it's just that I like to put things in the '[x] done' column and tie up loose ends.
Pushing shoule be easy, just decompress both in your copy of the tree, confirm they are in the proper place, and then commit -m "881 and 1955 sources". The only question I have is under what branch he wants to put them. Slavek, ball is in your court.
-
Darrell -
David C. Rankin -
Slávek Banko