tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
19 Jul
2012
19 Jul
'12
5:45 p.m.
Tim, Darrell,
One problem with gentdmconf is that arch does not have an /etc/X11/Xsession
file. So when gentdeconf creates the Xsession file with an include for
/etc/X11/Xsession, the login fails. What needs to be changed is a simple check
to make sure the file exists before sourcing it. i.e.:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
--
David C. Rankin, J.D.,P.E.
20 Jul
20 Jul
4:06 p.m.
New subject: [Patch] Re: [trinity-devel] tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
On 07/19/2012 12:45 PM, David C. Rankin wrote:
Tim, Darrell,
One problem with gentdmconf is that arch does not have an /etc/X11/Xsession
file. So when gentdeconf creates the Xsession file with an include for
/etc/X11/Xsession, the login fails. What needs to be changed is a simple check
to make sure the file exists before sourcing it. i.e.:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
Patch attached.
--
David C. Rankin, J.D.,P.E.
4:33 p.m.
New subject: [trinity-devel] [Patch] Re: [trinity-devel] tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
Le 20/07/2012 18:06, David C. Rankin a écrit :
On 07/19/2012 12:45 PM, David C. Rankin wrote:
Hello, under RHEL/Fedora, the Xsession file exists but is located elsewhere.
Can we please add the same kind of check, e.g:
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
So that I wouldn't need to patch again when packaging.
Thanks
Francois
Tim, Darrell,
One problem with gentdmconf is that arch does not have an
/etc/X11/Xsession
file. So when gentdeconf creates the Xsession file with an include for
/etc/X11/Xsession, the login fails. What needs to be changed is a
simple check
to make sure the file exists before sourcing it. i.e.:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
Patch attached.
5:03 p.m.
New subject: [trinity-devel] [Patch] Re: [trinity-devel] tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
On 07/20/2012 11:33 AM, Francois Andriot wrote:
Hello, under RHEL/Fedora, the Xsession file exists but
is located elsewhere.
Can we please add the same kind of check, e.g:
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
So that I wouldn't need to patch again when packaging.
Thanks
Francois
Sure,
Anybody else have any other locations?? It is a simple matter to just go
down a list of sequential checks:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
...
If there is a huge number, we can just throw it into an array to save space:
declare -a xSloc
xSloc=( '/etc/X11' '/etc/X11/xinit' '/etc/X11/whereever' )
for l in ${xSloc[@]}; do
[[ -r ${l}/Xsession ]] && . ${l}/Xsession
done
Once we get a list, I'll do another patch and Darrell or Tim can push.
--
David C. Rankin, J.D.,P.E.
9 p.m.
New subject: [trinity-devel] [Patch] Re: [trinity-devel] tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
On Fri, 20 Jul 2012 12:03:07 -0500
"David C. Rankin" <drankinatty(a)suddenlinkmail.com> wrote:
On 07/20/2012 11:33 AM, Francois Andriot wrote:
My system appears to have /etc/X11/Sessions/Xsession rather than
either of the other two.
Hello, under RHEL/Fedora, the Xsession file
exists but is located elsewhere.
Can we please add the same kind of check, e.g:
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
So that I wouldn't need to patch again when packaging.
Thanks
Francois
Sure,
Anybody else have any other locations?? It is a simple matter to just go
down a list of sequential checks:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
...
If there is a huge number, we can just throw it into an array to save space:
declare -a xSloc
xSloc=( '/etc/X11' '/etc/X11/xinit' '/etc/X11/whereever' )
for l in ${xSloc[@]}; do
[[ -r ${l}/Xsession ]] && . ${l}/Xsession
done
Once we get a list, I'll do another patch and Darrell or Tim can push.
8:59 p.m.
New subject: [trinity-devel] [Patch] Re: [trinity-devel] tdm login screen - gentdmconf, need to check existence of /etc/X11/Xsession before sourcing
On 07/20/2012 04:00 PM, E. Liddell wrote:
My system appears to have /etc/X11/Sessions/Xsession
rather than
either of the other two.
OK, the list is now:
[[ -r /etc/X11/Xsession ]] && . /etc/X11/Xsession
[[ -r /etc/X11/xinit/Xsession ]] && . /etc/X11/xinit/Xsession
[[ -r /etc/X11/Sessions/Xsession ]] && . /etc/X11/Sessions/Xsession
--
David C. Rankin, J.D.,P.E.
4308
days inactive
4309
days old
5 comments
3 participants
participants (3)
-
David C. Rankin -
E. Liddell -
Francois Andriot