8 Jul
2015
8 Jul
'15
4:55 p.m.
Hi Michele, Tim, all,
I'm here again with another proposal to push patch into upcoming R14.0.1! And
I think that this one-line patch will be pushed without controversy ;)
See attachment in Bug 2454:
http://bugs.trinitydesktop.org/show_bug.cgi?id=2454
--
Slávek
8 Jul
8 Jul
6:23 p.m.
New subject: [trinity-devel] Proposal to push patches
On Wed July 8 2015 11:55:48 am Slávek Banko wrote:
Hi Michele, Tim, all,
I'm here again with another proposal to push patch into upcoming R14.0.1! And
I think that this one-line patch will be pushed without controversy ;)
See attachment in Bug 2454:
http://bugs.trinitydesktop.org/show_bug.cgi?id=2454
What is the criteria for pushing patches in 14.0.1? I see many proposed patches in the
bugzilla.
Darrell
8:27 p.m.
New subject: [trinity-devel] Proposal to push patches
On Wednesday 08 of July 2015 20:23:54 Darrell wrote:
On Wed July 8 2015 11:55:48 am Slávek Banko wrote:
Good question. Because we are in a phase freeze, so I would say that the
candidate to push should address a serious bug - for example, application
crash, FTBFS and similar problems. At the same time at the patch should not
be risky to have unexpected side effects. The patch should also gain support
of at least two developers with commit access.
--
Slávek
Hi Michele, Tim, all,
I'm here again with another proposal to push patch into upcoming R14.0.1!
And I think that this one-line patch will be pushed without controversy
;)
See attachment in Bug 2454:
http://bugs.trinitydesktop.org/show_bug.cgi?id=2454
What is the criteria for pushing patches in 14.0.1? I see many proposed
patches in the bugzilla.
Darrell
9 Jul
9 Jul
1:58 a.m.
New subject: [trinity-devel] Proposal to push patches
On Wed July 8 2015 3:27:19 pm Slávek Banko wrote:
Good question. Because we are in a phase freeze, so I
would say that the
candidate to push should address a serious bug - for example, application
crash, FTBFS and similar problems. At the same time at the patch should not
be risky to have unexpected side effects. The patch should also gain support
of at least two developers with commit access.
In that case, in addition to bug 2454, perhaps the following could be added:
1610 Change KAlarm autostart delay from 30 to 3 seconds
2023 Remove an obsolete comment
2123 Fix incorrect directory permissions for /tmp/tdesocket-global
2255 Update kalarm calendar.ics
2283 Change [exitkde] group to [exittde]
Darrell
2:50 a.m.
New subject: [trinity-devel] Proposal to push patches
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
I'm here again with another proposal to push patch
into upcoming
R14.0.1! And I think that this one-line patch will be pushed
without controversy
Slavek,
the patch looks good and safe. IMO you can go ahead and push even
though we are in freeze mode.
1610 Change KAlarm autostart delay from 30 to 3
seconds 2023 Remove
an obsolete comment 2123 Fix incorrect directory permissions for
/tmp/tdesocket-global 2255 Update kalarm calendar.ics 2283 Change
[exitkde] group to [exittde]
Since we are in freeze state, personally I think it would be better to
address the above list of patches for R14.0.2 (if I remember
correctly, 2283 requires careful analysis, it is not as easy as it
looked).
Perhaps we can give the above bugs a priority for R14.0.2 inclusion.
Just my 2 cents
Michele
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQIcBAEBCgAGBQJVneFZAAoJECp1t8qK3tXPtZoP/0s9RTE+wkxUDu9XTF1w0sNu
kQlbFBXS7rQytF/1Vnr/HYr7w5L5liJwL5t7u5YGJYD1kGfZJ6j0fdEMyxjUo2ev
yVETksY8HQd7rROkAajYmaBwf4kUo0F5XoLXip3WaBJdpX1j4YuSuTAMHM9nQK4W
2xv4wRUkaXhY7pAM/MnVRwng3Kg73I1v40Q8ljb+DHKbvbcPfB6c0MucraO5Awka
o8GWgNVyDO5h306YxBDlvDkvRr8UIyQP0WkMDGkmffhrb433HHyukPsD30lWvk7j
73mC8FJ7mWZ4CgjW130eWeACGczjgoXwWcLY8riYv/jvZXmjK6NWRewEJ0xxxtrW
sSWMcdDrza4EYaiyLroxugQO1bbcXO3Ozpy6t9oGRTHzn57QxQ1+akLCmb7fQbEo
tLewf8W+1ljppr2sSwJbODvrM+cx+PeH5m8zVraEcAmdpbMCEnWzWWNbQ8bWxSO8
DiT2wInPPyymYmmECwSVAzdxUKeOLX0nIOegPxl6j5XffdwyDiZnDcIaSNBT2zWq
Oyx0zlO9hH8n3TWxa1ocPaebRSyZjZTmUocl7vfRbVupr8Dma4mzNgdC7EkCa0Nw
b4yTDNywKSVrPwUlQfr6skXZhpwHmAkClyCdOs7JUe7V6ENFuMLpSMNcjFpJNYuU
8CpnwYpfeMRsZEWvVL64
=2Mic
-----END PGP SIGNATURE-----
1:38 p.m.
New subject: [trinity-devel] Proposal to push patches
On Thursday 09 of July 2015 04:50:01 Michele Calgaro wrote:
Patches from bug 1610 and 2123 could be pushed.
Patch from bug 2023 is irrelevant to the functionality - can be pushed to the
master and wait for the R14.0.2.
Patch from bug 2255 addresses only one from ICS files - for example, there is
also share/apps/karm/karm.ics, apps/knotes/notes.ics. A separate question is
whether to change the X-KDE in the data files when it breaks compatibility
with KDE equivalents. This patch should be definitely postponed for later.
Patch from bug 2283 is not complete - it would be necessary to add the
renaming also to script r14-xdg-update. It may be included in R14.0.2.
--
Slávek
1610 Change
KAlarm autostart delay from 30 to 3 seconds 2023 Remove
an obsolete comment 2123 Fix incorrect directory permissions for
/tmp/tdesocket-global 2255 Update kalarm calendar.ics 2283 Change
[exitkde] group to [exittde]
Since we are in freeze state, personally I think it would be better to
address the above list of patches for R14.0.2 (if I remember
correctly, 2283 requires careful analysis, it is not as easy as it
looked).
Perhaps we can give the above bugs a priority for R14.0.2 inclusion.
Just my 2 cents
Michele
3216
days inactive
3217
days old
5 comments
3 participants
participants (3)
-
Darrell -
Michele Calgaro -
Slávek Banko